HomeWildfire Games
Diffusion 0 A.D. Public Repository rP27742

Add a test for the FSM
rP27742
Actions

Description

Add a test for the FSM

Accepted By: @wraitii

Differential Revision: https://code.wildfiregames.com/D4902

Details

Committed
phositJun 27 2023, 9:20 PM
Differential Revision
D4902: Add a test for FSM
Parents
rP27741: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22090
Build 53920: Trigger Windows Autobuild
Build 53919: Post-Commit BuildJenkins
Build 53918: Post-Commit Build (macOS)Jenkins

Event Timeline

phosit added an edge: D4902: Add a test for FSM.Jun 27 2023, 9:23 PM
phosit committed rP27742: Add a test for the FSM.Jun 27 2023, 9:20 PM
phosit added a subscriber: wraitii.Jun 27 2023, 9:23 PM
Harbormaster completed building B22090: rP27742: Add a test for the FSM.Jun 27 2023, 9:38 PM
vladislavbelov added a subscriber: vladislavbelov.Jun 27 2023, 10:17 PM

@phosit tests should also follow CC.

/ps/trunk/source/network/tests/test_FSM.h
32–38

Incorrect function naming by CC.

46–55

We don't use lower camel case for enums. Even tests should follow CC. Also unsigned int is redundant here as we don't use its unsigness.

phosit added inline comments.Jun 28 2023, 8:52 AM
/ps/trunk/source/network/tests/test_FSM.h
32–38

Schould i make a diff to correct that?

46–55

The event type of the fsm is an unsigned int.

Stan added a subscriber: Stan.Jun 29 2023, 3:20 PM
Stan added inline comments.
/ps/trunk/source/network/tests/test_FSM.h
32–38

Yes ideally.

vladislavbelov added inline comments.Jun 29 2023, 11:21 PM
/ps/trunk/source/network/tests/test_FSM.h
46–55

You cast it anyway.

phosit added inline comments.Jul 1 2023, 11:08 AM
/ps/trunk/source/network/tests/test_FSM.h
46–55

Now i only convert it to it's underlying type.

vladislavbelov added inline comments.Jul 2 2023, 8:11 PM
/ps/trunk/source/network/tests/test_FSM.h
46–55

Yeah, but it means you hard code the type in each cast. Also it makes the code more noisy.

phosit mentioned this in rP27781: Correct syntax mistakes made in rP27742.Jul 24 2023, 10:19 AM

Changes (1)

PathSize
ps/
trunk/
source/
network/
tests/

rP27742

View Options

ps/trunk/source/network/tests/test_FSM.h

Loading...
Wildfire Games · Phabricator