HomeWildfire Games
Diffusion 0 A.D. Public Repository rP27786

Make the space in 0 A.D. non-breaking throughout the codebase.
Concern RaisedrP27786
Actions

Description

Make the space in 0 A.D. non-breaking throughout the codebase.
Avoid cases of filenames
Update years in terms and other legal(ish) documents
Don't update years in license headers, since change is not meaningful

Will add linter rule in seperate commit

Happy recompiling everyone!

Original Patch By: Nescio
Comment By: Gallaecio
Differential Revision: D2620

Details

Auditors
vladislavbelov
Stan
Committed
bbJul 27 2023, 10:54 PM
Differential Revision
D2620: use non-breaking space in 0 A.D.
Parents
rP27785: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22195
Build 54228: Trigger Windows Autobuild
Build 54227: Post-Commit BuildJenkins
Build 54226: Post-Commit Build (macOS)Jenkins

Event Timeline

bb committed rP27786: Make the space in 0 A.D. non-breaking throughout the codebase..Jul 27 2023, 10:54 PM
bb added an edge: D2620: use non-breaking space in 0 A.D..Jul 27 2023, 10:57 PM
Harbormaster completed building B22195: rP27786: Make the space in 0 A.D. non-breaking throughout the codebase..Jul 28 2023, 12:25 AM
vladislavbelov raised a concern with this commit.EditedJul 28 2023, 9:07 AM
vladislavbelov added a subscriber: vladislavbelov.

@Stan @Itms

The commit is different from the diff. The diff wasn't containing changes for source files (license headers in C++ files). The https://code.wildfiregames.com/D2620#183598 comment confirms that. C++ source files shouldn't contain special characters until agreed. That part of the commit should be reverted.

UPD.

  • Using non-breaking space might break search/indexing for external services.
  • Have you checked that all affected files are rendered correctly for all distros? For example: build/resources/0ad.desktop, build/resources/0ad.appdata.xml, build/android/sdl-project/res/values/strings.xml, source/tools/autolog/SVNLog/lib/SVNLog/Controller/LogUpdate.pm, etc.
  • TeX uses ~/\nobreak for such spaces.
  • source/tools/i18n/tests/test_checkDiff.py and source/tools/mapcompatibility/a18_to_a19.py are broken now for Python 2.
  • source/tools/i18n/tests/test_checkDiff.py became incorrect as binaries/data/l10n/bar.engine.po doesn't contain non-breaking space for Project-Id-Version.
  • For some files (source/collada/PSAConvert.cpp) some editors (FAR) display 0B A.D. instead of 0 A.D..
  • Some editors (Visual Studio, Notepad++) don't show the non-breaking space as a special character when enabling such functionality.
This commit now has outstanding concerns.Jul 28 2023, 9:07 AM
vladislavbelov added subscribers: Stan, Itms.Jul 28 2023, 11:31 AM
vladislavbelov mentioned this in rP27965: Revert non-ASCII characters from source and configuration files introduced in….Dec 3 2023, 1:30 AM
Stan added a comment.Dec 31 2023, 11:42 AM

Fixed as well.

vladislavbelov resigned from this commit.Dec 31 2023, 12:17 PM
This commit no longer requires audit.Dec 31 2023, 12:17 PM
Stan raised a concern with this commit.Tue, Apr 9, 7:18 PM

related https://github.com/0ad/0ad/pull/44

This commit now has outstanding concerns.Tue, Apr 9, 7:18 PM

Very Large Commit

This commit is very large, and affects more than 1000 files. Changes are not shown.
Wildfire Games · Phabricator