/ps/trunk/source/main.cpp
502	Technically the message should be "RL interface will be listening on ..." now :)
686	`Frame(rlInterface ? &rlInterface->value() : nullptr);` would be more readable.

phosit added inline comments.Oct 29 2023, 8:30 AM

/ps/trunk/source/main.cpp
686	`.value()` isn't implemented on the llvm version we use.

phosit added inline comments.Oct 29 2023, 9:02 AM

/ps/trunk/source/main.cpp
686	It's not implemented in the libc++ we use.

vladislavbelov added inline comments.Oct 29 2023, 1:18 PM

/ps/trunk/source/main.cpp
686	Yeah...

autobuild is broken (logs from Jenkins):

4>source\main.cpp(681): error C2280: 'std::optional<RL::Interface>::optional(const std::optional<RL::Interface> &)': attempting to reference a deleted function [build\workspaces\vs2017\pyrogenesis.vcxproj]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\optional(546): note: compiler has generated 'std::optional<RL::Interface>::optional' here
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\optional(546): note: 'std::optional<RL::Interface>::optional(const std::optional<RL::Interface> &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'std::_Deleted_move_assign<_Base,_Ty>::_Deleted_move_assign(const std::_Deleted_move_assign<_Base,_Ty> &)'
            with
            [
                _Base=std::_Optional_construct_base<RL::Interface>,
                _Ty=RL::Interface
            ]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\xsmf_control.h(164): note: 'std::_Deleted_move_assign<_Base,_Ty>::_Deleted_move_assign(const std::_Deleted_move_assign<_Base,_Ty> &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'std::_Deleted_copy_assign<_Base,_Ty>::_Deleted_copy_assign(const std::_Deleted_copy_assign<_Base,_Ty> &)'
            with
            [
                _Base=std::_Optional_construct_base<RL::Interface>,
                _Ty=RL::Interface
            ]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\xsmf_control.h(110): note: 'std::_Deleted_copy_assign<_Base,_Ty>::_Deleted_copy_assign(const std::_Deleted_copy_assign<_Base,_Ty> &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'std::_Optional_construct_base<_Ty>::_Optional_construct_base(const std::_Optional_construct_base<_Ty> &)'
            with
            [
                _Base=std::_Optional_construct_base<RL::Interface>,
                _Ty=RL::Interface
            ]
            and
            [
                _Ty=RL::Interface
            ]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\optional(186): note: 'std::_Optional_construct_base<_Ty>::_Optional_construct_base(const std::_Optional_construct_base<_Ty> &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'std::_Optional_destruct_base<_Ty,false>::_Optional_destruct_base(const std::_Optional_destruct_base<_Ty,false> &)'
            with
            [
                _Ty=RL::Interface
            ]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\optional(110): note: 'std::_Optional_destruct_base<_Ty,false>::_Optional_destruct_base(const std::_Optional_destruct_base<_Ty,false> &)': function was implicitly deleted because 'std::_Optional_destruct_base<_Ty,false>' has a variant data member 'std::_Optional_destruct_base<_Ty,false>::_Value' with a non-trivial copy constructor
            with
            [
                _Ty=RL::Interface
            ]
    c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\optional(87): note: see declaration of 'std::_Optional_destruct_base<_Ty,false>::_Value'
            with
            [
                _Ty=RL::Interface
            ]

This commit now has outstanding concerns.Oct 29 2023, 5:01 PM

Phylogix had the same error.
Thank you for the log. How did you get the log? I didn't found anything on jenkins.
I uploaded a fix: D5176

In rP27908#61408, @phosit wrote:

How did you get the log? I didn't found anything on jenkins.

I believe it requires to login.

I just created an account for them. For most pipelines, clicking the jenkins link that appears when the build fails or succeeds gives you access the pipeline.

Unfortunately the autobuild has nowhere to log its failure, so you have to check it yourself. As it runs once everyday everytime it's triggered, as a rule of thumb if the next morning after your commit you don't have an autobuild commit, then something went wrong. The autobuild pipeline is indeed not public.

phosit mentioned this in rP27914: Fix compile error introduced in rP27908.Nov 5 2023, 7:04 PM

Should be fixed now :)

vladislavbelov resigned from this commit.Dec 31 2023, 12:16 PM

This commit no longer requires audit.Dec 31 2023, 12:16 PM

phosit mentioned this in D5254: Shutdown mongoose in rl-interface gracefully.Mar 24 2024, 7:54 PM