Page MenuHomeWildfire Games

Rename modmod to modselection
AcceptedPublic

Authored by elexis on Dec 1 2017, 7:32 PM.

Details

Reviewers
bb
Silier
Summary

...to make it more obvious what thad directory means.

Test Plan

Search for "modmod" in JS, XML and cpp files.

Event Timeline

elexis created this revision.Dec 1 2017, 7:32 PM
Vulcan added a subscriber: Vulcan.Dec 1 2017, 7:32 PM

Build failure - The Moirai have given mortals hearts that can endure.

 Exception 
The program is attempting to read user input, but stdin is being piped from some other source (not a TTY).
(Run with `--trace` for a full exception trace.)
bb accepted this revision.Dec 3 2017, 10:24 PM
bb added subscribers: leper, bb.

Patch doesn't apply cleanly: PHAP????
The directory change doesn't show up as moved, but deleted/added (probably phab too)
Accepting phab is messing up...

Wasn't @leper very proud on his name?

This revision is now accepted and ready to land.Dec 3 2017, 10:24 PM
elexis added a comment.Dec 7 2017, 7:50 PM

(Likely. Just wondering if we don't prefer descriptive names.)

elexis abandoned this revision.Dec 12 2017, 8:40 PM
elexis reclaimed this revision.Feb 1 2020, 1:43 AM
This revision is now accepted and ready to land.Feb 1 2020, 1:43 AM
In D1095#44914, @elexis wrote:

(Likely. Just wondering if we don't prefer descriptive names.)

I appreciate the idea of modmod but it took me quite a while to figure out what that mod does (could be me of course). Thus, IMHO this still would be a good change.

wraitii added a subscriber: wraitii.Jun 3 2020, 1:56 PM

I also agree with this change, but it probably needs to be rebased and merged quickly so that it doesn't end up in merge conflicts everywhere. Might be a good candidate for a post-A24 commit.

Silier requested changes to this revision.Dec 24 2021, 11:00 PM
Silier added a subscriber: Silier.

need rebase

This revision now requires changes to proceed.Dec 24 2021, 11:00 PM
Silier resigned from this revision.Jul 31 2023, 5:27 PM
This revision is now accepted and ready to land.Jul 31 2023, 5:27 PM