Page MenuHomeWildfire Games

Skybox calculation - fix regression of rP22039 introduced in rP22297
ClosedPublic

Authored by wraitii on Jun 15 2019, 10:04 PM.

Details

Reviewers
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22399: Skybox calculation - fix regression of rP22039 introduced in rP22297
Summary

Use the opportunity to clean things up a bit.

Test Plan

Check that reflections enabled/disabled (with refractions) look almost the same.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jun 15 2019, 10:04 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1738/display/redirect

vladislavbelov accepted this revision.Fri, Jun 21, 6:00 PM

I tested, now the reflection works as after my commit.

This revision is now accepted and ready to land.Fri, Jun 21, 6:00 PM
elexis added a subscriber: elexis.Fri, Jun 21, 6:57 PM

(As mentioned byVladislav on IRC (http://irclogs.wildfiregames.com/2019-06/2019-06-21-QuakeNet-%230ad-dev.log) and in rP22297, this diff is correct because rP22297 reverted (and whitespace-formatted?) a hunk that was removed in rP22039.)

In D1985#83464, @elexis wrote:

(As mentioned byVladislav on IRC (http://irclogs.wildfiregames.com/2019-06/2019-06-21-QuakeNet-%230ad-dev.log) and in rP22297, this diff is correct because rP22297 reverted (and whitespace-formatted?) a hunk that was removed in rP22039.)

Why are you stating what git-blame can easily show to anyone.

(1) So that the one reading this diff knows what's happening.
(2) So that cross-references are inserted

This revision was automatically updated to reflect the committed changes.