Reported by kingu in Transifex: “Pretty sure genders come into play here and with 142”
I think the English string change makes gender less of an issue for most languages.
Details
Details
- Reviewers
Nescio elexis Itms Stan - Commits
- rP22685: Upgrade into a %(name)s → Upgrade to %(name)s
Only affects user-visible strings.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
Executing section JS...
| | [NORMAL] ESLintBear (space-before-function-paren):
| | Unexpected space before function parentheses.
|----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
| |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
| 763| 763| addResearchToQueue(data.item.researchFacilityId, t);
| 764| 764| })(tech);
| 765| 765|
| 766| |- button.onPressRight = (t => function () {
| | 766|+ button.onPressRight = (t => function() {
| 767| 767| showTemplateDetails(
| 768| 768| t,
| 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv);
binaries/data/mods/public/gui/session/selection_panels.js
| 48| » » » switch·(data.item)
| | [NORMAL] ESLintBear (default-case):
| | Expected a default case.
binaries/data/mods/public/gui/session/selection_panels.js
| 59| » » switch·(data.item)
| | [NORMAL] ESLintBear (default-case):
| | Expected a default case.
binaries/data/mods/public/gui/session/selection_panels.js
| 731| » » » » » » switch·(entity.check)
| | [NORMAL] ESLintBear (default-case):
| | Expected a default case.
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/docker-differential/349/display/redirect