Page MenuHomeWildfire Games
Differential D2307

improve default.cfg comments
Needs ReviewPublic
Actions

Authored by Nescio on Sep 19 2019, 9:00 PM.

Details

Reviewers
elexis
Summary

See discussion with @elexis in D2305.

[EDIT]: End sentences with a full stop.

Test Plan

Check for mistakes and omissions.

Diff Detail

Event Timeline

Nescio created this revision.Sep 19 2019, 9:00 PM
Vulcan added a comment.Sep 19 2019, 9:01 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/766/display/redirect

Harbormaster failed remote builds in B9484: Diff 9869!Sep 19 2019, 9:02 PM
Vulcan added a comment.Sep 19 2019, 9:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/254/display/redirect

elexis awarded a token.Sep 20 2019, 1:25 PM
Nescio mentioned this in D2309: Fix missing tooltip function in replay menu following loadgame and savegame unification rP22923 / D2290.Sep 21 2019, 9:24 AM
Nescio mentioned this in D2305: more gui/manual/intro.txt improvements.Sep 21 2019, 9:36 AM
Nescio updated this revision to Diff 9902.Sep 22 2019, 9:49 AM

"or replay"

Vulcan added a comment.Sep 22 2019, 9:51 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/277/display/redirect

Harbormaster failed remote builds in B9535: Diff 9902!Sep 22 2019, 9:52 AM
Vulcan added a comment.Sep 22 2019, 10:00 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/789/display/redirect

Freagarach added a subscriber: Freagarach.Sep 22 2019, 12:03 PM

Do we want periods after comments?

Nescio updated this revision to Diff 9923.Sep 22 2019, 9:28 PM
Nescio edited the summary of this revision. (Show Details)

End sentences with a full stop.

binaries/data/config/default.cfg
484

Ugly American spelling.

Vulcan added a comment.Sep 22 2019, 9:29 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/291/display/redirect

Nescio updated this revision to Diff 9924.Sep 22 2019, 9:30 PM
Vulcan added a comment.Sep 22 2019, 9:31 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/292/display/redirect

Vulcan added a comment.Sep 22 2019, 9:31 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/806/display/redirect

Harbormaster completed remote builds in B9558: Diff 9923.Sep 22 2019, 9:31 PM
Vulcan added a comment.Sep 22 2019, 9:34 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/807/display/redirect

Harbormaster completed remote builds in B9559: Diff 9924.Sep 22 2019, 9:34 PM

Revision Contents
Changeset List

PathSize
binaries/
data/
config/
423 lines

Diff 9924

View Options

binaries/data/config/default.cfg

Loading...
Wildfire Games · Phabricator