Page MenuHomeWildfire Games

[gameplay] allow rome to build palisades
ClosedPublic

Authored by Nescio on May 17 2020, 1:53 PM.

Details

Reviewers
ValihrAnt
Lionkanzen
borg-
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23839: Allow Rome to build palisades.
Summary

Currently all civilizations can build palisades, except for rome, presumably because they have siege walls. However, those are available only in the city phase, whereas palisades are buildable in the village phase.
This patch removes this exception, allowing rome to build palisades too. This means the siege walls are an additional wallset, similar to the other civ-specific structures, which don't replace default structures either.

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.May 17 2020, 1:53 PM
Owners added a subscriber: Restricted Owners Package.May 17 2020, 1:53 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2144/display/redirect

ValihrAnt accepted this revision.May 30 2020, 5:48 PM
ValihrAnt added a subscriber: ValihrAnt.

I had always assumed Rome lacks palisade walls because of having the Siege walls, which does lead to some awkward situations. First of all, players are entirely incapable of building walls in Phase 1. Later on, it can still be very hard to wall as stone walls are very expensive and stone can be hard to obtain. Additionally giving Rome palisades won't take anything away from the Siege walls as one of the two can only be built in home territory and the other in neutral or opposing territory.

This revision is now accepted and ready to land.May 30 2020, 5:48 PM
Stan added a subscriber: Stan.May 30 2020, 5:59 PM

Doesn't that make the factions more generic, and thus less interesting?

Doesn't that make the factions more generic, and thus less interesting?

I don't think giving the Romans palisades will make them less interesting as they already have 2 unique things fortification wise: the Siege Walls and the Entrenched army camp, both of which can be built-in neutral and enemy territory.

Nescio updated this revision to Diff 12242.Jun 10 2020, 11:50 AM
  • forgot three non-standard named templates

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2391/display/redirect

Lionkanzen accepted this revision.Jun 19 2020, 1:44 PM
Lionkanzen added a reviewer: Lionkanzen.

I tested a lot.

borg- accepted this revision.Jul 13 2020, 2:52 PM
In D2741#120860, @Stan wrote:

@borg- thoughts?

I like being able to build palisades with Rome.

This revision was automatically updated to reflect the committed changes.