Page MenuHomeWildfire Games

Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code
Needs ReviewPublic

Authored by wraitii on Jun 14 2020, 10:30 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This replaces our boost function wrapper code with templated code.

Supported:

  • Any number of argument, so long as they are convertible to/from JSVal (or are themselves JS::Values)
  • Any return type, same criteria, including void
  • Works with free functions and as object properties -> can use a custom "this" getter, so we can clean up things in a bunch of places (TODO: see ComponentManager)

TODO (maybe): - Optional arguments (aka some arguments are default-constructed no the C++ side)

  • Can (optionally) pass the private context data as first argument transparently.

I need to check overloaded functions, I think it might be supported with a static_cast.

Test Plan

//TODO:
Start the game, open various pages, use various functionality, run the tests.

To test in particular -> running AI games on random maps, lobby code, various GUI pages.//

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
wraitii updated this revision to Diff 12337.Jun 16 2020, 12:56 PM

Bigger hammer.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2445/display/redirect

wraitii edited the summary of this revision. (Show Details)Jun 16 2020, 1:02 PM
wraitii updated this revision to Diff 12338.Jun 16 2020, 1:04 PM

Also make the MapGenerator functions public for now.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2446/display/redirect

wraitii updated this revision to Diff 12341.EditedJun 16 2020, 7:45 PM

Update AIWorker, MapGeneratorWorker and ComponentManager to get the proper 'this' automagically, resulting in nicer code.

I haven't found out why GCC crashes so far - this works perfectly on my machine, and VS15 seems OK too.

Edit: Ayyy now GCC has another compilation error, brilliant. Will investigate later.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2449/display/redirect

wraitii retitled this revision from [WIP] Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code to Replace DEFINE_INTERFACE_XX and RegisterFunction macros with pure templated code.Jun 16 2020, 7:51 PM
wraitii edited the summary of this revision. (Show Details)
wraitii edited the test plan for this revision. (Show Details)
wraitii edited the test plan for this revision. (Show Details)
wraitii updated this revision to Diff 12345.Jun 17 2020, 10:30 AM

I think this should fix the gcc compilation error, probably still crashing though.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2451/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2452/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2453/display/redirect

wraitii updated this revision to Diff 12346.Jun 17 2020, 11:27 AM

Should fix the GCC warnings, though not the random crash.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2454/display/redirect

wraitii updated this revision to Diff 12347.Jun 17 2020, 1:55 PM

Turns out it was a debug-vs-release issue :)

This ought to work if I've applied my patch correctly.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1922/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/graphics/scripting/JSInterface_GameView.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.h
|  30| namespace·JSI_GameView
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GameView{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpParticleManager.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2013"

source/simulation2/components/ICmpPlayerManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpFogging.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpRallyPoint.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpDecay.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpSoundManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.h
|  25| namespace·JSI_Debug
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Debug{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpUnknownScript.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpUnitRenderer.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/simulation2/scripting/JSInterface_Simulation.h
|  25| namespace·JSI_Simulation
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Simulation{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_UserReport.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpTest.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/system/InterfaceScripted.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/ps/scripting/JSInterface_Main.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Main.h
|  23| namespace·JSI_Main
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Main{' is invalid C code. Use --std or --language to configure the language.

source/renderer/scripting/JSInterface_Renderer.h
|  27| namespace·JSI_Renderer
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.

source/i18n/scripting/JSInterface_L10n.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpTemplateManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpTerrain.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpAIInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDefns.h
|  21| »   ScriptInterface::AssignOrToJSVal(cx,·argv[i],·a);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'ScriptInterface::AssignOrToJSVal' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpFootprint.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Game.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Game.h
|  23| namespace·JSI_Game
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Game{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpRangeOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpWaterManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpSelectable.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/i18n/scripting/JSInterface_L10n.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/i18n/scripting/JSInterface_L10n.h
|  33| namespace·JSI_L10n
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_L10n{' is invalid C code. Use --std or --language to configure the language.

source/lobby/scripting/JSInterface_Lobby.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/lobby/scripting/JSInterface_Lobby.h
|  26| namespace·JSI_Lobby
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Lobby{' is invalid C code. Use --std or --language to configure the language.

source/scriptinterface/tests/test_FunctionWrapper.h
|  59| std::string·substrGlobalFunction(std::string·a,·int·start,·int·len)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'std::string' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTerritoryInfluence.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/ps/scripting/JSInterface_ConfigDB.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|  44| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/ps/scripting/JSInterface_UserReport.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_UserReport.h
|  25| namespace·JSI_UserReport
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_UserReport{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpObstructionManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpVisual.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpValueModificationManager.cpp
|   1| /*·Copyright·(C)·2012·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2012"

source/simulation2/components/ICmpCommandQueue.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpTerritoryDecayManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpSound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpSettlement.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/simulation2/system/ComponentManager.h
|  39| class·CComponentManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCComponentManager{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Mod.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Mod.h
|  24| namespace·JSI_Mod
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Mod{' is invalid C code. Use --std or --language to configure the language.

source/network/scripting/JSInterface_Network.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Main.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/scriptinterface/NativeWrapperDecls.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDecls.h
|  23| template<typename·R,·typename...·Ts>
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpGuiInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpUnitMotion.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/gui/Scripting/JSInterface_GUIManager.h
|  24| namespace·JSI_GUIManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GUIManager{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Console.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Console.h
|  23| namespace·JSI_Console
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Console{' is invalid C code. Use --std or --language to configure the language.

source/network/scripting/JSInterface_Network.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/network/scripting/JSInterface_Network.h
|  25| namespace·JSI_Network
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Network{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPlayer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpCinemaManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VFS.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|  26| namespace·JSI_ConfigDB
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ConfigDB{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpMinimap.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ModIo.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ModIo.h
|  23| namespace·JSI_ModIo
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ModIo{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPathfinder.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Console.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/soundmanager/scripting/JSInterface_Sound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpVision.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpTerritoryManager.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpMotion.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpMirage.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/ps/scripting/JSInterface_Game.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Mod.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_SavedGame.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|  23| namespace·JSI_SavedGame
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_SavedGame{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPosition.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|  23| namespace·JSI_VisualReplay
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VisualReplay{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_ModIo.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/tests/test_scripts.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/tests/test_scripts.h
|  24| class·TestComponentScripts·:·public·CxxTest::TestSuite
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classTestComponentScripts:' is invalid C code. Use --std or --language to configure the language.

source/graphics/MapGenerator.h
|  41| class·CMapGenerator
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMapGenerator{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_VFS.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VFS.h
|  23| namespace·JSI_VFS
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VFS{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpProjectileManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpOwnership.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/test_setup.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/CCmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2455/display/redirect

wraitii updated this revision to Diff 12348.Jun 17 2020, 2:31 PM

I believe this should work on VS15, which didn't seem to like the ternary in the non-type template default argument

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpSelectable.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Game.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Game.h
|  23| namespace·JSI_Game
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Game{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Console.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Console.h
|  23| namespace·JSI_Console
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Console{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_ModIo.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpProjectileManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/gui/Scripting/JSInterface_GUIManager.h
|  24| namespace·JSI_GUIManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GUIManager{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/tests/test_scripts.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/tests/test_scripts.h
|  24| class·TestComponentScripts·:·public·CxxTest::TestSuite
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classTestComponentScripts:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpMirage.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/simulation2/components/ICmpFootprint.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Mod.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpPathfinder.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpSound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/lobby/scripting/JSInterface_Lobby.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/lobby/scripting/JSInterface_Lobby.h
|  26| namespace·JSI_Lobby
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Lobby{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpOwnership.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpSoundManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Debug.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|  44| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/scriptinterface/NativeWrapperDecls.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDecls.h
|  23| template<typename·R,·typename...·Ts>
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/tests/test_FunctionWrapper.h
|  59| std::string·substrGlobalFunction(std::string·a,·int·start,·int·len)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'std::string' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpVisual.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|  23| namespace·JSI_SavedGame
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_SavedGame{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Main.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Main.h
|  23| namespace·JSI_Main
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Main{' is invalid C code. Use --std or --language to configure the language.

source/soundmanager/scripting/JSInterface_Sound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_SavedGame.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/CCmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpMinimap.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Debug.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.h
|  25| namespace·JSI_Debug
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Debug{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpGuiInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/graphics/MapGenerator.h
|  41| class·CMapGenerator
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMapGenerator{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpVision.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VFS.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VFS.h
|  23| namespace·JSI_VFS
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VFS{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPosition.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Mod.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Mod.h
|  24| namespace·JSI_Mod
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Mod{' is invalid C code. Use --std or --language to configure the language.

source/graphics/scripting/JSInterface_GameView.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.h
|  30| namespace·JSI_GameView
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GameView{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTest.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/scriptinterface/NativeWrapperDefns.h
|  21| »   ScriptInterface::AssignOrToJSVal(cx,·argv[i],·a);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'ScriptInterface::AssignOrToJSVal' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTerrain.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpUnitMotion.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpParticleManager.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2013"

source/ps/scripting/JSInterface_Console.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ConfigDB.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/test_setup.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/graphics/scripting/JSInterface_GameView.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Main.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/i18n/scripting/JSInterface_L10n.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpUnitRenderer.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/simulation2/components/ICmpObstructionManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ModIo.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ModIo.h
|  23| namespace·JSI_ModIo
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ModIo{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpUnknownScript.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_ConfigDB.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|  26| namespace·JSI_ConfigDB
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ConfigDB{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpMotion.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/system/ComponentManager.h
|  39| class·CComponentManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCComponentManager{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpSettlement.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/ps/scripting/JSInterface_VisualReplay.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|  23| namespace·JSI_VisualReplay
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VisualReplay{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTemplateManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpPlayerManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpValueModificationManager.cpp
|   1| /*·Copyright·(C)·2012·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2012"

source/simulation2/system/InterfaceScripted.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpWaterManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpFogging.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpRangeOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_UserReport.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpCommandQueue.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/renderer/scripting/JSInterface_Renderer.h
|  27| namespace·JSI_Renderer
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpCinemaManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/network/scripting/JSInterface_Network.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/network/scripting/JSInterface_Network.h
|  25| namespace·JSI_Network
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Network{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Game.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpRallyPoint.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpPlayer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTerritoryManager.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/scripting/JSInterface_Simulation.h
|  25| namespace·JSI_Simulation
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Simulation{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_VFS.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTerritoryInfluence.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/network/scripting/JSInterface_Network.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpDecay.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_VisualReplay.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpTerritoryDecayManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_UserReport.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_UserReport.h
|  25| namespace·JSI_UserReport
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_UserReport{' is invalid C code. Use --std or --language to configure the language.

source/i18n/scripting/JSInterface_L10n.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/i18n/scripting/JSInterface_L10n.h
|  33| namespace·JSI_L10n
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_L10n{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2456/display/redirect

wraitii updated this revision to Diff 12349.Jun 17 2020, 3:46 PM

SFINAE out the gcc warnings. I guess it's just cleaner.

wraitii added inline comments.Jun 17 2020, 3:48 PM
source/scriptinterface/ScriptInterface.cpp
404

need to revert this change

wraitii updated this revision to Diff 12350.Jun 17 2020, 4:04 PM

This is a real rollercoaster :p

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpRangeOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpSoundManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDefns.h
|  21| »   ScriptInterface::AssignOrToJSVal(cx,·argv[i],·a);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'ScriptInterface::AssignOrToJSVal' is invalid C code. Use --std or --language to configure the language.

source/graphics/MapGenerator.h
|  41| class·CMapGenerator
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMapGenerator{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpVisual.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/scriptinterface/tests/test_FunctionWrapper.h
|  59| std::string·substrGlobalFunction(std::string·a,·int·start,·int·len)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'std::string' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_UserReport.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_UserReport.h
|  25| namespace·JSI_UserReport
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_UserReport{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpValueModificationManager.cpp
|   1| /*·Copyright·(C)·2012·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2012"

source/ps/scripting/JSInterface_UserReport.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpVision.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/test_setup.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/renderer/scripting/JSInterface_Renderer.h
|  27| namespace·JSI_Renderer
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpRallyPoint.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpMotion.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_SavedGame.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/i18n/scripting/JSInterface_L10n.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpObstructionManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTerritoryInfluence.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/ps/scripting/JSInterface_ModIo.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|  26| namespace·JSI_ConfigDB
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ConfigDB{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_VFS.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Mod.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpTerritoryManager.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/graphics/scripting/JSInterface_GameView.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.h
|  30| namespace·JSI_GameView
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GameView{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpProjectileManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_Game.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpPosition.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpParticleManager.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2013"

source/simulation2/components/ICmpUnitMotion.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpSettlement.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/ps/scripting/JSInterface_VisualReplay.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTerritoryDecayManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpMirage.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/ps/scripting/JSInterface_Debug.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.h
|  25| namespace·JSI_Debug
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Debug{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpSound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Mod.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Mod.h
|  24| namespace·JSI_Mod
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Mod{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/CCmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|  23| namespace·JSI_SavedGame
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_SavedGame{' is invalid C code. Use --std or --language to configure the language.

source/network/scripting/JSInterface_Network.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ModIo.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ModIo.h
|  23| namespace·JSI_ModIo
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ModIo{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpDecay.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/soundmanager/scripting/JSInterface_Sound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpFootprint.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpWaterManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpOwnership.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpCommandQueue.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpMinimap.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpSelectable.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/system/InterfaceScripted.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Console.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/graphics/scripting/JSInterface_GameView.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/network/scripting/JSInterface_Network.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/network/scripting/JSInterface_Network.h
|  25| namespace·JSI_Network
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Network{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPathfinder.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpTest.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_Game.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Game.h
|  23| namespace·JSI_Game
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Game{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|  23| namespace·JSI_VisualReplay
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VisualReplay{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpUnknownScript.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpCinemaManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpUnitRenderer.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/simulation2/system/ComponentManager.h
|  39| class·CComponentManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCComponentManager{' is invalid C code. Use --std or --language to configure the language.

source/lobby/scripting/JSInterface_Lobby.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/lobby/scripting/JSInterface_Lobby.h
|  26| namespace·JSI_Lobby
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Lobby{' is invalid C code. Use --std or --language to configure the language.

source/scriptinterface/NativeWrapperDecls.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDecls.h
|  23| template<typename·R,·typename...·Ts>
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpGuiInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/i18n/scripting/JSInterface_L10n.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/i18n/scripting/JSInterface_L10n.h
|  33| namespace·JSI_L10n
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_L10n{' is invalid C code. Use --std or --language to configure the language.

source/gui/Scripting/JSInterface_GUIManager.h
|  24| namespace·JSI_GUIManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GUIManager{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/tests/test_scripts.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/tests/test_scripts.h
|  24| class·TestComponentScripts·:·public·CxxTest::TestSuite
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classTestComponentScripts:' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPlayerManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpFogging.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/ps/scripting/JSInterface_Console.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Console.h
|  23| namespace·JSI_Console
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Console{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Debug.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|  44| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/simulation2/scripting/JSInterface_Simulation.h
|  25| namespace·JSI_Simulation
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Simulation{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_VFS.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VFS.h
|  23| namespace·JSI_VFS
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VFS{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTemplateManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpPlayer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Main.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Main.h
|  23| namespace·JSI_Main
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Main{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTerrain.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Main.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2457/display/redirect

wraitii updated this revision to Diff 12351.Jun 17 2020, 4:28 PM

ifdef the pragma.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1926/display/redirect

wraitii updated this revision to Diff 12352.Jun 17 2020, 4:30 PM

Aaaand I had uploaded upstream stuff.

Hopefully this is the one.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpFogging.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpCinemaManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_ConfigDB.h
|  26| namespace·JSI_ConfigDB
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ConfigDB{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_ModIo.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpTerritoryManager.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpRallyPointRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VFS.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpRallyPoint.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/lobby/scripting/JSInterface_Lobby.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/lobby/scripting/JSInterface_Lobby.h
|  26| namespace·JSI_Lobby
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Lobby{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_UserReport.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/renderer/scripting/JSInterface_Renderer.h
|  27| namespace·JSI_Renderer
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Renderer{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Debug.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.h
|  25| namespace·JSI_Debug
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Debug{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpSoundManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/gui/Scripting/JSInterface_GUIManager.h
|  24| namespace·JSI_GUIManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GUIManager{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Console.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Console.h
|  23| namespace·JSI_Console
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Console{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpPosition.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpIdentity.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/MapGenerator.h
|  41| class·CMapGenerator
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCMapGenerator{' is invalid C code. Use --std or --language to configure the language.

source/graphics/scripting/JSInterface_GameView.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/graphics/scripting/JSInterface_GameView.h
|  30| namespace·JSI_GameView
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_GameView{' is invalid C code. Use --std or --language to configure the language.

source/i18n/scripting/JSInterface_L10n.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/i18n/scripting/JSInterface_L10n.h
|  33| namespace·JSI_L10n
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_L10n{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_SavedGame.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/i18n/scripting/JSInterface_L10n.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VisualReplay.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_VisualReplay.h
|  23| namespace·JSI_VisualReplay
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VisualReplay{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_ModIo.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_ModIo.h
|  23| namespace·JSI_ModIo
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_ModIo{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Game.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpVision.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpPlayer.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/network/scripting/JSInterface_Network.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpPlayerManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpTest.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/ps/scripting/JSInterface_VFS.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_VFS.h
|  23| namespace·JSI_VFS
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_VFS{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpMinimap.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpMotion.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpVisual.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_UserReport.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_UserReport.h
|  25| namespace·JSI_UserReport
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_UserReport{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/system/InterfaceScripted.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpTemplateManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDecls.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/scriptinterface/NativeWrapperDecls.h
|  23| template<typename·R,·typename...·Ts>
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'template<...' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpWaterManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpFootprint.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpPathfinder.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpDecay.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/scripting/JSInterface_Simulation.h
|  25| namespace·JSI_Simulation
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Simulation{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpGuiInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpMirage.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/scriptinterface/tests/test_FunctionWrapper.h
|  59| std::string·substrGlobalFunction(std::string·a,·int·start,·int·len)
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'std::string' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_ConfigDB.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpValueModificationManager.cpp
|   1| /*·Copyright·(C)·2012·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2012"

source/simulation2/components/ICmpParticleManager.cpp
|   1| /*·Copyright·(C)·2013·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2013"

source/ps/scripting/JSInterface_Mod.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Mod.h
|  24| namespace·JSI_Mod
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Mod{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpObstructionManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/scriptinterface/NativeWrapperDefns.h
|  21| »   ScriptInterface::AssignOrToJSVal(cx,·argv[i],·a);
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'ScriptInterface::AssignOrToJSVal' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Game.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Game.h
|  23| namespace·JSI_Game
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Game{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpTerritoryDecayManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/CCmpAIManager.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/ICmpSettlement.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/network/scripting/JSInterface_Network.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/network/scripting/JSInterface_Network.h
|  25| namespace·JSI_Network
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Network{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpRangeOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Main.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpSound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Console.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpUnknownScript.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpOverlayRenderer.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2015"

source/simulation2/components/ICmpTerrain.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/ps/scripting/JSInterface_Main.h
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/ps/scripting/JSInterface_Main.h
|  23| namespace·JSI_Main
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_Main{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/ICmpAIInterface.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/ICmpTerritoryInfluence.cpp
|   1| /*·Copyright·(C)·2011·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2011"

source/simulation2/components/ICmpUnitRenderer.cpp
|   1| /*·Copyright·(C)·2014·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2014"

source/simulation2/components/ICmpSelectable.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_Debug.cpp
|  44| »   return·*(volatile·int*)0;
|    | [MAJOR] CPPCheckBear (nullPointer):
|    | Null pointer dereference

source/soundmanager/scripting/JSInterface_Sound.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpCommandQueue.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpOwnership.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/system/ComponentManager.h
|  39| class·CComponentManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCComponentManager{' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_Mod.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2018"

source/simulation2/components/ICmpProjectileManager.cpp
|   1| /*·Copyright·(C)·2010·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2010"

source/simulation2/components/ICmpUnitMotion.cpp
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/test_setup.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2017"

source/simulation2/components/tests/test_scripts.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/simulation2/components/tests/test_scripts.h
|  24| class·TestComponentScripts·:·public·CxxTest::TestSuite
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classTestComponentScripts:' is invalid C code. Use --std or --language to configure the language.

source/ps/scripting/JSInterface_SavedGame.h
|   1| /*·Copyright·(C)·2019·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2020" year instead of "2019"

source/ps/scripting/JSInterface_SavedGame.h
|  23| namespace·JSI_SavedGame
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'namespaceJSI_SavedGame{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2460/display/redirect

wraitii planned changes to this revision.Aug 6 2020, 10:40 AM

TODO post SM52

I'd like @vladislavbelov to have a look at the pure template code. This patch seems too big not to have undiscovered issues. Also you might want to rebase it so the CI can run on it.

source/graphics/MapGenerator.cpp
166

RegisterFunctionMaybe? Can this be something else than a macro?

source/gui/Scripting/JSInterface_GUIManager.cpp
38

Debug leftover.

102–113

RegisterFunction, I'm not sure what the gain is here though?

source/i18n/scripting/JSInterface_L10n.cpp
163–172

Likewise

source/i18n/scripting/JSInterface_L10n.h
58

I wonder if those shouldn't be CStrW.

source/lobby/scripting/JSInterface_Lobby.h
69

Rebase hell?

source/ps/scripting/JSInterface_ConfigDB.cpp
177–188

likewise

source/scriptinterface/ScriptInterface.cpp
404

Still there :p

wraitii updated this revision to Diff 14339.Dec 2 2020, 10:15 AM
wraitii edited the summary of this revision. (Show Details)
wraitii edited the test plan for this revision. (Show Details)

Updated for C++17. The code is leaner and much more readable with if constexpr and a few tweaks.

I haven't replaced anything yet, this just introduces the templates and some incomplete tests.
I think I'll probably do the actual replacement, to a large extent, in a separate diff.


This still needs a little work but I'll do that later, I first want to see if VS17 and gcc like this.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2233/display/redirect

Stan added a comment.Dec 2 2020, 10:24 AM

The patch is indeed simpler now ^^ Haven't tested yet.

source/scriptinterface/FunctionWrapper.h
23

Pretty sure you are missing some std includes?

34

Inverted.

source/scriptinterface/ScriptConversions.cpp
34 ↗(On Diff #14339)

Nuke.

wraitii added inline comments.Dec 2 2020, 10:29 AM
source/scriptinterface/FunctionWrapper.h
34

It's not, because I need the template to be defined above where they are used (and the logic of the code builds up progressively), so I don't have a choice.

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: object file (../../../libraries/osx/fmt/lib/libfmt.a(format.cc.o)) was built for newer OSX version (10.13) than being linked (10.12)
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: object file (../../../libraries/osx/fmt/lib/libfmt.a(format.cc.o)) was built for newer OSX version (10.13) than being linked (10.12)
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libscriptinterface.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: object file (../../../libraries/osx/fmt/lib/libfmt.a(format.cc.o)) was built for newer OSX version (10.13) than being linked (10.12)
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/Versions/A/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/Versions/A/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: object file (../../../libraries/osx/fmt/lib/libfmt.a(format.cc.o)) was built for newer OSX version (10.13) than being linked (10.12)
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2234/display/redirect

Successful build - Chance fights ever on the side of the prudent.

builderr-debug-gcc7.txt
In file included from /zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:20,
                 from ../../../source/scriptinterface/tests/test_FunctionWrapper.cpp:17:
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_1p_v; T = void; tuple = std::tuple<int>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_1p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:36:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
  static typename args_info<callable>::return_type call(T* object, tuple& args)
                                                        ~~~^~~~~~
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_v; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:37:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_r; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_r; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:38:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_v; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:39:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_r; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_r; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:40:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle; T = void; tuple = std::tuple<JS::Handle<JS::Value> >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:51:99:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle_2; T = void; tuple = std::tuple<int, JS::Handle<JS::Value>, bool>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle_2; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:52:101:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:53:105:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private_2; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*, int, bool>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private_2; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:54:107:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
builderr-release-gcc7.txt
In file included from ../../../source/pch/atlas/precompiled.h:26:
../../../source/tools/atlas/GameInterface/Messages.h: In function 'void AtlasMessage::fGetTerrainGroupPreviews(AtlasMessage::qGetTerrainGroupPreviews*)':
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
 struct sTerrainTexturePreview
        ^~~~~~~~~~~~~~~~~~~~~~
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
 struct sTerrainTexturePreview
        ^~~~~~~~~~~~~~~~~~~~~~
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
../../../source/tools/atlas/GameInterface/Messages.h:310:8: warning: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Wmaybe-uninitialized]
In file included from ../../../source/lib/os_path.h:26,
                 from ../../../source/lib/self_test.h:28,
                 from ../../../source/simulation2/system/ComponentTest.h:21,
                 from ../../../source/pch/test/precompiled.h:22:
../../../source/lib/path.h: In member function 'virtual void TestMapGenerator::setUp()':
../../../source/lib/path.h:264:68: warning: '<anonymous>.Path::separator' may be used uninitialized in this function [-Wmaybe-uninitialized]
   debug_printf("Path %s, separator %c\n", string8().c_str(), (char)separator);
                                                                    ^~~~~~~~~
In file included from /zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:20,
                 from ../../../source/scriptinterface/tests/test_FunctionWrapper.cpp:17:
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_1p_v; T = void; tuple = std::tuple<int>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_1p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:36:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
  static typename args_info<callable>::return_type call(T* object, tuple& args)
                                                        ~~~^~~~~~
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_v; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:37:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_r; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_r; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:38:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_v; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_v; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:39:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_r; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_r; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:40:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle; T = void; tuple = std::tuple<JS::Handle<JS::Value> >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:51:99:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle_2; T = void; tuple = std::tuple<int, JS::Handle<JS::Value>, bool>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle_2; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:52:101:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:173:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:53:105:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private_2; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*, int, bool>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:175:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private_2; typename ScriptFunction::args_info<T>::return_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:54:107:   required from here
../../../source/scriptinterface/FunctionWrapper.h:121:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
In file included from ../../../source/lib/os_path.h:26,
                 from ../../../source/lib/self_test.h:28,
                 from ../../../source/simulation2/system/ComponentTest.h:21,
                 from ../../../source/pch/test/precompiled.h:22:
../../../source/lib/path.h: In member function 'virtual void TestComponentScripts::setUp()':
../../../source/lib/path.h:264:68: warning: '<anonymous>.Path::separator' may be used uninitialized in this function [-Wmaybe-uninitialized]
   debug_printf("Path %s, separator %c\n", string8().c_str(), (char)separator);
                                                                    ^~~~~~~~~
In file included from ../../../source/lib/os_path.h:26,
                 from ../../../source/lib/self_test.h:28,
                 from ../../../source/simulation2/system/ComponentTest.h:21,
                 from ../../../source/pch/test/precompiled.h:22:
../../../source/lib/path.h: In function 'OsPath DataDir()':
../../../source/lib/path.h:264:68: warning: '<anonymous>.Path::separator' may be used uninitialized in this function [-Wmaybe-uninitialized]
   debug_printf("Path %s, separator %c\n", string8().c_str(), (char)separator);
                                                                    ^~~~~~~~~

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3900/display/redirect

wraitii updated this revision to Diff 14488.Dec 8 2020, 10:12 PM
wraitii edited the summary of this revision. (Show Details)

Update, a few fixes.

This replaces a few usages of RegisterFunction with Register, to highlight the differences.
One neat thing is that CmptPrivate* is optional and can be replaced with const ScriptRequest&, mkaing things safer, and also ultimately making ScriptInterface less of a monolithic header.

I think I'll stop here for this diff, checking that the output code is acceptably performant, and then update the rest in separate diffs.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3432/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//IOKit.framework/IOKit.tbd and library file /System/Library/Frameworks//IOKit.framework/IOKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//QuartzCore.framework/QuartzCore.tbd and library file /System/Library/Frameworks//QuartzCore.framework/QuartzCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Metal.framework/Metal.tbd and library file /System/Library/Frameworks//Metal.framework/Metal are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenGL.framework/OpenGL.tbd and library file /System/Library/Frameworks//OpenGL.framework/OpenGL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Security.framework/Security.tbd and library file /System/Library/Frameworks//Security.framework/Security are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//OpenAL.framework/OpenAL.tbd and library file /System/Library/Frameworks//OpenAL.framework/OpenAL are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices.tbd and library file /System/Library/Frameworks//ApplicationServices.framework/ApplicationServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Cocoa.framework/Cocoa.tbd and library file /System/Library/Frameworks//Cocoa.framework/Cocoa are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage.tbd and library file /System/Library/Frameworks//CoreImage.framework/Versions/A/CoreImage are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit.tbd and library file /System/Library/Frameworks//AppKit.framework/Versions/C/AppKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData.tbd and library file /System/Library/Frameworks//CoreData.framework/Versions/A/CoreData are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.framework/Versions/A/CommonPanels are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versions/A/Help are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framework/Versions/A/ImageCapture are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versions/A/Ink are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framework/Versions/A/OpenScripting are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versions/A/Print are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework/Versions/A/SecurityHI are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition.tbd and library file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.tbd and library file /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics.tbd and library file /System/Library/Frameworks//CoreGraphics.framework/Versions/A/CoreGraphics are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText.tbd and library file /System/Library/Frameworks//CoreText.framework/Versions/A/CoreText are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO.tbd and library file /System/Library/Frameworks//ImageIO.framework/Versions/A/ImageIO are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd and library file /System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSyncLegacy.framework/Versions/A/ColorSyncLegacy are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices.tbd and library file /System/Library/Frameworks//CoreServices.framework/Versions/A/CoreServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis.tbd and library file /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation.tbd and library file /System/Library/PrivateFrameworks/UIFoundation.framework/Versions/A/UIFoundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Versions/C/Foundation are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork.tbd and library file /System/Library/Frameworks//CFNetwork.framework/Versions/A/CFNetwork are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/FSEvents.framework/Versions/A/FSEvents are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList.tbd and library file /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SharedFileList.framework/Versions/A/SharedFileList are out of sync. Falling back to library file for linking.
ld: warning: object file (../../../libraries/osx/fmt/lib/libfmt.a(format.cc.o)) was built for newer OSX version (10.13) than being linked (10.12)
ld: warning: text-based stub file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation.tbd and library file /System/Library/Frameworks//CoreFoundation.framework/CoreFoundation are out of sync. Falling back to library file for linking.
../../../source/test_setup.cpp:150:19: error: unknown type name 'scriptInterface'; did you mean 'ScriptInterface'?
        ScriptRequest rq(scriptInterface);
                         ^~~~~~~~~~~~~~~
                         ScriptInterface
../../../source/scriptinterface/ScriptInterface.h:98:7: note: 'ScriptInterface' declared here
class ScriptInterface
      ^
../../../source/test_setup.cpp:150:18: warning: parentheses were disambiguated as a function declaration [-Wvexing-parse]
        ScriptRequest rq(scriptInterface);
                        ^~~~~~~~~~~~~~~~~
../../../source/test_setup.cpp:150:19: note: add a pair of parentheses to declare a variable
        ScriptRequest rq(scriptInterface);
                         ^
                         (              )
../../../source/test_setup.cpp:151:2: error: no matching function for call to 'Register'
        ScriptFunction::Register<script_TS_FAIL>(rq, "TS_FAIL");
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../source/scriptinterface/FunctionWrapper.h:216:14: note: candidate function not viable: no known conversion from 'ScriptRequest (ScriptInterface)' to 'const ScriptRequest' for 1st argument
        static void Register(const ScriptRequest& rq, const char* name)
                    ^
1 warning and 2 errors generated.
make[1]: *** [obj/test_Debug/test_setup.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2343/display/redirect

Imarok added a subscriber: Imarok.Dec 8 2020, 11:29 PM
Imarok added inline comments.
source/ps/scripting/JSInterface_Mod.cpp
29

Don't we indent inside the namespace?

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc7.txt
In file included from /zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:20,
                 from ../../../source/scriptinterface/tests/test_FunctionWrapper.cpp:17:
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_1p_v; T = void; tuple = std::tuple<int>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_1p_v; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:36:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
  static typename args_info<callable>::return_type call(T* object, tuple& args)
                                                        ~~~^~~~~~
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_v; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_v; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:37:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_3p_r; T = void; tuple = std::tuple<int, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:198:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_3p_r; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:38:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_v; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_v; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:39:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_0p_r; T = void; tuple = std::tuple<>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:198:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_0p_r; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:40:97:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle; T = void; tuple = std::tuple<JS::Handle<JS::Value> >; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:51:99:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_handle_2; T = void; tuple = std::tuple<int, JS::Handle<JS::Value>, bool>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_handle_2; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:52:101:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:53:105:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestFunctionWrapper::_cmpt_private_2; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*, int, bool>; typename ScriptFunction::args_info<T>::return_type = int]':
../../../source/scriptinterface/FunctionWrapper.h:198:60:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestFunctionWrapper::_cmpt_private_2; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
/zpool0/gcc7/source/scriptinterface/tests/test_FunctionWrapper.h:54:107:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
In file included from /zpool0/gcc7/source/simulation2/components/tests/test_scripts.h:22,
                 from ../../../source/simulation2/components/tests/test_scripts.cpp:16:
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestComponentScripts::Script_LoadComponentScript; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*, Path>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestComponentScripts::Script_LoadComponentScript; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
../../../source/scriptinterface/FunctionWrapper.h:218:20:   required from 'static void ScriptFunction::Register(const ScriptRequest&, const char*) [with auto callable = TestComponentScripts::Script_LoadComponentScript; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0; short unsigned int flags = 7]'
/zpool0/gcc7/source/simulation2/components/tests/test_scripts.h:103:82:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
  static typename args_info<callable>::return_type call(T* object, tuple& args)
                                                        ~~~^~~~~~
../../../source/scriptinterface/FunctionWrapper.h: In instantiation of 'static typename ScriptFunction::args_info<T>::return_type ScriptFunction::call(T*, tuple&) [with auto callable = TestComponentScripts::Script_LoadHelperScript; T = void; tuple = std::tuple<ScriptInterface::CmptPrivate*, Path>; typename ScriptFunction::args_info<T>::return_type = void]':
../../../source/scriptinterface/FunctionWrapper.h:194:18:   required from 'static bool ScriptFunction::ToJSNative(JSContext*, unsigned int, JS::Value*) [with auto callable = TestComponentScripts::Script_LoadHelperScript; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0]'
../../../source/scriptinterface/FunctionWrapper.h:218:20:   required from 'static void ScriptFunction::Register(const ScriptRequest&, const char*) [with auto callable = TestComponentScripts::Script_LoadHelperScript; typename ScriptFunction::args_info<T>::object_type* (* thisGetter)(const ScriptRequest&, JS::CallArgs&) = 0; short unsigned int flags = 7]'
/zpool0/gcc7/source/simulation2/components/tests/test_scripts.h:104:76:   required from here
../../../source/scriptinterface/FunctionWrapper.h:139:59: warning: parameter 'object' set but not used [-Wunused-but-set-parameter]
../../../source/test_setup.cpp: In function 'void ScriptTestSetup(const ScriptInterface&)':
../../../source/test_setup.cpp:150:19: error: 'scriptInterface' was not declared in this scope
  ScriptRequest rq(scriptInterface);
                   ^~~~~~~~~~~~~~~
../../../source/test_setup.cpp:150:19: note: suggested alternative: 'scriptinterface'
  ScriptRequest rq(scriptInterface);
                   ^~~~~~~~~~~~~~~
                   scriptinterface
make[1]: *** [test.make:1360: obj/test_Debug/test_setup.o] Error 1
make: *** [Makefile:197: test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/4002/display/redirect

wraitii added inline comments.Dec 9 2020, 9:34 AM
source/ps/scripting/JSInterface_Mod.cpp
29

It's actually pretty inconsistent, and not mentioned in the coding conventions.

I feel like a good rule would be something like this:

  • For named namespaces that only contain methods, indent
  • Otherwise, don't indent.

Which would kind of make them look like classes in header files, but not add un-necessary indent in .cpp files.

In this particular case adding an indent doesn't really improve things much imo.

Stan added inline comments.Dec 9 2020, 9:37 AM
source/ps/scripting/JSInterface_Mod.cpp
29

I guess a good rule would be something we can format with clang format or astyle :)