This patch properly formats game speed trings by replacing the x (X) with a × (multiplication symbol), per the style guide and because it looks better in game.
See also D2610.
Details
Details
- Reviewers
Imarok - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23871: x → × in game speeds
Tiny and trivial to test.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2716/display/redirect
Comment Actions
Sounds reasonable.
Quick grep for completion shows:
- simulation/data/civs/cart.json: Carthaginian walls, gates, and towers have 3x health of a standard wall, but also 2x build time.
- simulation/templates/template_unit_cavalry_melee_spearman.xml, simulation/templates/template_unit_hero_cavalry_spearman.xml, simulation/templates/template_unit_hero_infantry_spearman.xml, simulation/templates/template_unit_champion_cavalry_spearman.xml, simulation/templates/template_unit_hero_infantry_pikeman.xml, simulation/templates/template_unit_champion_infantry_pikeman.xml, simulation/templates/template_unit_infantry_melee_spearman.xml, simulation/templates/template_unit_champion_infantry_spearman.xml, simulation/templates/template_unit_infantry_melee_pikeman.xml: 1.5x vs. Cavalry. or similar.
iirc there was a diff for the counters. Not sure if it included the x → × change.