Page MenuHomeWildfire Games

fix various oversights from recent commits
ClosedPublic

Authored by Nescio on Jul 17 2020, 3:04 PM.

Details

Reviewers
borg-
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23894: Fix various tooltip/text oversights.
Summary

This patch fixes some oversights missed in recent commits:

  • pers.json entry in D2532/rP23746.
  • brit.json entry in D2533/rP23781.
  • Delete two auras rendered obsolete in D2686/rP23824.
  • Tooltip and mace.json entry in D2867/rP23836.
  • maur.json entry in D2821/rP23837.
  • sele.json entry in D2858/rP23838.
  • Indentation, tooltip, and {civ}.json entries in D2839/rP23840.
  • Indentation, tooltip, and {civ}.json entries of Hellenistic Metropolis technology.
  • Purged some non-existent things in various {civ.json} files.

This patch conflicts with D2222 and D2720, but those two are already outdated and need to be redone. If this patch is committed, that means less work for those.

[EDIT] Furthermore:

D2887 and D2888 fix several other oversights.

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jul 17 2020, 3:04 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Jul 17 2020, 3:04 PM
Nescio updated this revision to Diff 12755.Jul 17 2020, 3:16 PM
Nescio edited the summary of this revision. (Show Details)
  • each simulation/ai/petra/config.js entry on a new line
Nescio added inline comments.Jul 17 2020, 3:19 PM
binaries/data/mods/public/simulation/ai/petra/config.js
65 ↗(On Diff #12755)

brit_crannog.xml is a Naval structure.

66 ↗(On Diff #12755)

cart_super_dock.xml is a Naval structure.

93 ↗(On Diff #12755)

pers_stable.xml is considered a standard structure and already buildable.

96 ↗(On Diff #12755)

ptol_lighthouse.xml is a Naval structure.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2686/display/redirect

Nescio updated this revision to Diff 12763.Jul 18 2020, 10:59 AM
Nescio edited the summary of this revision. (Show Details)
Nescio removed a reviewer: Angen.
Nescio removed subscribers: Restricted Owners Package, Restricted Owners Package.
  • Exclude simulation/ai/petra/config.js corrections (see D2887).
  • Exclude template_unit_cavalry* corrections (see D2888).
Owners added a subscriber: Restricted Owners Package.Jul 18 2020, 10:59 AM
Nescio removed a subscriber: Restricted Owners Package.Jul 18 2020, 11:00 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2694/display/redirect

borg- accepted this revision.Jul 18 2020, 4:49 PM

Seems complete.

This revision is now accepted and ready to land.Jul 18 2020, 4:49 PM
Nescio added a subscriber: wraitii.Jul 18 2020, 6:10 PM
borg- added a comment.Jul 20 2020, 5:23 AM

Add history for immortals pls.

Nescio updated this revision to Diff 12798.Jul 20 2020, 9:44 AM
Nescio edited the summary of this revision. (Show Details)
Owners added a subscriber: Restricted Owners Package.Jul 20 2020, 9:44 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2711/display/redirect

Any team member willing to review this? It's mostly missed strings, no gameplay changes.

Nescio edited the summary of this revision. (Show Details)Jul 21 2020, 10:20 PM
Nescio updated this revision to Diff 12858.Jul 22 2020, 5:56 PM
Nescio edited the summary of this revision. (Show Details)
  • cart_walls.json tooltip

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2755/display/redirect

borg- added a comment.Jul 22 2020, 6:08 PM

Can add history for all heros?

This patch is intended only for the most glaring oversights introduced recently.
Once it's committed, I can rebase and expand D2720 for everything else in the {civ}.json files.

This revision was automatically updated to reflect the committed changes.