Page MenuHomeWildfire Games

[gameplay] make unlock_shared_dropsites independent from unlock_shared_los
ClosedPublic

Authored by Nescio on Sep 6 2020, 1:05 AM.

Details

Summary

As title says.

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Sep 6 2020, 1:05 AM
Owners added a subscriber: Restricted Owners Package.Sep 6 2020, 1:05 AM
Vulcan added a comment.Sep 6 2020, 1:07 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3153/display/redirect

Vulcan added a comment.Sep 6 2020, 1:11 AM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1501/display/redirect

Nescio requested review of this revision.Sep 6 2020, 1:12 AM

Could you elaborate on why this ought to be an improvement? To me sharing dropsites follows naturally from sharing information.

Yes, the

unlock_shared_dropsites.json
unlock_shared_los.json
unlock_spies.json

technologies are conceptually related, each of them enables a mechanic, rather than changing a value, like most technologies. However, I fail to see the need to enforce a particular order. In my opinion players ought to have the flexibility to pick and choose which ones they want to use, and ignore the others.
Moreover, there is a “Disable Spies” match setting and a mod that enables shared vision from start. Ideally all three ought to be treated similarly: { shared vision , shared dropsites , espionage } × { from game start , with technology , never }, but that's beyond the scope of this patch.

Besides, when playing a “Revealed Map”, you can already see what everyone does, therefore Cartography seems a bit of a waste of time and resources; having to research just to unlock Shared Dropsite is a bit annoying.

borg- added a subscriber: borg-.Jan 6 2021, 12:22 PM

It looks good to me.

It looks good to me.

Good enough to accept?

borg- accepted this revision.Jan 10 2021, 1:03 PM

It looks good to me.

Good enough to accept?

Yes.

This revision is now accepted and ready to land.Jan 10 2021, 1:03 PM

Besides, when playing a “Revealed Map”, you can already see what everyone does, therefore Cartography seems a bit of a waste of time and resources; having to research just to unlock Shared Dropsite is a bit annoying.

Convinced on this argument.

This revision was landed with ongoing or failed builds.Jan 11 2021, 10:42 AM
This revision was automatically updated to reflect the committed changes.