[gameplay] restore civic centre garrison healing
ClosedPublic
Actions

Authored by Nescio on Jan 17 2021, 6:11 PM.

Details

Reviewers

borg-
ValihrAnt

Group Reviewers

Balancing

Commits

rP24680: [gameplay] Restore civic centre garrison healing

Summary

The removal of healing garrisons in the village phase (D3264/rP24523) made the early game harder. @Feldfeld requested it to be restored to the civic centre.

Test Plan

Trivial.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 17 2021, 6:11 PM

Owners added a subscriber: Restricted Owners Package.Jan 17 2021, 6:11 PM

Herald added a reviewer: Balancing. · View Herald TranscriptJan 17 2021, 6:11 PM

Build has FAILED

builderr-debug-macos.txt
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled header 'obj/engine_Debug/precompiled.h.gch'
fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/spidermonkey/include-unix-debug/mozilla/LinkedList.h' has been modified since the precompiled header 'obj/engine_Debug/precompiled.h.gch' was built
note: please rebuild precompiled he

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2924/display/redirect
See console output for more information: https://jenkins.wildfiregames.com/job/macos-differential/2924/display/redirectconsole

Harbormaster completed remote builds in B15169: Diff 15437.Jan 17 2021, 7:07 PM

Nescio requested review of this revision.Jan 17 2021, 7:07 PM

For me np, If feldfeld wants It so im fine.

This revision is now accepted and ready to land.Jan 17 2021, 7:23 PM

Playing without this made early aggression much less viable

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libtinygettext_dbg.a(tinygettext.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/liblobby_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libglooxwrapper_dbg.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file

See https://jenkins.wildfiregames.com/job/macos-differential/2926/display/redirect for more details.

This revision was landed with ongoing or failed builds.Jan 18 2021, 12:22 PM

Closed by commit rP24680: [gameplay] Restore civic centre garrison healing (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

wraitii added a commit: rP24680: [gameplay] Restore civic centre garrison healing.