Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Because of the way this is written, it should be very easy to generate 4x fonts if people require. However, generating larger and larger size fonts isn't ideal, would be best to integrate TrueType if we kept adding even more sizes.
I think it's better to add D328 as a dependency and consider gui.scale accoring to that patch.
I couldn't test this patch as pyrogenesis crashed with this error:
tex_codec.cpp(70): Function call failed: return value was -120101 (Unknown error (-120101, 0xFFFFFFFFFFFE2ADB)) Function call failed: return value was -120101 (Unknown error (-120101, 0xFFFFFFFFFFFE2ADB)) Location: tex_codec.cpp:70 (tex_codec_for_header)
P.S. I haven't yet reviewed the code, but I think it's better to add a space between operand and operator (e.g. it's better to write a * b instead of a*b)
I'd strongly prefer fixing the font rendering code to use Pango (and thus Harfbuzz, which would also solve display issues with a few languages) and use font files directly instead of what we are doing now.
We are already having some issues with fonts given that we ship ~100MB font files for 3 languages, so doubling that size for this seems even worse.
I agree with leper above and I don't think this is ever getting in, further discussion has died -> closing.