Details

Reviewers

elexis
fatherbushido
borg-
Hannibal_Barca
causative

Commits

rP19550: Add Iberian heroes auras. Patch by Grugnas.

Summary

Indibil : was a famed general who refused to aid Rome in their campaign against Carthage, even going so far as to gather a conspicuous number of soldiers to strike at the heart of Rome while its most skilled and influential general was away.

Soldiers train +20% faster and cost -15% less resources.

Viriato: was an iberian leader, prudent and careful in providing whatever was necessary thanks to his guerrilla tactic ability to harrass enemy accampents and cattle raiding.

+20% movement speed and +100% resources loot for iberian soldiers within his range.

Caros: for this hero an interesting feature is added in order to improve the figure of the monuments often underrated.
while Caros is in life, 3 of the 5 monuments can be upgraded into an advanced monument granting +1 armor to all soldiers in range in addition to the existent aura, increasing the range from 50 to 75 for the cost of 150 metal per monument upgraded.
In addition, Caros grants +2 armor to a building while he is garrisoned in it.

Test Plan

Test aura for playability, usefulness, balance.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

revision update.

Owners added a subscriber: Restricted Owners Package.May 1 2017, 9:01 PM

fatherbushido resigned from this revision.May 1 2017, 9:08 PM

Grugnas retitled this revision from [Proposal] Indibil iberian hero to [Proposal] Iberian heroes auras.May 1 2017, 9:17 PM

Grugnas edited the summary of this revision. (Show Details)

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/957/ for more details.

Harbormaster completed remote builds in B1391: Diff 1589.May 1 2017, 9:54 PM

I don't agree with that suggestion.

This revision now requires changes to proceed.May 2 2017, 11:47 AM

In D397#16686, @elexis wrote:

In my opinion, a global aura should be really avoided. It would be a technology and the presence of the hero on the ground (where the units should need him the most) would be entirely irrelevant.

Making this change for the gameplay is good, but it would be much better if it is remotely related to the history of that guy.

Also add your name to programming.json as Itms agreed that it's possible to add entries for that file, even if not having changed actual code yet (since we don't want to start a template editor list and add all people from the last 15 years)

I agree on avoiding global auras but i cannot see another way to implement such effect since someone could simply build 7 - 8 barracks in order to have a similar effect, and since champions aren't trained from fortresses only, an eventual "garrison" effect version of this aura would be not so relevant. ( I took champions for example since they have one of the highest training time).

In D397#16775, @fatherbushido wrote:

I don't agree with that suggestion.

I'd be glad if you would point out which aura doesn't satisfy you. Part of the auras refer to historical events.

standing at suggestions gave, Caros aura has changed.

fix: Caros soldiers affecting aura has now a range of 50 meters.

Ok for me.

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
8 ↗	(On Diff #1686)	We could have also focus on BuildingAI values to add something a bit dynamic and to empower the "resistance" but that's ok too.
10 ↗	(On Diff #1686)	Guardian is enough Something more flavouring?
11 ↗	(On Diff #1686)	check if there is another thing.
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json
10 ↗	(On Diff #1686)	Perhaps a bit too powerfull?
11 ↗	(On Diff #1686)	A name reflecting the mobilization ability?
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
3 ↗	(On Diff #1686)	smaller range?
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json
11 ↗	(On Diff #1686)	Ok, another suggestion name? It reflects well that thing with Romans
binaries/data/mods/public/simulation/templates/units/iber_hero_caros.xml
9 ↗	(On Diff #1686)	del

Caros aura increases the multiplier per soldier garrison in a building instead of +2 armor.

Harbormaster completed remote builds in B1527: Diff 1727.May 7 2017, 6:58 PM

Perhaps you'd want to take a look at these suggestions @Grugnas .

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
6 ↗	(On Diff #1727)	Valiant Defender?
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json
11 ↗	(On Diff #1727)	Battle Fervor? (Soldiers in the midst of battle often get into the state in which they don't notice their wounds.)
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json
11 ↗	(On Diff #1727)	Mobilization ? (like fatherbushido said)
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
9 ↗	(On Diff #1727)	Guerrilla Tactics / Guerrilla Warfare
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json
11 ↗	(On Diff #1727)	Disciplined Looter? (Soldiers often "pocketed" a huge share of the loot they got, leaving little else.)

Changed some aura names, in particular "Gathering" since it could confuse players by meaning something else.

fatherbushido added inline comments.May 7 2017, 8:30 PM

binaries/data/mods/public/simulation/templates/units/iber_hero_caros.xml
9 ↗	(On Diff #1686)	delete that

thanks for reporting this distraction issue :)

Harbormaster completed remote builds in B1532: Diff 1732.May 7 2017, 8:52 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1063/ for more details.

Harbormaster completed remote builds in B1527: Diff 1727.May 8 2017, 4:52 AM

elexis added inline comments.May 8 2017, 6:32 AM

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
7 ↗	(On Diff #1732)	Awesome aura, very unique but really useful and not global The icon isn't shown, is it? Should be removed then. Sure we don't want it for ships (or captured siege towers) too?
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json
11 ↗	(On Diff #1727)	Ok, but there was this other hero which had a global armor range, that should be come a local one too then. I mean it's a bit awkward that their cloths change quickly depending on the presence, but we also have heroes that affect health
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json
12 ↗	(On Diff #1732)	classic, #3600
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
3 ↗	(On Diff #1686)	120m way too much, check it with visual aura range. 60m already too much for my taste, we should probably normalize most heroes to 30m (or compare with screenshots on D395 )
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json
11 ↗	(On Diff #1727)	Does that aura work? IIRC we already tried this with the catafalque and failed. The templates have 0 entries for the Looter component unless you have brennus, so multiplying with 2 won't do anything. But looking at `Looter.js`, it seems that `ApplyValueModificationsToEntity` call might actually work, since it applies the `Looter/Resource` change to `cmpLoot.GetResources()`. If it works, nice and unique.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1065/ for more details.

Harbormaster completed remote builds in B1529: Diff 1729.May 8 2017, 8:08 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1067/ for more details.

Harbormaster completed remote builds in B1532: Diff 1732.May 8 2017, 10:37 AM

Grugnas added inline comments.May 8 2017, 12:49 PM

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
7 ↗	(On Diff #1732)	extending the aura to siege towers seems a good idea but iberians aren't exactly known for their sea skills. Gameplay speaking, a 1.75 multiplier on a mobile ship and the use of fireships would make iberians with no doubts the strongest civ on sea.
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json
11 ↗	(On Diff #1727)	Global auras should be avoided since they kinda reflect a monarchy where a lazy king gives orders from his royal palace and not a charismatic general who inspire his soldiers in the battlefield. "Garrison" auras are preferable to global since they expose heroes who should have considerable effects as detriment of their vulnerability. If you talk about Fabius Quintus Maximus, i have in mind an alternative aura since the actual looks a bit underpowered compared to others, and this can be took as pretest to remodel global auras.
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
3 ↗	(On Diff #1686)	The reason of this range is because most of Movement speed increasing heroes have a global range and that the hero himself won't benefit from his aura effect resulting that the soldiers are forced to stay at same walk speed of the hero if they wan't to benefit from the effect. As borg- suggested, a solution to this kind of auras could be decreasing its range and increasing the movement speed of those heroes directly in their templates.

fatherbushido added inline comments.May 8 2017, 2:50 PM

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
4 ↗	(On Diff #1732)	use the spaces

Caros Valiant Defender now affect also captured siege towers.
Viriatus Guerrilla Tactics aura range reduced to 60.

fixed space

wraitii added a subscriber: wraitii.May 8 2017, 5:47 PM

wraitii removed a subscriber: wraitii.

Some few last changes.
You can remove the "in range" imo as it's ambiguous as reported on transifex (moreover: we have vizualization now and I hope we could have the tooltip in few days).

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json
9 ↗	(On Diff #1769)	Yes remove the icon
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json
10 ↗	(On Diff #1769)	to -> for? remove "in range"
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json
12 ↗	(On Diff #1732)	yes "-20% training time and -15% resources cost for all soldiers."
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
9 ↗	(On Diff #1727)	remove in range
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json
11 ↗	(On Diff #1686)	remove in range

This revision now requires changes to proceed.May 8 2017, 7:27 PM

grammr fix.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1088/ for more details.

Harbormaster completed remote builds in B1565: Diff 1767.May 9 2017, 2:38 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1089/ for more details.

Harbormaster completed remote builds in B1566: Diff 1769.May 9 2017, 4:20 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1091/ for more details.

Harbormaster completed remote builds in B1568: Diff 1770.May 9 2017, 6:48 AM

last tweaks

binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json
10 ↗	(On Diff #1770)	+1 armor for soldiers. ? (as if an ally have Iberians units and all is a bit misleading too)
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json
12 ↗	(On Diff #1770)	-20% training time and -15% resources cost for all soldiers.
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json
9 ↗	(On Diff #1770)	+20% movement speed for soldiers.
binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json
12 ↗	(On Diff #1770)	+100% resources loot increase for every enemy unit killed or structure destroyed

This revision now requires changes to proceed.May 9 2017, 10:15 PM

tooltips fix

Closed by commit rP19550: Add Iberian heroes auras. Patch by Grugnas. (authored by fatherbushido). · Explain WhyMay 10 2017, 1:32 PM

This revision was automatically updated to reflect the committed changes.

elexis retitled this revision from [Proposal] Iberian heroes auras to Iberian heroes auras.May 10 2017, 2:18 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1113/ for more details.

Harbormaster completed remote builds in B1602: Diff 1805.May 10 2017, 3:09 PM

Iberian heroes auras
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1806

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_caros.xml

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_indibil.xml

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_viriato.xml

Iberian heroes aurasClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1806

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_1.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_caros_2.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_indibil.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_1.json

ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/iber_hero_viriato_2.json

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_caros.xml

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_indibil.xml

ps/trunk/binaries/data/mods/public/simulation/templates/units/iber_hero_viriato.xml

Iberian heroes auras
ClosedPublic
Actions

Revision Contents
Changeset List