Page MenuHomeWildfire Games
Differential D4590

Don't (mis)use technologies to differentiate elephants.
ClosedPublic
Actions

Authored by Freagarach on Apr 4 2022, 6:23 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP27241: Don't (mis)use technologies to differentiate elephants.
Summary

Slow and unnecessary, especially now we have mixins.

Test Plan

Check that the elephants still have the same values.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Apr 4 2022, 6:23 PM
Owners added a subscriber: Restricted Owners Package.Apr 4 2022, 6:24 PM
Freagarach edited reviewers, added: Restricted Owners Package; removed: Restricted Owners Package.Apr 4 2022, 6:24 PM
Freagarach added a child revision: D4584: [WIP] - Technologies to templates..Apr 4 2022, 6:26 PM
Vulcan added a comment.Apr 4 2022, 6:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6992/display/redirect

Vulcan added a comment.Apr 4 2022, 6:39 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5901/display/redirect

Harbormaster completed remote builds in B20065: Diff 20053.Apr 4 2022, 6:39 PM
Freagarach requested review of this revision.Apr 4 2022, 6:39 PM
Freagarach retitled this revision from Don't (mis)use aura's to differentiate elephants. to Don't (mis)use technologies to differentiate elephants..Apr 4 2022, 6:40 PM
wowgetoffyourcellphone awarded a token.Apr 5 2022, 7:53 AM
wowgetoffyourcellphone added a subscriber: wowgetoffyourcellphone.Apr 5 2022, 7:55 AM

I wonder: Should one be the baseline and then the other be lesser or greater than that? So, should elephant_african be the baseline stats from/in the template (no elephant_african mixin) and then elephant_indian be a mixin that increases those stats?

marder added a subscriber: marder.May 8 2022, 7:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2022, 8:09 AM
This revision was landed with ongoing or failed builds.
Closed by commit rP27241: Don't (mis)use technologies to differentiate elephants. (authored by Freagarach). · Explain Why
This revision was automatically updated to reflect the committed changes.
Freagarach added a commit: rP27241: Don't (mis)use technologies to differentiate elephants..

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
technologies/
22 lines
22 lines
templates/
mixins/
31 lines
31 lines
units/
cart/
2 lines
kush/
2 lines
maur/
2 lines
pers/
2 lines
ptol/
2 lines
sele/
2 lines

Diff 21092

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/unit_elephant_african.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/unit_elephant_indian.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/mixins/elephant_african.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/mixins/elephant_indian.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/cart/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/kush/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/maur/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/pers/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/ptol/champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/sele/champion_elephant.xml

Loading...
Wildfire Games · Phabricator