Currently atlas isn't aware about GUI Scale user configuration, this patch enabled that atlas be aware of that
Details
Details
- Reviewers
vladislavbelov - Commits
- rP27513: ATLAS UI be aware of GUI Scale user config
- Trac Tickets
- #6715
Change GUI Scale to 125%, save and open atlas
Now apply the patch build and test once again
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Debug:
8>e:\jenkins\workspace\vs2015-differential\libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers (compiling source file ..\..\..\source\lobby\XmppClient.cpp) [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lobby.vcxproj]
Release:
9>e:\jenkins\workspace\vs2015-differential\libraries\win32\gloox\include\gloox\clientbase.h(769): warning C4373: 'gloox::ClientBase::handlePing': virtual function overrides 'gloox::PingHandler::handlePing', previous versions of the compiler did not override when parameters only differed by const/volatile qualifiers (compiling source file ..\..\..\source\lobby\XmppClient.cpp) [E:\Jenkins\workspace\vs2015-differential\build\workspaces\vs2017\lobby.vcxproj]Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/7852/display/redirect
Comment Actions
Does the bandbox select correct elements? Does the world selection bounds match the bandbox?
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/6767/display/redirect
Comment Actions
I tested and yes it selected correct elements, but Im still reading the code because I'm still not sure why selected entities work even without my patch is more a bug for bandbox.
Comment Actions
I reviewed the code, and GUI Scale is only about GUI topic like bandbox, but this configuration didnt affect anything about to select entities, because the game itself isnt use this configuration, so in this case this bug is more about Visual bug.