Add an icon to the game window. It works for me on Windows 8.1 and for @Imarok on Windows and Linux. Also this change should be tested on all supported platforms (Windows, Linux, macOS) by someone else too.
Before:
After:
Differential D768
Add window icon vladislavbelov on Aug 5 2017, 3:18 PM. Authored by
Details
Add an icon to the game window. It works for me on Windows 8.1 and for @Imarok on Windows and Linux. Also this change should be tested on all supported platforms (Windows, Linux, macOS) by someone else too. Before: After:
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1799/ for more details.
Comment Actions Window icon (PNG, 128x128): Should be at the art/textures/icons/window.png. Thanks to @s0600204 for the remind to attach. Comment Actions Initially (before @vladislavbelov attached the icon image file separately) this patch caused crash on pyrogenesis start for me: tex_codec.cpp(70): Function call failed: return value was -120101 (Unknown error (-120101, 0xFFFFFFFFFFFE2ADB)) Function call failed: return value was -120101 (Unknown error (-120101, 0xFFFFFFFFFFFE2ADB)) Location: tex_codec.cpp:70 (tex_codec_for_header) This seems to be down to arc not acquiring the new image from phabricator properly, causing the image file to... not be an image file. Also note that if the image doesn't exist at all, I get a different error message: terminate called after throwing an instance of 'PSERROR_System_VmodeFailed' what(): System_VmodeFailed Aborted (core dumped) After manually copying the attached image into the appropriate location, the patch works fine (Arch Linux). However, the fact that 0ad crashes at start if the image file doesn't exist or isn't an image concerns me. Comment Actions Works on Ubuntu Gnome, but is quite small. Comment Actions
this is true we should add seperate function to load that file, that can fail but sdl init can continue Comment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files... http://jw:8080/job/phabricator/1856/ for more details. |