Fix bottom corners alignment in Modern dialog
ClosedPublic
Actions

Authored by Polakrity on Oct 25 2017, 3:16 PM.

Details

Reviewers

elexis
vladislavbelov

Commits

rP20348: Fix bottom corners alignment in Modern dialog

Summary

There is a slight gap with the bottom edge and the 2 corners decoratives.

Old:

New:

Test Plan

Nothing special.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Polakrity created this revision.Oct 25 2017, 3:16 PM

Build has FAILED

Link to build: http://jenkins-master:8080/job/phabricator/2163/
See console output for more information: http://jenkins-master:8080/job/phabricator/2163/console

Harbormaster failed remote builds in B3484: Diff 3974!Oct 25 2017, 3:17 PM

Wow, really had to zoom in a lot to notice the difference.

That one pixel is correct.
Patch is complete because thats the only reference to that png (remaining after the others were removed iirc).

This revision is now accepted and ready to land.Oct 25 2017, 3:29 PM

Sorry, have to post a meme.

My perfectionism feels better.

(You can commit it, you need to catch up in the stats)

(rP14098 introduced the misalignment)

In D982#38332, @elexis wrote:

(You can commit it, you need to catch up in the stats)

Ok, I will do it when I will be at home.

Imarok awarded a token.Oct 25 2017, 4:21 PM

Closed by commit rP20348: Fix bottom corners alignment in Modern dialog (authored by vladislavbelov). · Explain WhyOct 25 2017, 10:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

mod/

gui/

common/

modern/

sprites.xml

4 lines

Diff 3978

View Options

ps/trunk/binaries/data/mods/mod/gui/common/modern/sprites.xml

Fix bottom corners alignment in Modern dialogClosedPublicActions