Enable Variation panel, map writer, map reader and CUnit actorSelections
D2752 is not technically a prerequisite, but you can't test on catalina without it.
Differential D2042
Atlas variation submenu trompetin17 on Jul 5 2019, 6:32 PM. Authored by
Details Enable Variation panel, map writer, map reader and CUnit actorSelections D2752 is not technically a prerequisite, but you can't test on catalina without it. Apply patch:
Diff Detail
Event TimelineComment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... source/graphics/MapReader.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/tools/atlas/GameInterface/Messages.h | 211| » » ); | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1901/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... source/graphics/MapReader.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/tools/atlas/GameInterface/Messages.h | 211| » » ); | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1902/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... source/graphics/MapReader.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/tools/atlas/GameInterface/Messages.h | 211| » » ); | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1903/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1905/display/redirect Comment Actions It builds for me on windows but not with jenkins, he has linux
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1907/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1917/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Invalid number of character '{' when these macros are defined: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1918/display/redirect Comment Actions Thanks for having taken into account my IRC review remarks in the past days about the "|" concatenation in the attribute setting vs. individual XML nodes. I consulted the findings from rP22335 again to see if UTF8 handling is proper, seems so. When opening the Arcadia map: XeroXMB.cpp(257): Assertion failed: "id < m_Size && "Element ID out of range"" Assertion failed: "id < m_Size && "Element ID out of range"" Location: XeroXMB.cpp:257 (operator[])
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp |1055| » » » oldObjects.push_back(obj); | | [MAJOR] CPPCheckBear (uninitStructMember): | | Uninitialized struct member: obj.owner source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » { | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/81/display/redirect
Comment Actions Perhaps it would be good to display the names of the variations. For example if one selects a cavalry unit, there are a range of colors settings, but one can't deduce which color refers to which property of the model. Very nice feature!
Comment Actions Update patch with the current version. Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/VariationControl.h | 1| /*·Copyright·(C)·2009·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2009" source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/VariationControl.h | 25| class·VariationControl·:·public·wxScrolledWindow | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classVariationControl:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/AtlasUI/ScenarioEditor/Tools/Common/ObjectSettings.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2017" source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/VariationControl.cpp | 1| /*·Copyright·(C)·2011·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2020" year instead of "2011" source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Object/Object.cpp | 508| BEGIN_EVENT_TABLE(PlayerComboBox,·wxComboBox) | | [MAJOR] CPPCheckBear (unknownMacro): | | There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp |1056| » » » oldObjects.push_back(obj); | | [MAJOR] CPPCheckBear (uninitStructMember): | | Uninitialized struct member: obj.owner source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp | 211| » if·(cmpVisualActor) | | [MAJOR] CPPCheckBear (syntaxError): | | Unmatched '}'. Configuration: 'MESSAGESSETUP_NOTFIRST'. Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2703/display/redirect Comment Actions First, this is great feature to have. But it needs a bit of work.
Comment Actions Also please update years
Comment Actions Angen first at all, thx for taking time to review, I'm wondering about the point 1, because currently, we don't support getting object settings from the group, just take the first element in the selection. So I think we need to think about how to handle correctly multiple selections because you can have different scenarios, for example, the same template multiple units, but also, multiple templates with multiple units. Any suggestion to drive the correct implementation Comment Actions I meant this. Build variant will not have effect because it competes with skirmisher-shield-fast. So my requirement was to be able to set here nothing. |