Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Verify that nothing is overlooked.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 9381 Build 15577: Vulcan Build Jenkins Build 15576: Vulcan Build (Windows) Jenkins Build 15575: arc lint + arc unit
Event Timeline
- Removed setStringTags on recource icon (Ref. rP12845, where the icons were introduced but the font not removed because a space was still needed between the icon and the amount of resources. In rP14954 the sprintf was introduced, which meant the font could be removed but was probably not done because the function referenced to names while in fact it returned icons. In rP18154 the function was properly named to icons but the font still withstood the test of time (and reviewers).)
- insufficientX -> insufficient.
- coloredText -> setStringTags.
- Only use setStringTags when little performance impact is expected.
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required after '{'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/color.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/color.js | 1| 1| /** | 2| 2| * Used to highlight hotkeys in tooltip descriptions. | 3| 3| */ | 4| |-var g_HotkeyTags = {"color": "255 251 131" }; | | 4|+var g_HotkeyTags = { "color": "255 251 131" }; | 5| 5| | 6| 6| /** | 7| 7| * Concatenate integer color values to a string (for use in GUI objects) binaries/data/mods/public/gui/common/color.js | 95| » » h·=·s·=·0;·//·achromatic | | [NORMAL] ESLintBear (no-multi-assign): | | Unexpected chained assignment. binaries/data/mods/public/gui/common/color.js | 100| » » switch·(max) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/common/color.js | 146| » if·(s·==·0) | | [NORMAL] ESLintBear (brace-rules/brace-on-same-line): | | Opening curly brace appears on the same line as controlling statement. binaries/data/mods/public/gui/common/color.js | 147| » » r·=·g·=·b·=·l;·//·achromatic | | [NORMAL] ESLintBear (no-multi-assign): | | Unexpected chained assignment. binaries/data/mods/public/gui/common/color.js | 147| » » r·=·g·=·b·=·l;·//·achromatic | | [NORMAL] ESLintBear (no-multi-assign): | | Unexpected chained assignment. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 159| 159| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 160| 160| else | 161| |- if (isActive) | | 161|+ if (isActive) | 162| 162| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 163| 163| playerDescription = translate("%(playerName)s"); | 164| 164| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 160| 160| else | 161| 161| if (isActive) | 162| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 162|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 163| 163| playerDescription = translate("%(playerName)s"); | 164| 164| else | 165| 165| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| else | 161| 161| if (isActive) | 162| 162| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 163| |- playerDescription = translate("%(playerName)s"); | | 163|+ playerDescription = translate("%(playerName)s"); | 164| 164| else | 165| 165| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 166| 166| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| if (isActive) | 162| 162| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 163| 163| playerDescription = translate("%(playerName)s"); | 164| |- else | | 164|+ else | 165| 165| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 166| 166| playerDescription = translate("%(playerName)s (%(state)s)"); | 167| 167| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 162| 162| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 163| 163| playerDescription = translate("%(playerName)s"); | 164| 164| else | 165| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 165|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 166| 166| playerDescription = translate("%(playerName)s (%(state)s)"); | 167| 167| } | 168| 168| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 163| 163| playerDescription = translate("%(playerName)s"); | 164| 164| else | 165| 165| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 166| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 166|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 167| 167| } | 168| 168| } | 169| 169| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 354| 354| titles.push({ | 355| 355| "label": translate("Map Description"), | 356| 356| "value": g_GameAttributes.settings.Description ? | 357| |- translate(g_GameAttributes.settings.Description) : | | 357|+ translate(g_GameAttributes.settings.Description) : | 358| 358| translate("Sorry, no description available.") | 359| 359| }); | 360| 360| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 355| 355| "label": translate("Map Description"), | 356| 356| "value": g_GameAttributes.settings.Description ? | 357| 357| translate(g_GameAttributes.settings.Description) : | 358| |- translate("Sorry, no description available.") | | 358|+ translate("Sorry, no description available.") | 359| 359| }); | 360| 360| } | 361| 361| binaries/data/mods/public/gui/common/gamedescription.js | 394| » » let·difficulty·=·g_Settings.TriggerDifficulties.find(difficulty·=>·difficulty.Difficulty·==·g_GameAttributes.settings.TriggerDifficulty); | | [NORMAL] ESLintBear (no-shadow): | | 'difficulty' is already declared in the upper scope. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| batchString = translate("%(action)s to train %(number)s."); | 165| 165| | 166| 166| return bodyFont(setStringTags( | 167| |- sprintf(batchString, { | | 167|+ sprintf(batchString, { | 168| 168| "action": headerFont(translate("Shift-click")), | 169| 169| "number": totalBatchTrainingCount, | 170| 170| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| | 166| 166| return bodyFont(setStringTags( | 167| 167| sprintf(batchString, { | 168| |- "action": headerFont(translate("Shift-click")), | | 168|+ "action": headerFont(translate("Shift-click")), | 169| 169| "number": totalBatchTrainingCount, | 170| 170| "fullBatch": fullBatchesString, | 171| 171| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| return bodyFont(setStringTags( | 167| 167| sprintf(batchString, { | 168| 168| "action": headerFont(translate("Shift-click")), | 169| |- "number": totalBatchTrainingCount, | | 169|+ "number": totalBatchTrainingCount, | 170| 170| "fullBatch": fullBatchesString, | 171| 171| "remainderBatch": remainderBatch | 172| 172| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| sprintf(batchString, { | 168| 168| "action": headerFont(translate("Shift-click")), | 169| 169| "number": totalBatchTrainingCount, | 170| |- "fullBatch": fullBatchesString, | | 170|+ "fullBatch": fullBatchesString, | 171| 171| "remainderBatch": remainderBatch | 172| 172| }), | 173| 173| g_HotkeyTags)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "action": headerFont(translate("Shift-click")), | 169| 169| "number": totalBatchTrainingCount, | 170| 170| "fullBatch": fullBatchesString, | 171| |- "remainderBatch": remainderBatch | | 171|+ "remainderBatch": remainderBatch | 172| 172| }), | 173| 173| g_HotkeyTags)); | 174| 174| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 169| 169| "number": totalBatchTrainingCount, | 170| 170| "fullBatch": fullBatchesString, | 171| 171| "remainderBatch": remainderBatch | 172| |- }), | | 172|+ }), | 173| 173| g_HotkeyTags)); | 174| 174| } | 175| 175| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 170| 170| "fullBatch": fullBatchesString, | 171| 171| "remainderBatch": remainderBatch | 172| 172| }), | 173| |- g_HotkeyTags)); | | 173|+ g_HotkeyTags)); | 174| 174| } | 175| 175| | 176| 176| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 8. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 224| 224| "damage": template.armour[dmgType].toFixed(1), | 225| 225| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 226| 226| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 227| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 227|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 228| 228| }), g_TooltipTextFormats.armour) | 229| 229| }) | 230| 230| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 225| 225| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 226| 226| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 227| 227| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 228| |- }), g_TooltipTextFormats.armour) | | 228|+ }), g_TooltipTextFormats.armour) | 229| 229| }) | 230| 230| ).join(commaFont(translate(", "))) | 231| 231| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 389| 389| function getRepairTimeTooltip(entState) | 390| 390| { | 391| 391| return sprintf(translate("%(label)s %(details)s"), { | 392| |- "label": headerFont(translate("Number of repairers:")), | | 392|+ "label": headerFont(translate("Number of repairers:")), | 393| 393| "details": entState.repairable.numBuilders | 394| 394| }) + "\n" + (entState.repairable.numBuilders ? | 395| 395| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 390| 390| { | 391| 391| return sprintf(translate("%(label)s %(details)s"), { | 392| 392| "label": headerFont(translate("Number of repairers:")), | 393| |- "details": entState.repairable.numBuilders | | 393|+ "details": entState.repairable.numBuilders | 394| 394| }) + "\n" + (entState.repairable.numBuilders ? | 395| 395| sprintf(translatePlural( | 396| 396| "Add another worker to speed up the repairs by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 391| 391| return sprintf(translate("%(label)s %(details)s"), { | 392| 392| "label": headerFont(translate("Number of repairers:")), | 393| 393| "details": entState.repairable.numBuilders | 394| |- }) + "\n" + (entState.repairable.numBuilders ? | | 394|+ }) + "\n" + (entState.repairable.numBuilders ? | 395| 395| sprintf(translatePlural( | 396| 396| "Add another worker to speed up the repairs by %(second)s second.", | 397| 397| "Add another worker to speed up the repairs by %(second)s seconds.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 411| 411| function getBuildTimeTooltip(entState) | 412| 412| { | 413| 413| return sprintf(translate("%(label)s %(details)s"), { | 414| |- "label": headerFont(translate("Number of builders:")), | | 414|+ "label": headerFont(translate("Number of builders:")), | 415| 415| "details": entState.foundation.numBuilders | 416| 416| }) + "\n" + (entState.foundation.numBuilders ? | 417| 417| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 412| 412| { | 413| 413| return sprintf(translate("%(label)s %(details)s"), { | 414| 414| "label": headerFont(translate("Number of builders:")), | 415| |- "details": entState.foundation.numBuilders | | 415|+ "details": entState.foundation.numBuilders | 416| 416| }) + "\n" + (entState.foundation.numBuilders ? | 417| 417| sprintf(translatePlural( | 418| 418| "Add another worker to speed up the construction by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 413| 413| return sprintf(translate("%(label)s %(details)s"), { | 414| 414| "label": headerFont(translate("Number of builders:")), | 415| 415| "details": entState.foundation.numBuilders | 416| |- }) + "\n" + (entState.foundation.numBuilders ? | | 416|+ }) + "\n" + (entState.foundation.numBuilders ? | 417| 417| sprintf(translatePlural( | 418| 418| "Add another worker to speed up the construction by %(second)s second.", | 419| 419| "Add another worker to speed up the construction by %(second)s seconds.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 644| 644| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 645| 645| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 646| 646| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 647| |- }); | | 647|+ }); | 648| 648| } | 649| 649| | 650| 650| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1199|1199| |1200|1200| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1201|1201| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1202| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1202|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1203|1203| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1204|1204| }); |1205|1205| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1200|1200| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1201|1201| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1202|1202| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1203| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1203|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1204|1204| }); |1205|1205| |1206|1206| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1201|1201| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1202|1202| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1203|1203| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1204| |- }); | |1204|+ }); |1205|1205| |1206|1206| let resCodes = g_ResourceData.GetCodes(); |1207|1207| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1060| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1135| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1136| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1137| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 47| 47| * The playerlist will be assembled using these values. | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| |- "available": { "color": "0 219 0", "status": translate("Online") }, | | 50|+ "available": { "color": "0 219 0", "status": translate("Online") }, | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'away'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| |- "away": { "color": "229 76 13", "status": translate("Away") }, | | 51|+ "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| |- "away": { "color": "229 76 13", "status": translate("Away") }, | | 51|+ "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'playing'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| |- "playing": { "color": "200 0 0", "status": translate("Busy") }, | | 52|+ "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| |- "playing": { "color": "200 0 0", "status": translate("Busy") }, | | 52|+ "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'offline'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| |- "offline": { "color": "0 0 0", "status": translate("Offline") }, | | 53|+ "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "color": "0 219 0", "status": translate("Online") }, | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| |- "offline": { "color": "0 0 0", "status": translate("Offline") }, | | 53|+ "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| 54| "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'unknown'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 51| 51| "away": { "color": "229 76 13", "status": translate("Away") }, | 52| 52| "playing": { "color": "200 0 0", "status": translate("Busy") }, | 53| 53| "offline": { "color": "0 0 0", "status": translate("Offline") }, | 54| |- "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | | 54|+ "unknown": { "color": "178 178 178", "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | 57| 57| var g_RoleNames = { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| me ? | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| |- newrole == "moderator" ? | | 222|+ newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| |- me ? | | 223|+ me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| |- translate("You are now a moderator.") : | | 224|+ translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| |- translate("%(nick)s is now a moderator.") : | | 225|+ translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| |- msg.oldrole == "visitor" ? | | 226|+ msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| |- me ? | | 227|+ me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| |- translate("You have been unmuted.") : | | 228|+ translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| |- translate("%(nick)s has been unmuted.") : | | 229|+ translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| |- me ? | | 230|+ me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| |- translate("You are not a moderator anymore.") : | | 231|+ translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| |- translate("%(nick)s is not a moderator anymore."); | | 232|+ translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | 235| 235| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1035| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 764| 764| addResearchToQueue(data.item.researchFacilityId, t); | 765| 765| })(tech); | 766| 766| | 767| |- button.onPressRight = (t => function () { | | 767|+ button.onPressRight = (t => function() { | 768| 768| showTemplateDetails( | 769| 769| t, | 770| 770| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 732| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 467| 467| g_Selection.reset(); | 468| 468| g_Selection.addList(selection, false, cmd.type == "gather"); | 469| 469| }, | 470| |- "play-tracks": function (notification, player) | | 470|+ "play-tracks": function(notification, player) | 471| 471| { | 472| 472| if (notification.lock) | 473| 473| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 574| 574| let notificationText = | 575| 575| notification.instructions.reduce((instructions, item) => | 576| 576| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 577| |- ""); | | 577|+ ""); | 578| 578| | 579| 579| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTags)).join("\n"); | 580| 580| g_TutorialMessages.push(notificationText); binaries/data/mods/public/gui/session/menu.js | 476| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 508| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 508| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 508| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 551| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 617| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 617| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (object-curly-spacing): | | A space is required before '}'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/counters.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/counters.js | 18| 18| let ret = ""; | 19| 19| for (let type in values) | 20| 20| ret += (g_SummaryTypes[type].color ? | 21| |- setStringTags(values[type], { "color": g_SummaryTypes[type].color}) : | | 21|+ setStringTags(values[type], { "color": g_SummaryTypes[type].color }) : | 22| 22| values[type]) + g_SummaryTypes[type].postfix; | 23| 23| return ret; | 24| 24| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1240|1240| offset = -Math.min(slideSpeed * dt, maxOffset); |1241|1241| } |1242|1242| |1243| |- updateSettingsPanelPosition(offset); | |1243|+ updateSettingsPanelPosition(offset); |1244|1244| } |1245|1245| |1246|1246| /** binaries/data/mods/public/gui/gamesetup/gamesetup.js |2018| » while·(g_IsNetworked) | | [NORMAL] ESLintBear (no-unmodified-loop-condition): | | 'g_IsNetworked' is not modified in this loop. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/325/display/redirect
coloredText -> setStringTags.
6 references remaining, one of them the definition.
-> obsoletion?
The one who wants to specify a color, should also have the means to specify other tags at the same time.
And these values ought to be specified once per runtime and then later only referenced.
Unless they _must_ be generated dynamicaly, and unless that happens so often that it is performance relevant.
For example lobby nickname color - for that case one wouldn't want to create a new JS Object solely to please the syntax of the caller.
So perhaps the function should have a comment stating that setStringtags should be preferred and the values be created in a place easily accessible to modders and constructed as rarely as possible, and only otherwise setColor to be used.
compatibilityColor looks like one place where many such objects are created uselessly.
One per call.
Now look at all the callers to that function.
For example in the replay menu.
"months": compatibilityColor(getReplayDateTime(replay), works), "popCaps": compatibilityColor(translatePopulationCapacity(replay.attribs.settings.PopulationCap), works), "mapNames": compatibilityColor(getReplayMapName(replay), works), "mapSizes": compatibilityColor(translateMapSize(replay.attribs.settings.Size), works), "durations": compatibilityColor(getReplayDuration(replay), works), "playerNames": compatibilityColor(getReplayPlayernames(replay), works)
Those are 6 JS objects constructed for every replay, and there might be 10k replays (we had to introduce a C++ json cache file to account for that already).
So this may be a significant impact for no benefit, at least in this individual case.
Now reconsider the function, the JS constructed object could just be moved to a global and then said JS object is constructed once instead of 60.000 times.
Unless the JS JIT is smart enough to abstract the value, but I wouldn't count on it.
At last it gives modders the freedom to change the number "96 96 96" and add a font if its a global (or hopefully sooner than later a prototype #5387).
.....
So the patch looks to me like it's good but needs a bit more.
binaries/data/mods/public/gui/civinfo/civinfo.js | ||
---|---|---|
91–92 | Globals are frowned upon. Rightfully so. However I don't mind these tags to become global to avoid repeated JS object construction in general, to have modders change the value easily without replacing the function, and to keep it globally consistent. Unless there comes evidence to the contrary, the UI components become prototypes, so then the tags will become prototype members too instead of globals, and thus cleaned again. | |
binaries/data/mods/public/gui/common/gamedescription.js | ||
9 | This has the suffix Tag, but the one above doesn't have it. It would be good to move towards global consistency. | |
binaries/data/mods/public/gui/lobby/lobby.js | ||
728 | This JS object seems avoidable, and the "modders" argument doesn't apply (as its stored in the other variable. | |
1062 | avoidable JS objects |
More changes. Basically, the coloredText is obselete now.
One thing I'm not sure about: the names in the lobby, I'll look into that this afternoon.
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/58/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 156| 156| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| |- if (isActive) | | 159|+ if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| 159| if (isActive) | 160| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 160|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| else | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| |- playerDescription = translate("%(playerName)s"); | | 161|+ playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| |- else | | 162|+ else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 163|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 164|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | 167| 167| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 352| 352| titles.push({ | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| |- translate(g_GameAttributes.settings.Description) : | | 355|+ translate(g_GameAttributes.settings.Description) : | 356| 356| translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| 355| translate(g_GameAttributes.settings.Description) : | 356| |- translate("Sorry, no description available.") | | 356|+ translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | 359| 359| | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 763| 763| addResearchToQueue(data.item.researchFacilityId, t); | 764| 764| })(tech); | 765| 765| | 766| |- button.onPressRight = (t => function () { | | 766|+ button.onPressRight = (t => function() { | 767| 767| showTemplateDetails( | 768| 768| t, | 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 731| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 47| 47| * The playerlist will be assembled using these values. | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| |- "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | | 50|+ "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'away'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'playing'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'offline'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'unknown'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| |- "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | 54|+ "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | 57| 57| var g_RoleNames = { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| me ? | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| |- newrole == "moderator" ? | | 222|+ newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| |- me ? | | 223|+ me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| |- translate("You are now a moderator.") : | | 224|+ translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| |- translate("%(nick)s is now a moderator.") : | | 225|+ translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| |- msg.oldrole == "visitor" ? | | 226|+ msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| |- me ? | | 227|+ me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| |- translate("You have been unmuted.") : | | 228|+ translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| |- translate("%(nick)s has been unmuted.") : | | 229|+ translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| |- me ? | | 230|+ me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| |- translate("You are not a moderator anymore.") : | | 231|+ translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| |- translate("%(nick)s is not a moderator anymore."); | | 232|+ translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | 235| 235| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1034| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 656| 656| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 657| 657| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 658| 658| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 659| |- }); | | 659|+ }); | 660| 660| } | 661| 661| | 662| 662| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1211|1211| |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTag), | |1214|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1215|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216| |- }); | |1216|+ }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); |1219|1219| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1072| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1147| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1148| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1149| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1315|1315| offset = -Math.min(slideSpeed * dt, maxOffset); |1316|1316| } |1317|1317| |1318| |- updateSettingsPanelPosition(offset); | |1318|+ updateSettingsPanelPosition(offset); |1319|1319| } |1320|1320| |1321|1321| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 8. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 225| 225| "damage": template.armour[dmgType].toFixed(1), | 226| 226| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 227| 227| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 228| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 228|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 229| 229| }), g_TooltipTextFormats.armour) | 230| 230| }) | 231| 231| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 226| 226| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 227| 227| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 228| 228| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 229| |- }), g_TooltipTextFormats.armour) | | 229|+ }), g_TooltipTextFormats.armour) | 230| 230| }) | 231| 231| ).join(commaFont(translate(", "))) | 232| 232| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 390| 390| function getRepairTimeTooltip(entState) | 391| 391| { | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| |- "label": headerFont(translate("Number of repairers:")), | | 393|+ "label": headerFont(translate("Number of repairers:")), | 394| 394| "details": entState.repairable.numBuilders | 395| 395| }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 391| 391| { | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| 393| "label": headerFont(translate("Number of repairers:")), | 394| |- "details": entState.repairable.numBuilders | | 394|+ "details": entState.repairable.numBuilders | 395| 395| }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | 397| 397| "Add another worker to speed up the repairs by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| 393| "label": headerFont(translate("Number of repairers:")), | 394| 394| "details": entState.repairable.numBuilders | 395| |- }) + "\n" + (entState.repairable.numBuilders ? | | 395|+ }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | 397| 397| "Add another worker to speed up the repairs by %(second)s second.", | 398| 398| "Add another worker to speed up the repairs by %(second)s seconds.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 412| 412| function getBuildTimeTooltip(entState) | 413| 413| { | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| |- "label": headerFont(translate("Number of builders:")), | | 415|+ "label": headerFont(translate("Number of builders:")), | 416| 416| "details": entState.foundation.numBuilders | 417| 417| }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 413| 413| { | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| 415| "label": headerFont(translate("Number of builders:")), | 416| |- "details": entState.foundation.numBuilders | | 416|+ "details": entState.foundation.numBuilders | 417| 417| }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | 419| 419| "Add another worker to speed up the construction by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| 415| "label": headerFont(translate("Number of builders:")), | 416| 416| "details": entState.foundation.numBuilders | 417| |- }) + "\n" + (entState.foundation.numBuilders ? | | 417|+ }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | 419| 419| "Add another worker to speed up the construction by %(second)s second.", | 420| 420| "Add another worker to speed up the construction by %(second)s seconds.", binaries/data/mods/public/gui/session/menu.js | 469| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 544| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 162| 162| batchString = translate("%(action)s to train %(number)s."); | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| |- sprintf(batchString, { | | 165|+ sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| |- "action": headerFont(translate("Shift-click")), | | 166|+ "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| |- "number": totalBatchTrainingCount, | | 167|+ "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| |- "fullBatch": fullBatchesString, | | 168|+ "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTag)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| |- "remainderBatch": remainderBatch | | 169|+ "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTag)); | 172| 172| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| |- }), | | 170|+ }), | 171| 171| g_HotkeyTag)); | 172| 172| } | 173| 173| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| |- g_HotkeyTag)); | | 171|+ g_HotkeyTag)); | 172| 172| } | 173| 173| | 174| 174| /** binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 467| 467| g_Selection.reset(); | 468| 468| g_Selection.addList(selection, false, cmd.type == "gather"); | 469| 469| }, | 470| |- "play-tracks": function (notification, player) | | 470|+ "play-tracks": function(notification, player) | 471| 471| { | 472| 472| if (notification.lock) | 473| 473| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 574| 574| let notificationText = | 575| 575| notification.instructions.reduce((instructions, item) => | 576| 576| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 577| |- ""); | | 577|+ ""); | 578| 578| | 579| 579| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTags)).join("\n"); | 580| 580| g_TutorialMessages.push(notificationText); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/567/display/redirect
- Full obseletion of coloredText.
- colorPlayerName in lobby.js is not called continously so not performance critical.
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/65/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | |++++| /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | 351| 351| | 352| 352| g_ModsEnabled.sort((folder1, folder2) => | 353| 353| dependencies[folder1].indexOf(g_Mods[folder2].name) != -1 ? 1 : | 354| |- dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | | 354|+ dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | 355| 355| | 356| 356| displayModList("modsEnabledList", g_ModsEnabled); | 357| 357| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 8. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 225| 225| "damage": template.armour[dmgType].toFixed(1), | 226| 226| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 227| 227| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 228| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 228|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 229| 229| }), g_TooltipTextFormats.armour) | 230| 230| }) | 231| 231| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 226| 226| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 227| 227| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 228| 228| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 229| |- }), g_TooltipTextFormats.armour) | | 229|+ }), g_TooltipTextFormats.armour) | 230| 230| }) | 231| 231| ).join(commaFont(translate(", "))) | 232| 232| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 390| 390| function getRepairTimeTooltip(entState) | 391| 391| { | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| |- "label": headerFont(translate("Number of repairers:")), | | 393|+ "label": headerFont(translate("Number of repairers:")), | 394| 394| "details": entState.repairable.numBuilders | 395| 395| }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 391| 391| { | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| 393| "label": headerFont(translate("Number of repairers:")), | 394| |- "details": entState.repairable.numBuilders | | 394|+ "details": entState.repairable.numBuilders | 395| 395| }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | 397| 397| "Add another worker to speed up the repairs by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 392| 392| return sprintf(translate("%(label)s %(details)s"), { | 393| 393| "label": headerFont(translate("Number of repairers:")), | 394| 394| "details": entState.repairable.numBuilders | 395| |- }) + "\n" + (entState.repairable.numBuilders ? | | 395|+ }) + "\n" + (entState.repairable.numBuilders ? | 396| 396| sprintf(translatePlural( | 397| 397| "Add another worker to speed up the repairs by %(second)s second.", | 398| 398| "Add another worker to speed up the repairs by %(second)s seconds.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 412| 412| function getBuildTimeTooltip(entState) | 413| 413| { | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| |- "label": headerFont(translate("Number of builders:")), | | 415|+ "label": headerFont(translate("Number of builders:")), | 416| 416| "details": entState.foundation.numBuilders | 417| 417| }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 413| 413| { | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| 415| "label": headerFont(translate("Number of builders:")), | 416| |- "details": entState.foundation.numBuilders | | 416|+ "details": entState.foundation.numBuilders | 417| 417| }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | 419| 419| "Add another worker to speed up the construction by %(second)s second.", | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 414| 414| return sprintf(translate("%(label)s %(details)s"), { | 415| 415| "label": headerFont(translate("Number of builders:")), | 416| 416| "details": entState.foundation.numBuilders | 417| |- }) + "\n" + (entState.foundation.numBuilders ? | | 417|+ }) + "\n" + (entState.foundation.numBuilders ? | 418| 418| sprintf(translatePlural( | 419| 419| "Add another worker to speed up the construction by %(second)s second.", | 420| 420| "Add another worker to speed up the construction by %(second)s seconds.", binaries/data/mods/public/gui/session/menu.js | 469| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 544| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 156| 156| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| |- if (isActive) | | 159|+ if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| 159| if (isActive) | 160| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 160|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| else | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| |- playerDescription = translate("%(playerName)s"); | | 161|+ playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| |- else | | 162|+ else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 163|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 164|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | 167| 167| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 352| 352| titles.push({ | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| |- translate(g_GameAttributes.settings.Description) : | | 355|+ translate(g_GameAttributes.settings.Description) : | 356| 356| translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| 355| translate(g_GameAttributes.settings.Description) : | 356| |- translate("Sorry, no description available.") | | 356|+ translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | 359| 359| | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 467| 467| g_Selection.reset(); | 468| 468| g_Selection.addList(selection, false, cmd.type == "gather"); | 469| 469| }, | 470| |- "play-tracks": function (notification, player) | | 470|+ "play-tracks": function(notification, player) | 471| 471| { | 472| 472| if (notification.lock) | 473| 473| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 574| 574| let notificationText = | 575| 575| notification.instructions.reduce((instructions, item) => | 576| 576| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 577| |- ""); | | 577|+ ""); | 578| 578| | 579| 579| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTags)).join("\n"); | 580| 580| g_TutorialMessages.push(notificationText); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 162| 162| batchString = translate("%(action)s to train %(number)s."); | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| |- sprintf(batchString, { | | 165|+ sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| |- "action": headerFont(translate("Shift-click")), | | 166|+ "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| |- "number": totalBatchTrainingCount, | | 167|+ "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| |- "fullBatch": fullBatchesString, | | 168|+ "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTag)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| |- "remainderBatch": remainderBatch | | 169|+ "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTag)); | 172| 172| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| |- }), | | 170|+ }), | 171| 171| g_HotkeyTag)); | 172| 172| } | 173| 173| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| |- g_HotkeyTag)); | | 171|+ g_HotkeyTag)); | 172| 172| } | 173| 173| | 174| 174| /** binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 763| 763| addResearchToQueue(data.item.researchFacilityId, t); | 764| 764| })(tech); | 765| 765| | 766| |- button.onPressRight = (t => function () { | | 766|+ button.onPressRight = (t => function() { | 767| 767| showTemplateDetails( | 768| 768| t, | 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 731| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1315|1315| offset = -Math.min(slideSpeed * dt, maxOffset); |1316|1316| } |1317|1317| |1318| |- updateSettingsPanelPosition(offset); | |1318|+ updateSettingsPanelPosition(offset); |1319|1319| } |1320|1320| |1321|1321| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 656| 656| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 657| 657| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 658| 658| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 659| |- }); | | 659|+ }); | 660| 660| } | 661| 661| | 662| 662| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1211|1211| |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTag), | |1214|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1215|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216| |- }); | |1216|+ }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); |1219|1219| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1072| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1147| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1148| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1149| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 47| 47| * The playerlist will be assembled using these values. | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| |- "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | | 50|+ "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'away'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'playing'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'offline'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'unknown'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| |- "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | 54|+ "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | 57| 57| var g_RoleNames = { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| me ? | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| |- newrole == "moderator" ? | | 222|+ newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("You have been muted.") : | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| |- me ? | | 223|+ me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 221| 221| translate("%(nick)s has been muted.") : | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| |- translate("You are now a moderator.") : | | 224|+ translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 222| 222| newrole == "moderator" ? | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| |- translate("%(nick)s is now a moderator.") : | | 225|+ translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 223| 223| me ? | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| |- msg.oldrole == "visitor" ? | | 226|+ msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 224| 224| translate("You are now a moderator.") : | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| |- me ? | | 227|+ me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 225| 225| translate("%(nick)s is now a moderator.") : | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| |- translate("You have been unmuted.") : | | 228|+ translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 226| 226| msg.oldrole == "visitor" ? | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| |- translate("%(nick)s has been unmuted.") : | | 229|+ translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 227| 227| me ? | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| |- me ? | | 230|+ me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 228| 228| translate("You have been unmuted.") : | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| |- translate("You are not a moderator anymore.") : | | 231|+ translate("You are not a moderator anymore.") : | 232| 232| translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 229| 229| translate("%(nick)s has been unmuted.") : | 230| 230| me ? | 231| 231| translate("You are not a moderator anymore.") : | 232| |- translate("%(nick)s is not a moderator anymore."); | | 232|+ translate("%(nick)s is not a moderator anymore."); | 233| 233| | 234| 234| addChatMessage({ | 235| 235| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1034| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/574/display/redirect
binaries/data/mods/mod/gui/common/guitags.js | ||
---|---|---|
4 | (That sounds like an IRC comment, one may consider writing a more precise instruction for future authors) | |
binaries/data/mods/mod/gui/modmod/modmod.js | ||
150 | Same - but this one can become a global | |
binaries/data/mods/public/gui/civinfo/civinfo.js | ||
12 | colour -> color rP16438 Default locale is en-US for both strings and code comments. "color" seems to be the wrong name if the value is a tag that can contain font and color. Using an object to encompass all tags (like tooltips.js) actually seems nicer than the stray globals that we find in other GUI pages, so agree on that. You had asked to make that const, the philosophy was mostly that everything should be var so that modders can change it, unless there is a good reason to have it const. The civs object is const and recursively frozen in order to enforce that no function accidentally and unintentionally modifies the civ data (that may be questioned as a use case for mods actually). | |
37 | This smells like it could be updated too. I suppose theres also a better term for bigFirstLetter https://en.wikipedia.org/wiki/Initial
| |
60 | (same) | |
84–85 | (white was useless and removed (because the prior text didnt set white but intended to use the same color for all items) in r22876) | |
88 | This line shows us that setStringTags is missing some things. CGUIString.h: enum TagType { TAG_B, TAG_I, TAG_FONT, TAG_SIZE, TAG_COLOR, TAG_IMGLEFT, TAG_IMGRIGHT, TAG_ICON, TAG_INVALID }; | |
binaries/data/mods/public/gui/common/tooltips.js | ||
258–259 | (hunk was removed in rP22866) | |
binaries/data/mods/public/gui/gamesetup/gamesetup.js | ||
1436 | (same) | |
2599 | (same) | |
binaries/data/mods/public/gui/lobby/lobby.js | ||
55 | (Aligning whitespace will be removed in d2261 to please Jenkins) | |
binaries/data/mods/public/gui/pregame/mainmenu.js | ||
117 ↗ | (On Diff #9617) | ^ |
119 ↗ | (On Diff #9617) | Moved to SplashScreenHandler.js. |
binaries/data/mods/public/gui/session/messages.js | ||
985 | Same, as below; what is the benefit to using this function? Thered only be one if we want to remove the text function, but if we'd remove that, then we'd be forced to create an unused object here every call. (In rmgen there is enough recursion and nested calls to have one unneeded object become created half a million times during mapgen) | |
binaries/data/mods/public/gui/session/selection_panels_left/stance_panel.xml | ||
10 ↗ | (On Diff #9617) | For esthetics? |
binaries/data/mods/public/gui/session/session.js | ||
35 | Naming: This is not a font value anymore, whether it contains a font is optional | |
1214 | Did someone commit a translation crime here? | |
binaries/data/mods/public/gui/summary/summary.js | ||
29 | Naming: What is a fontTag and why does it contain a color but no font? Otherwise good to make this an object, since it costs no performance (only few cycles once on init) and it allows modders / future devs to extend / consistency. | |
238 | I suppose there is no gain in this replacement other than another JS object. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/156/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1328|1328| offset = -Math.min(slideSpeed * dt, maxOffset); |1329|1329| } |1330|1330| |1331| |- updateSettingsPanelPosition(offset); | |1331|+ updateSettingsPanelPosition(offset); |1332|1332| } |1333|1333| |1334|1334| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 47| 47| * The playerlist will be assembled using these values. | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| |- "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | | 50|+ "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'away'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'playing'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'offline'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'unknown'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| |- "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | 54|+ "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | 57| 57| var g_RoleNames = { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 210| 210| me ? | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| |- msg.newrole == "moderator" ? | | 213|+ msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| |- me ? | | 214|+ me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| |- translate("You are now a moderator.") : | | 215|+ translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| |- translate("%(nick)s is now a moderator.") : | | 216|+ translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| |- msg.oldrole == "visitor" ? | | 217|+ msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| |- me ? | | 218|+ me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| |- translate("You have been unmuted.") : | | 219|+ translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| |- translate("%(nick)s has been unmuted.") : | | 220|+ translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| |- me ? | | 221|+ me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| |- translate("You are not a moderator anymore.") : | | 222|+ translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| |- translate("%(nick)s is not a moderator anymore."); | | 223|+ translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | 226| 226| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1011| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 156| 156| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| |- if (isActive) | | 159|+ if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| 159| if (isActive) | 160| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 160|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| else | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| |- playerDescription = translate("%(playerName)s"); | | 161|+ playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| |- else | | 162|+ else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 163|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 164|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | 167| 167| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 352| 352| titles.push({ | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| |- translate(g_GameAttributes.settings.Description) : | | 355|+ translate(g_GameAttributes.settings.Description) : | 356| 356| translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| 355| translate(g_GameAttributes.settings.Description) : | 356| |- translate("Sorry, no description available.") | | 356|+ translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | 359| 359| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | |++++| /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | 352| 352| | 353| 353| g_ModsEnabled.sort((folder1, folder2) => | 354| 354| dependencies[folder1].indexOf(g_Mods[folder2].name) != -1 ? 1 : | 355| |- dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | | 355|+ dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | 356| 356| | 357| 357| displayModList("modsEnabledList", g_ModsEnabled); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 162| 162| batchString = translate("%(action)s to train %(number)s."); | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| |- sprintf(batchString, { | | 165|+ sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| |- "action": headerFont(translate("Shift-click")), | | 166|+ "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| |- "number": totalBatchTrainingCount, | | 167|+ "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| |- "fullBatch": fullBatchesString, | | 168|+ "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTag)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| |- "remainderBatch": remainderBatch | | 169|+ "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTag)); | 172| 172| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| |- }), | | 170|+ }), | 171| 171| g_HotkeyTextTag)); | 172| 172| } | 173| 173| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| |- g_HotkeyTextTag)); | | 171|+ g_HotkeyTextTag)); | 172| 172| } | 173| 173| | 174| 174| /** binaries/data/mods/public/gui/session/menu.js | 469| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 544| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 177| 177| "damage": template.armour[dmgType].toFixed(1), | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 180|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| 181| }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| 180| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| |- }), g_TooltipTextFormats.armour) | | 181|+ }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | 184| 184| }); | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 467| 467| g_Selection.reset(); | 468| 468| g_Selection.addList(selection, false, cmd.type == "gather"); | 469| 469| }, | 470| |- "play-tracks": function (notification, player) | | 470|+ "play-tracks": function(notification, player) | 471| 471| { | 472| 472| if (notification.lock) | 473| 473| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 574| 574| let notificationText = | 575| 575| notification.instructions.reduce((instructions, item) => | 576| 576| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 577| |- ""); | | 577|+ ""); | 578| 578| | 579| 579| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTag)).join("\n"); | 580| 580| g_TutorialMessages.push(notificationText); binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 656| 656| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 657| 657| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 658| 658| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 659| |- }); | | 659|+ }); | 660| 660| } | 661| 661| | 662| 662| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1211|1211| |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTag), | |1214|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1215|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216| |- }); | |1216|+ }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); |1219|1219| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1072| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1147| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1148| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1149| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 763| 763| addResearchToQueue(data.item.researchFacilityId, t); | 764| 764| })(tech); | 765| 765| | 766| |- button.onPressRight = (t => function () { | | 766|+ button.onPressRight = (t => function() { | 767| 767| showTemplateDetails( | 768| 768| t, | 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 731| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/666/display/redirect
binaries/data/mods/mod/gui/modmod/modmod.js | ||
---|---|---|
59 | Plural, each property is a tag. (Proof would be struct Tag in CGUIString.h) | |
binaries/data/mods/public/gui/civinfo/civinfo.js | ||
37 | I guess thats OT :P | |
binaries/data/mods/public/gui/common/gamedescription.js | ||
180–181 | Whats the added obejct adding for a benefit? | |
binaries/data/mods/public/gui/session/session.js | ||
1214 | It seems that commit copied it from colorizeHotkey: In fact there are three instances of setStringTags + "\\[" + g_HotkeyTags`, perhaps that should become a helper function. | |
binaries/data/mods/public/gui/summary/summary.js | ||
34 | tags should suffice, since all properties are properties of the text for now (it could be considered the column), whatever, as you prefer |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/178/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 162| 162| batchString = translate("%(action)s to train %(number)s."); | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| |- sprintf(batchString, { | | 165|+ sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| |- "action": headerFont(translate("Shift-click")), | | 166|+ "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| |- "number": totalBatchTrainingCount, | | 167|+ "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| |- "fullBatch": fullBatchesString, | | 168|+ "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTags)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| |- "remainderBatch": remainderBatch | | 169|+ "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTags)); | 172| 172| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| |- }), | | 170|+ }), | 171| 171| g_HotkeyTextTags)); | 172| 172| } | 173| 173| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| |- g_HotkeyTextTags)); | | 171|+ g_HotkeyTextTags)); | 172| 172| } | 173| 173| | 174| 174| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | |++++| /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | 352| 352| | 353| 353| g_ModsEnabled.sort((folder1, folder2) => | 354| 354| dependencies[folder1].indexOf(g_Mods[folder2].name) != -1 ? 1 : | 355| |- dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | | 355|+ dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | 356| 356| | 357| 357| displayModList("modsEnabledList", g_ModsEnabled); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 156| 156| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| |- if (isActive) | | 159|+ if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| 159| if (isActive) | 160| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 160|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| else | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| |- playerDescription = translate("%(playerName)s"); | | 161|+ playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| |- else | | 162|+ else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 163|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 164|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | 167| 167| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 352| 352| titles.push({ | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| |- translate(g_GameAttributes.settings.Description) : | | 355|+ translate(g_GameAttributes.settings.Description) : | 356| 356| translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 353| 353| "label": translate("Map Description"), | 354| 354| "value": g_GameAttributes.settings.Description ? | 355| 355| translate(g_GameAttributes.settings.Description) : | 356| |- translate("Sorry, no description available.") | | 356|+ translate("Sorry, no description available.") | 357| 357| }); | 358| 358| } | 359| 359| | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 763| 763| addResearchToQueue(data.item.researchFacilityId, t); | 764| 764| })(tech); | 765| 765| | 766| |- button.onPressRight = (t => function () { | | 766|+ button.onPressRight = (t => function() { | 767| 767| showTemplateDetails( | 768| 768| t, | 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 731| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 177| 177| "damage": template.armour[dmgType].toFixed(1), | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 180|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| 181| }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| 180| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| |- }), g_TooltipTextFormats.armour) | | 181|+ }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | 184| 184| }); | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 467| 467| g_Selection.reset(); | 468| 468| g_Selection.addList(selection, false, cmd.type == "gather"); | 469| 469| }, | 470| |- "play-tracks": function (notification, player) | | 470|+ "play-tracks": function(notification, player) | 471| 471| { | 472| 472| if (notification.lock) | 473| 473| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 574| 574| let notificationText = | 575| 575| notification.instructions.reduce((instructions, item) => | 576| 576| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 577| |- ""); | | 577|+ ""); | 578| 578| | 579| 579| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTags)).join("\n"); | 580| 580| g_TutorialMessages.push(notificationText); binaries/data/mods/public/gui/session/menu.js | 469| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 544| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1328|1328| offset = -Math.min(slideSpeed * dt, maxOffset); |1329|1329| } |1330|1330| |1331| |- updateSettingsPanelPosition(offset); | |1331|+ updateSettingsPanelPosition(offset); |1332|1332| } |1333|1333| |1334|1334| /** binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 47| 47| * The playerlist will be assembled using these values. | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| |- "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | | 50|+ "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'away'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 48| 48| */ | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| |- "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | | 51|+ "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'playing'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 49| 49| var g_PlayerStatuses = { | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| |- "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | | 52|+ "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'offline'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (no-multi-spaces): | | Multiple spaces found before '"status"'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 50| 50| "available": { "fontTag": { "color": "0 219 0" }, "status": translate("Online") }, | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| |- "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | | 53|+ "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| 54| "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | | [NORMAL] ESLintBear (key-spacing): | | Extra space before value for key 'unknown'. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 51| 51| "away": { "fontTag": { "color": "229 76 13" }, "status": translate("Away") }, | 52| 52| "playing": { "fontTag": { "color": "200 0 0" }, "status": translate("Busy") }, | 53| 53| "offline": { "fontTag": { "color": "0 0 0" }, "status": translate("Offline") }, | 54| |- "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | | 54|+ "unknown": { "fontTag": { "color": "178 178 178" }, "status": translateWithContext("lobby presence", "Unknown") } | 55| 55| }; | 56| 56| | 57| 57| var g_RoleNames = { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 210| 210| me ? | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| |- msg.newrole == "moderator" ? | | 213|+ msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| |- me ? | | 214|+ me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| |- translate("You are now a moderator.") : | | 215|+ translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| |- translate("%(nick)s is now a moderator.") : | | 216|+ translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| |- msg.oldrole == "visitor" ? | | 217|+ msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| |- me ? | | 218|+ me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| |- translate("You have been unmuted.") : | | 219|+ translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| |- translate("%(nick)s has been unmuted.") : | | 220|+ translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| |- me ? | | 221|+ me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| |- translate("You are not a moderator anymore.") : | | 222|+ translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| |- translate("%(nick)s is not a moderator anymore."); | | 223|+ translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | 226| 226| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1011| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 656| 656| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 657| 657| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 658| 658| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 659| |- }); | | 659|+ }); | 660| 660| } | 661| 661| | 662| 662| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1211|1211| |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTag), | |1214|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1215|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216| |- }); | |1216|+ }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); |1219|1219| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1072| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1147| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1148| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1149| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/693/display/redirect
Rest looks correct.
binaries/data/mods/public/gui/civinfo/civinfo.js | ||
---|---|---|
37 | OT=offtopic yes not only initial / drop cap, but also not computing fontsize when that is currently not supported. I guess that might be supported eventually, at least I heard two people wanting to work on that. | |
binaries/data/mods/public/gui/common/gamedescription.js | ||
181 | (Not a fan of ) on a separate line, since it is not a data structure, not a scope) | |
binaries/data/mods/public/gui/gamesetup/gamesetup.js | ||
1436 | What are the benefits and disadvantages of this hunk? | |
binaries/data/mods/public/gui/lobby/lobby.js | ||
55 | same xP (hint: naming of the object) | |
1555 | (same) | |
1560 | (I suppose the function is short enough to be removed now) | |
binaries/data/mods/public/gui/pregame/SplashscreenHandler.js | ||
45 | Yes! | |
binaries/data/mods/public/gui/pregame/userreport/userreport.js | ||
41 | Why is a tags object added to an object that stores functions returning http connection strings? | |
binaries/data/mods/public/gui/session/messages.js | ||
570 | Is it a tooltip? | |
binaries/data/mods/public/gui/summary/summary.js | ||
24 | Why is this an empty string? |
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 156| 156| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| |- if (isActive) | | 159|+ if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 157| 157| playerDescription = translate("%(playerName)s (%(civ)s, %(state)s)"); | 158| 158| else | 159| 159| if (isActive) | 160| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 160|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 158| 158| else | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| |- playerDescription = translate("%(playerName)s"); | | 161|+ playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 159| 159| if (isActive) | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| |- else | | 162|+ else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 160| 160| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| |- // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | | 163|+ // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| 164| playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 161| 161| playerDescription = translate("%(playerName)s"); | 162| 162| else | 163| 163| // Translation: Describe a player in a selected game, f.e. in the replay- or savegame menu | 164| |- playerDescription = translate("%(playerName)s (%(state)s)"); | | 164|+ playerDescription = translate("%(playerName)s (%(state)s)"); | 165| 165| } | 166| 166| } | 167| 167| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 351| 351| titles.push({ | 352| 352| "label": translate("Map Description"), | 353| 353| "value": g_GameAttributes.settings.Description ? | 354| |- translate(g_GameAttributes.settings.Description) : | | 354|+ translate(g_GameAttributes.settings.Description) : | 355| 355| translate("Sorry, no description available.") | 356| 356| }); | 357| 357| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/gamedescription.js | 352| 352| "label": translate("Map Description"), | 353| 353| "value": g_GameAttributes.settings.Description ? | 354| 354| translate(g_GameAttributes.settings.Description) : | 355| |- translate("Sorry, no description available.") | | 355|+ translate("Sorry, no description available.") | 356| 356| }); | 357| 357| } | 358| 358| | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js | 763| 763| addResearchToQueue(data.item.researchFacilityId, t); | 764| 764| })(tech); | 765| 765| | 766| |- button.onPressRight = (t => function () { | | 766|+ button.onPressRight = (t => function() { | 767| 767| showTemplateDetails( | 768| 768| t, | 769| 769| GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv); binaries/data/mods/public/gui/session/selection_panels.js | 48| » » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 59| » » switch·(data.item) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/selection_panels.js | 731| » » » » » » switch·(entity.check) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/menu.js | 469| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 501| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 544| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 610| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. | | [NORMAL] ESLintBear (space-before-function-paren): | | Unexpected space before function parentheses. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 472| 472| g_Selection.reset(); | 473| 473| g_Selection.addList(selection, false, cmd.type == "gather"); | 474| 474| }, | 475| |- "play-tracks": function (notification, player) | | 475|+ "play-tracks": function(notification, player) | 476| 476| { | 477| 477| if (notification.lock) | 478| 478| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/messages.js | 579| 579| let notificationText = | 580| 580| notification.instructions.reduce((instructions, item) => | 581| 581| instructions + (typeof item == "string" ? translate(item) : colorizeHotkey(translate(item.text), item.hotkey)), | 582| |- ""); | | 582|+ ""); | 583| 583| | 584| 584| Engine.GetGUIObjectByName("tutorialText").caption = g_TutorialMessages.concat(setStringTags(notificationText, g_TutorialNewMessageTags)).join("\n"); | 585| 585| g_TutorialMessages.push(notificationText); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 177| 177| "damage": template.armour[dmgType].toFixed(1), | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| |- "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | | 180|+ "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| 181| }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/common/tooltips.js | 178| 178| "damageType": unitFont(translateWithContext("damage type", dmgType)), | 179| 179| "armorPercentage": setStringTags(sprintf(translate("(%(armorPercentage)s)"), { | 180| 180| "armorPercentage": armorLevelToPercentageString(template.armour[dmgType]) | 181| |- }), g_TooltipTextFormats.armour) | | 181|+ }), g_TooltipTextFormats.armour) | 182| 182| }) | 183| 183| ).join(commaFont(translate(", "))) | 184| 184| }); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 210| 210| me ? | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| |- msg.newrole == "moderator" ? | | 213|+ msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 211| 211| translate("You have been muted.") : | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| |- me ? | | 214|+ me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 212| 212| translate("%(nick)s has been muted.") : | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| |- translate("You are now a moderator.") : | | 215|+ translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 213| 213| msg.newrole == "moderator" ? | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| |- translate("%(nick)s is now a moderator.") : | | 216|+ translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 214| 214| me ? | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| |- msg.oldrole == "visitor" ? | | 217|+ msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 215| 215| translate("You are now a moderator.") : | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| |- me ? | | 218|+ me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 216| 216| translate("%(nick)s is now a moderator.") : | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| |- translate("You have been unmuted.") : | | 219|+ translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 217| 217| msg.oldrole == "visitor" ? | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| |- translate("%(nick)s has been unmuted.") : | | 220|+ translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 218| 218| me ? | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| |- me ? | | 221|+ me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 219| 219| translate("You have been unmuted.") : | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| |- translate("You are not a moderator anymore.") : | | 222|+ translate("You are not a moderator anymore.") : | 223| 223| translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 6. |----| | /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/lobby/lobby.js | 220| 220| translate("%(nick)s has been unmuted.") : | 221| 221| me ? | 222| 222| translate("You are not a moderator anymore.") : | 223| |- translate("%(nick)s is not a moderator anymore."); | | 223|+ translate("%(nick)s is not a moderator anymore."); | 224| 224| | 225| 225| addChatMessage({ | 226| 226| "text": "/special " + sprintf(txt, { "nick": msg.nick }), binaries/data/mods/public/gui/lobby/lobby.js |1011| » » switch·(sortBy) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 62| 62| var g_RomanNumbers = [undefined, "I", "II", "III", "IV", "V", "VI", "VII", "VIII"]; | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| |- "label": translateWithContext("team", "None"), | | 65|+ "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 63| 63| | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| |- "id": -1 | | 66|+ "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 64| 64| var g_PlayerTeamList = prepareForDropdown([{ | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| |- }].concat( | | 67|+}].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 65| 65| "label": translateWithContext("team", "None"), | 66| 66| "id": -1 | 67| 67| }].concat( | 68| |- Array(g_MaxTeams).fill(0).map((v, i) => ({ | | 68|+ Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 66| 66| "id": -1 | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| |- "label": i + 1, | | 69|+ "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| 72| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 67| 67| }].concat( | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| |- "id": i | | 70|+ "id": i | 71| 71| })) | 72| 72| ) | 73| 73| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 68| 68| Array(g_MaxTeams).fill(0).map((v, i) => ({ | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| |- })) | | 71|+ })) | 72| 72| ) | 73| 73| ); | 74| 74| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 69| 69| "label": i + 1, | 70| 70| "id": i | 71| 71| })) | 72| |- ) | | 72|+) | 73| 73| ); | 74| 74| | 75| 75| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 78| 78| var g_RelicCountList = Object.keys(g_CivData).map((civ, i) => i + 1); | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| |- "name": translateWithContext("civilization", "Random"), | | 81|+ "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 79| 79| | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| |- "tooltip": translate("Picks one civilization at random when the game starts."), | | 82|+ "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 80| 80| var g_PlayerCivList = g_CivData && prepareForDropdown([{ | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| |- "color": g_ColorRandom, | | 83|+ "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 81| 81| "name": translateWithContext("civilization", "Random"), | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| |- "code": "random" | | 84|+ "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 82| 82| "tooltip": translate("Picks one civilization at random when the game starts."), | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| |- }].concat( | | 85|+}].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 83| 83| "color": g_ColorRandom, | 84| 84| "code": "random" | 85| 85| }].concat( | 86| |- Object.keys(g_CivData).filter( | | 86|+ Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 84| 84| "code": "random" | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| |- civ => g_CivData[civ].SelectableInGameSetup | | 87|+ civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 85| 85| }].concat( | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| |- ).map(civ => ({ | | 88|+ ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 86| 86| Object.keys(g_CivData).filter( | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| |- "name": g_CivData[civ].Name, | | 89|+ "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 87| 87| civ => g_CivData[civ].SelectableInGameSetup | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| |- "tooltip": g_CivData[civ].History, | | 90|+ "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 88| 88| ).map(civ => ({ | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| |- "color": g_ColorRegular, | | 91|+ "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 89| 89| "name": g_CivData[civ].Name, | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| |- "code": civ | | 92|+ "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 90| 90| "tooltip": g_CivData[civ].History, | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| |- })).sort(sortNameIgnoreCase) | | 93|+ })).sort(sortNameIgnoreCase) | 94| 94| ) | 95| 95| ); | 96| 96| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 0 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | 91| 91| "color": g_ColorRegular, | 92| 92| "code": civ | 93| 93| })).sort(sortNameIgnoreCase) | 94| |- ) | | 94|+) | 95| 95| ); | 96| 96| | 97| 97| /** | | [NORMAL] ESLintBear (no-trailing-spaces): | | Trailing spaces not allowed. |----| | /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js |1328|1328| offset = -Math.min(slideSpeed * dt, maxOffset); |1329|1329| } |1330|1330| |1331| |- updateSettingsPanelPosition(offset); | |1331|+ updateSettingsPanelPosition(offset); |1332|1332| } |1333|1333| |1334|1334| /** binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/loadgame/load.js | 34| » » switch·(sortKey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 162| 162| batchString = translate("%(action)s to train %(number)s."); | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| |- sprintf(batchString, { | | 165|+ sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 163| 163| | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| |- "action": headerFont(translate("Shift-click")), | | 166|+ "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 164| 164| return bodyFont(setStringTags( | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| |- "number": totalBatchTrainingCount, | | 167|+ "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 165| 165| sprintf(batchString, { | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| |- "fullBatch": fullBatchesString, | | 168|+ "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTags)); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 166| 166| "action": headerFont(translate("Shift-click")), | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| |- "remainderBatch": remainderBatch | | 169|+ "remainderBatch": remainderBatch | 170| 170| }), | 171| 171| g_HotkeyTextTags)); | 172| 172| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 167| 167| "number": totalBatchTrainingCount, | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| |- }), | | 170|+ }), | 171| 171| g_HotkeyTextTags)); | 172| 172| } | 173| 173| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels_helpers.js | 168| 168| "fullBatch": fullBatchesString, | 169| 169| "remainderBatch": remainderBatch | 170| 170| }), | 171| |- g_HotkeyTextTags)); | | 171|+ g_HotkeyTextTags)); | 172| 172| } | 173| 173| | 174| 174| /** | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | 656| 656| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 657| 657| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 658| 658| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 659| |- }); | | 659|+ }); | 660| 660| } | 661| 661| | 662| 662| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1211|1211| |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTag), | |1214|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1212|1212| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1215|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216|1216| }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/session/session.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/session.js |1213|1213| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1214|1214| "hotkey": setStringTags("\\[Click]", g_HotkeyTag), |1215|1215| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1216| |- }); | |1216|+ }); |1217|1217| |1218|1218| let resCodes = g_ResourceData.GetCodes(); |1219|1219| for (let r = 0; r < resCodes.length; ++r) binaries/data/mods/public/gui/session/session.js |1072| » let·getPanelEntNameTooltip·=·panelEntState·=>·setStringTags(template.name.specific,·g_TooltipTextFormats.nameSpecificBig); | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1147| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1148| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1149| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | |++++| /zpool0/trunk/binaries/data/mods/mod/gui/modmod/modmod.js | 352| 352| | 353| 353| g_ModsEnabled.sort((folder1, folder2) => | 354| 354| dependencies[folder1].indexOf(g_Mods[folder2].name) != -1 ? 1 : | 355| |- dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | | 355|+ dependencies[folder2].indexOf(g_Mods[folder1].name) != -1 ? -1 : 0); | 356| 356| | 357| 357| displayModList("modsEnabledList", g_ModsEnabled); | 358| 358| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 489| 489| Engine.GetGUIObjectByName("summaryText").caption = | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| |- g_GameData.gui.isReplay ? | | 492|+ g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 490| 490| g_GameData.gui.isInGame ? | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| |- translate("Scores at the end of the game.") : | | 493|+ translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 491| 491| translate("Current Scores") : | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| |- g_GameData.gui.disconnected ? | | 494|+ g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 492| 492| g_GameData.gui.isReplay ? | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| |- translate("You have been disconnected.") : | | 495|+ translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 493| 493| translate("Scores at the end of the game.") : | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| |- !assignedState ? | | 496|+ !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 494| 494| g_GameData.gui.disconnected ? | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| |- translate("You have left the game.") : | | 497|+ translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 495| 495| translate("You have been disconnected.") : | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| |- assignedState.state == "won" ? | | 498|+ assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 496| 496| !assignedState ? | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| |- translate("You have won the battle!") : | | 499|+ translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 2. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 497| 497| translate("You have left the game.") : | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| |- assignedState.state == "defeated" ? | | 500|+ assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 498| 498| assignedState.state == "won" ? | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| |- translate("You have been defeated…") : | | 501|+ translate("You have been defeated…") : | 502| 502| translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 3. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 499| 499| translate("You have won the battle!") : | 500| 500| assignedState.state == "defeated" ? | 501| 501| translate("You have been defeated…") : | 502| |- translate("You have abandoned the game."); | | 502|+ translate("You have abandoned the game."); | 503| 503| | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | |++++| /zpool0/trunk/binaries/data/mods/public/gui/summary/summary.js | 504| 504| Engine.GetGUIObjectByName("timeElapsed").caption = sprintf( | 505| 505| translate("Game time elapsed: %(time)s"), { | 506| 506| "time": timeToString(g_GameData.sim.timeElapsed) | 507| |- }); | | 507|+ }); | 508| 508| | 509| 509| let mapType = g_Settings.MapTypes.find(type => type.Name == g_GameData.sim.mapSettings.mapType); | 510| 510| let mapSize = g_Settings.MapSizes.find(size => size.Tiles == g_GameData.sim.mapSettings.Size || 0); Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/711/display/redirect
It seems "orange" is the "highlight" color of the theme? Could be refactored some day.
I suppose there is a performance disadvantage with this function that could be fixed by implementing caching.
result = '[' + tag + '="' + tags[tag] + '"]' + result + '[/' + tag + ']';
Those are quite many string concatenations, and except for the inner string, one can evaluate that once.
So instead of '[' + 'color + ']' + ... it'd only have to do '[color]' + ... each call.
The cache could be stored at the tags themselves:
var g_DescriptionHighlightTextTags = SetStringTags({ "color": "orange" });
and called like
g_DescriptionHighlightTextTags.(translate("some string"))
Then again that's adding complexity, and the prototype member lookup isn't free either.
But then one also needs a way for a tags object to change the tags after construction time, so perhaps it should be a class.
It should be optimized for performance without making the code ugly and without losing the moddability feature.
Only the places the text is rebuilt often are relevant.
For example each time any option in the gamesetup page changes, the entire GUI is rebuilt. That takes something like 15ms, and the settings change often, sometimes consecutive calls in a row.
For the session GUI its probably relevant too.
I will check on the performance impact.
binaries/data/mods/public/gui/gamesetup/gamesetup.js | ||
---|---|---|
131 | The name could clarify whether "text" means the chat, caption or tooltip. Seems to be captionTags. | |
binaries/data/mods/public/gui/summary/summary.js | ||
24 | Why is this an empty string and not an empty object? | |
104 | I wonder if the caption and the value tags should always be the same |
binaries/data/mods/mod/gui/common/guitags.js | ||
---|---|---|
3 | Can you rephrase this ? I think there is missing comma or something. |
From ages ago (no date unfortunately):
[09:58:50] <elexis> D2151 [09:58:51] <elexis> civinfo.js: L60 revert (because it only adds object construction without improving moddability/caching using the global) [09:58:51] <elexis> functions_global_object.js can be kept as a preliminary step to later moving this I guess. the object construction doesnt cost anything there since its some microseconds when opening a popup dialog, whereas defining the object in a global var would be more costy, since gui/common/ is loaded whenever a page is loaded. one object doesnt matter much I guess though. [09:58:54] <elexis> tooltips.js the parentheses is tagged too in the current code. could use the following strings: [09:58:54] <elexis> translate("%(specificName)s %(genericName)s") [09:58:56] <elexis> setStringTags(translate("(%(genericName)s)"), ...) [09:58:59] <elexis> gamesetup.js doesnt need rebase, already included im gamesetup rewrite it seems (ClientReady.js) [09:58:59] <elexis> lobby.js already included in lobby rewrite (PlayerList.js) [09:59:01] <elexis> SplashscreenHandler.js needs a rebase, you can add it as SplashScreenHandler.prototype.WarningTags if you want, but you can also just not change the line because not much will be gained in this case as long as the rest of the messagebox is hardcoded like that, plus there is another font few lines above [09:59:05] <elexis> menu.js probably can be discarded too, probably included in rewrite [09:59:07] <elexis> selection_panels.js -> whitespace style: closing parenthesis on the previous line IMO, i.e. g_TooltipTextFormats.nameGeneric) + " " +\n and +1 tab for the line thereafter so it stands out as the 2nd line contrary to the other items of this array. [09:59:11] <elexis> summary.js textTags -> captionTags [09:59:13] <elexis> otherwise good changes that can be committed