Page MenuHomeWildfire Games

Jammyjamjamman (James Sherratt)
User

Projects

User Details

User Since
Jun 29 2021, 11:42 PM (138 w, 2 d)

Recent Activity

Oct 28 2023

Jammyjamjamman added a comment to D4948: move placement options from rmgen2 to rmgen1.

@Jammyjamjamman
Thanks for the drawing. I am passing the same randomAngle() to the map script (for generating the mountain range and generating the coastline). The players should align parallel to these map features. So both the team placement and the map generations are in part a function of the randomAngle().
But it is as if the two functions are different, where there are only certain angles allow the team placement to align with the map placement. Like solutions where the two lines intersect. I have found these angles by trial and error and you can see them in my patch: https://code.wildfiregames.com/D5174

Oct 28 2023, 10:20 PM
Jammyjamjamman added a comment to D4948: move placement options from rmgen2 to rmgen1.

@andy5995 @marder
what is the difference between the startAngle given to the function and the angle that the team is placed on? I ask because I am making a map using the placement options, but the alignment of the teams with the map features varies depending on the value of randomAngle() even though the position of both is dependent on the same angle.
For example the following two map generations use different angles, but the feature placement is out of alignment with team placement.

Oct 28 2023, 6:28 PM

Nov 20 2021

Jammyjamjamman updated the diff for D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

Remove dependency of the value of Allied view on Revealed map/ vice versa

Nov 20 2021, 9:18 PM

Nov 8 2021

Jammyjamjamman updated the diff for D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

Requested style changes.

Nov 8 2021, 12:10 AM

Oct 27 2021

Jammyjamjamman added a comment to D4303: Copy TeamPlacement options from Frontier.

@Jammyjamjamman the opposing teams are so close together (3v3 medium map)! Is there anything we can do about that?

Pinging @kalimaps. Maybe he can also give an advice.

Oct 27 2021, 12:17 PM

Oct 24 2021

Jammyjamjamman added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
In D4305#183890, @Angen wrote:

There is still issue.
If map does not define attribute and you switch maps, the attribute from previous map will carry over so you will end up with 2 and possibly more settings for the same scenario map depending from which one you switch.

Oct 24 2021, 9:47 PM
Jammyjamjamman updated the diff for D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

Change setters to early return on undefined value.
Fix bug where changing to a scenario map which doesn't define properties sets them to whatever the setting on the previously selected map was. Properties are now reset to false.

Oct 24 2021, 9:46 PM

Oct 23 2021

Jammyjamjamman added a comment to rP25869: Allow to enable Cartography at the start of a match..

I found some strange behavior that could be caused by this changeset, but I'm not sure, could you take a look at it? #6365

Oct 23 2021, 8:45 PM

Oct 21 2021

Jammyjamjamman updated the diff for D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

Order of setters no longer matters - they check if the value given is "undefined" and will not change settings if it is.

Oct 21 2021, 11:27 PM

Oct 17 2021

Jammyjamjamman added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
In D4305#183526, @Angen wrote:
Oct 17 2021, 11:43 PM
Jammyjamjamman added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

I was feeling a bit overwhelmed by the changes being asked for, but I am working adding all the suggestions recommended. Just need to work out how gui layout and test harnesses in 0AD work. So it might take a bit of time. Adding the comment should be easy enough.

Oct 17 2021, 11:33 PM

Oct 13 2021

Jammyjamjamman added inline comments to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
Oct 13 2021, 10:53 PM
Jammyjamjamman added a comment to D4305: Fix bug where scenario map was not loading as revealed when set to revealed..

Could be done. But there would end up being 5 options:

Oct 13 2021, 8:04 PM
andy5995 awarded D4305: Fix bug where scenario map was not loading as revealed when set to revealed. a Like token.
Oct 13 2021, 12:58 AM
Jammyjamjamman requested review of D4305: Fix bug where scenario map was not loading as revealed when set to revealed..
Oct 13 2021, 12:17 AM

Oct 12 2021

Jammyjamjamman added a comment to rP25869: Allow to enable Cartography at the start of a match..

An issue has been discovered that can be observed for the first time with this changeset. See #6356

Oct 12 2021, 12:17 AM

Aug 7 2021

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.

Finally got around to adding "ally view" option to atlas.

Aug 7 2021, 7:28 PM
Jammyjamjamman updated the diff for D4191: Enable Cartography at Start of Game Option.
  • Add option to enable cartography at start of game
  • Apply changes suggested by Angen and Freagarach
  • More small changes suggested by Angen
  • Add "Allied map" option to map editor
Aug 7 2021, 7:16 PM

Jul 19 2021

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.
In D4191#178292, @Angen wrote:

At first you would need to get separate code for library and build it,
Adding option itself is C++, but mostly it would be copy pasting of existing code, if C++ would be concidered issue.
https://trac.wildfiregames.com/wiki/BuildInstructions?version=416#BuildingAtlas

Jul 19 2021, 10:20 PM

Jul 18 2021

Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.
In D4191#178269, @Angen wrote:

Some minor comments.
Patch is overall working as expected.

I have one additional question.
Would you be interested in adding this option to the atlas?
For that you would need to build the game from source, I do not know if you are willing to do that.

Jul 18 2021, 7:32 PM
Jammyjamjamman updated the diff for D4191: Enable Cartography at Start of Game Option.
  • More small changes suggested by Angen
Jul 18 2021, 7:14 PM
Jammyjamjamman added a comment to D4191: Enable Cartography at Start of Game Option.

Thanks @Angen and @Freagarach for your feedback. I've (finally) applied your suggested changes.

Jul 18 2021, 1:56 AM
Jammyjamjamman updated the diff for D4191: Enable Cartography at Start of Game Option.
  • Add option to enable cartography at start of game
  • Apply changes suggested by Angen and Freagarach (see points below).
  • Remove changes to translation files (not needed).
  • Add comments to translations.
  • Fix wrong function in MapExploration.js.
  • Tidy + simplify code in InitGame.js.
Jul 18 2021, 1:53 AM

Jul 15 2021

Jammyjamjamman added inline comments to D4191: Enable Cartography at Start of Game Option.
Jul 15 2021, 1:59 AM

Jul 14 2021

Jammyjamjamman added inline comments to D4191: Enable Cartography at Start of Game Option.
Jul 14 2021, 10:07 PM

Jul 4 2021

Jammyjamjamman requested review of D4191: Enable Cartography at Start of Game Option.
Jul 4 2021, 7:13 PM