HomeWildfire Games

Add Gaul theatron (Unused for now)

Description

Add Gaul theatron (Unused for now)

Reviewed by: @LordGood @Sundiata @Genava55
Authored by: @Stan

Forum thread: https://wildfiregames.com/forum/index.php?/topic/25299-committed-gaul-theatron/

Details

Committed
StanMar 10 2019, 1:03 AM
Reviewer
LordGood
Parents
rP22104: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 6955
Build 11379: Post-Commit Build (Data only)Jenkins

Event Timeline

Nescio added a subscriber: Nescio.Mar 10 2019, 9:59 AM
Nescio added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul_theatron.xml
5

Surely this should be gaul. Also, SpecificName?

Stan added inline comments.Mar 10 2019, 12:13 PM
/ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul_theatron.xml
5

Thanks. I don't know about the specific name I'll ask Genava55

Another thing: ideally, all theatron files ought to be renamed to theatre; we also have library, not bibliothekon or something.

Imarok added a subscriber: Imarok.Mar 10 2019, 7:49 PM

Shouldn't you also add the building to the map "Sandbox - The Gauls"?

Stan added a comment.Mar 10 2019, 9:57 PM

Well only if it is being used in the main game building roster. Else it would confuse players.

In rP22105#32478, @Stan wrote:

Well only if it is being used in the main game building roster. Else it would confuse players.

Looking at the roman sandbox map, it also contains many buildings not used in the main game.

Stan added a comment.Mar 10 2019, 10:53 PM

That's fair. I'll add it then.

In rP22105#32480, @Stan wrote:

That's fair. I'll add it then.

Thanks. That also encourages people to use it in mods or Atlas...