Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to…
Needs VerificationrP22351
Actions

Description

Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to "MovementUpdate"

UnitAI is now solely in charge of moving and stopping, making UnitMotion behaviour easier to predict, which will ultimately help with unitAI development. It might temporarily make units more resilient than before however.

UnitMotion also tells UnitAI that it's arrived with "MoveCompleted" messages, but these actually could be wrong - unitAI could decide that we didn't want to stop after all - so change the name for something less misleading.

Differential Revision: https://code.wildfiregames.com/D1886

Details

Auditors

vladislavbelov

Committed

wraitii

Jun 9 2019, 1:16 PM

Differential Revision

D1886: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to "MovementUpdate"

Parents

rP22350: Remove "MoveStarted" messages

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7854
Build 12776: Trigger Windows Autobuild
Build 12775: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22351: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to….Jun 9 2019, 1:16 PM

Harbormaster completed building B7854: rP22351: Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to….Jun 9 2019, 1:51 PM

wraitii mentioned this in D1963: Fix repairing/garrisoning range checks following rP22351.Jun 9 2019, 5:15 PM

wraitii mentioned this in rP22353: Fix repairing/garrisoning range checks following rP22351.Jun 9 2019, 6:59 PM

wraitii mentioned this in rP22355: Unit Motion - Face point when calling StopMoving().Jun 9 2019, 7:06 PM

vladislavbelov raised a concern with this commit.Jun 23 2019, 2:48 AM

vladislavbelov added a subscriber: vladislavbelov.

vladislavbelov added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
1457	I suppose it should be `MovementUpdate`. You have to write a test for it. Because it's easy to add/miss an unreachable state.

This commit now has outstanding concerns.Jun 23 2019, 2:48 AM

wraitii added inline comments.Jun 24 2019, 12:24 PM

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
1457	Removed in D1901 which I think is why I've missed this as I've rebased patches in varying orders. I don't think we need an emergency fix for this but you tell me.