HomeWildfire Games

Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to…
Needs VerificationrP22351


Prevent UnitMotion from stopping on its own, and rename "MoveCompleted" to "MovementUpdate"

UnitAI is now solely in charge of moving and stopping, making UnitMotion behaviour easier to predict, which will ultimately help with unitAI development. It might temporarily make units more resilient than before however.

UnitMotion also tells UnitAI that it's arrived with "MoveCompleted" messages, but these actually could be wrong - unitAI could decide that we didn't want to stop after all - so change the name for something less misleading.

Differential Revision: https://code.wildfiregames.com/D1886

Event Timeline

vladislavbelov raised a concern with this commit.Jun 23 2019, 2:48 AM
vladislavbelov added a subscriber: vladislavbelov.
vladislavbelov added inline comments.

I suppose it should be MovementUpdate.

You have to write a test for it. Because it's easy to add/miss an unreachable state.

This commit now has outstanding concerns.Jun 23 2019, 2:48 AM
wraitii added inline comments.Jun 24 2019, 12:24 PM

Removed in D1901 which I think is why I've missed this as I've rebased patches in varying orders.

I don't think we need an emergency fix for this but you tell me.

wraitii requested verification of this commit.Jul 19 2019, 2:45 PM
This commit now requires verification by auditors.Jul 19 2019, 2:45 PM