Enforce formation required member count
rP23450
Actions

Description

Enforce formation required member count

Disband formation with less memebers than required.
Do not allow one member in formation.
Show only formations entities actually are allowed to form. (do not show wedge for infantry)

Differential Revision: https://code.wildfiregames.com/D1462
Fixes: #5119
Comments by: elexis, bb, temple, Stan, Freagarach

Details

Provenance

Silier

Authored on

Differential Revision

D1462: Enforce formation required member count

Parents

rP23449: Fix entities not retaining repair order after target transforms

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10976
Build 19358: Post-Commit Build	Jenkins
Build 19357: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP23450: Enforce formation required member count.Jan 27 2020, 6:49 PM

Silier added an edge: D1462: Enforce formation required member count.

Harbormaster completed building B10976: rP23450: Enforce formation required member count.Jan 27 2020, 6:53 PM

Nescio added a subscriber: Nescio.Jan 28 2020, 11:07 AM

Nescio added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/data/civs/athen.json
148	Why?
/ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml
6	Why?
/ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml
25	Why?

Silier added inline comments.Jan 28 2020, 11:24 AM

/ps/trunk/binaries/data/mods/public/simulation/data/civs/athen.json
148	Because skirmish wedge Phalanx are Special formations and Battle Line ist Not. (Sorry für Capitals, typing on Phone)
/ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml
6	Because only pike infantry is allowed to form that. It is not 16 pike + x anyone. It is 16 pike + x pike.
/ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml
25	Because 1 member in Formation does Not create Formation by any means.

Nescio added inline comments.Jan 28 2020, 11:47 AM

/ps/trunk/binaries/data/mods/public/simulation/data/civs/athen.json
148	Then why not change that in the brit, gaul, iber, and maur civ files as well?
/ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml
6	D2007/rP22948 standardized these tooltips. Also, see https://trac.wildfiregames.com/wiki/EnglishStyleGuide Your commit broke consistency, so perhaps you could rephrase it? E.g.: Requires at least 16 Infantry Pikemen, no other units. Requires at least 16, Infantry Pikemen only. Infantry Pikemen only, requires at least 16. Also applies to the other changed formation tooltips.
/ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml
25	Yes, but all formations have their own tooltips, so this one isn't actually used, is it?

Silier added inline comments.Jan 28 2020, 12:14 PM

/ps/trunk/binaries/data/mods/public/simulation/data/civs/athen.json
148	You are correct, i missed that ones
/ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml
6	So `Infantry Pikemen only, requires at least 16.`
/ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml
25	battle line, line closed/open, column closed/open