HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24394

Move PopulationBonus from cmpCost to new cmpPopulation.
rP24394
Actions

Description

Move PopulationBonus from cmpCost to new cmpPopulation.

Since PopBonus is not a cost.

Patch by: @lonehawk
Differential Revision: D2948
Comments by: @Angen, @Nescio, @wraitii
Closes #4081

Details

Committed
FreagarachDec 14 2020, 7:17 PM
Differential Revision
D2948: Move PopulationBonus to new component Population
Parents
rP24393: Give Fortress a territory root.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 14363
Build 30338: Post-Commit BuildJenkins
Build 30337: Post-Commit Build (macOS)Jenkins

Event Timeline

Freagarach committed rP24394: Move PopulationBonus from cmpCost to new cmpPopulation..Dec 14 2020, 7:17 PM
Freagarach added an edge: D2948: Move PopulationBonus to new component Population.
Freagarach added subscribers: lonehawk, Nescio, Silier, wraitii.
Harbormaster failed to build B14363: rP24394: Move PopulationBonus from cmpCost to new cmpPopulation.!Dec 14 2020, 8:05 PM
Silier added a comment.EditedDec 14 2020, 9:52 PM

@Freagarach you should write 'Fixes' instead 'Closes' :)
(btw, close please ticket)

Freagarach added a comment.Dec 15 2020, 7:12 AM

Hmm, I think I used Closes before, but may be mistaken. Also, shouldn't it at least refs the ticket then?

Freagarach mentioned this in D3353: Move population cost outside of cost component..Jan 13 2021, 10:08 PM
Freagarach mentioned this in D3360: Fix PetraAI not building many houses..Jan 14 2021, 10:26 AM
Freagarach added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entity.js
197

While Cost may be a must for PetraAI, Population doesn't need to be. D3360

Freagarach mentioned this in rP24613: Fix PetraAI not building many houses..Jan 15 2021, 6:59 AM

Changes (62)

PathSize
ps/
trunk/
binaries/
data/
mods/
_test.sim/
simulation/
templates/
special/
filter/
public/
globalscripts/
gui/
common/
credits/
texts/
session/
l10n/
maps/
random/
simulation/
ai/
common-api/
petra/
components/
interfaces/
tests/
data/
technologies/
templates/
special/
filter/
structures/
brit/
cart/
gaul/
iber/
kush/
maur/
pers/
rome/

rP24394

View Options

ps/trunk/binaries/data/mods/_test.sim/simulation/templates/special/filter/foundation.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/globalscripts/Templates.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/credits/texts/programming.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/l10n/public-gui-other.pot

Loading...
View Options

ps/trunk/binaries/data/mods/public/maps/random/fortress.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/entity.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/ai/petra/researchManager.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/AIInterface.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Cost.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/Population.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/interfaces/Population.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Foundation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_GuiInterface.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Population.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/pop_house_01.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/pop_house_02.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/filter/foundation.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/spy.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/barracks.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/dock.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/farmstead.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/forge.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/market.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/brit/storehouse.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/cart/apartment.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/cart/super_dock.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/celt_hut.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/celt_longhouse.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/barracks.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/dock.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/farmstead.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/forge.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/market.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/storehouse.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/gaul/tavern.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/hellenic_propylaea.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/hellenic_stoa.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/iber/defense_tower.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/iber/fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/kush/temple_amun.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/maur/palace.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers/apadana.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers/apartment_block.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers/house_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers/inn.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/pers/tacara.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/structures/rome/army_camp.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_civil_centre.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_house.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_house_big.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_stoa.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_temple.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_military_dock.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_military_fortress.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_special_rotarymill.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit.xml

Loading...
Wildfire Games ยท Phabricator