HomeWildfire Games

Customize hotkey categories & ordering, prepare for translation.

Description

Customize hotkey categories & ordering, prepare for translation.

  • adds JSON files to specify the human-readable categorization, name and description of hotkeys.
  • clean up code

Translation support via messages.json not yet added - the strings need another pass and that avoids translators doing redundant work. See D3641

Refs #5867, Refs #5996

Differential Revision: https://code.wildfiregames.com/D3596

Event Timeline

Stan raised a concern with this commit.Jun 14 2021, 4:30 PM
Stan added a subscriber: Stan.
Stan added inline comments.
/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/ingamegui.json
107

Toggle.

This commit now has outstanding concerns.Jun 14 2021, 4:30 PM
Silier added a subscriber: Silier.Jun 14 2021, 6:33 PM
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/ingamegui.json
127

Rewind?

bb added a subscriber: bb.Sep 10 2021, 3:34 PM

A few of the descriptions end with a period. IMO all of them should.

/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/engine.json
24

I sort-of expect a capital U here

/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/ingame.json
120

Cap

/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/ingamegui.json
12

This doesn't seem to be any desciptive

16

same

/ps/trunk/binaries/data/mods/public/gui/hotkeys/spec/selection.json
96

Above there were caps of control group. It should be consistent.

Stan resigned from this commit.Jul 6 2022, 11:00 AM
This commit no longer requires audit.Jul 6 2022, 11:00 AM