Diffusion 0 A.D. Public Repository rP25360

Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components
rP25360
Actions

Description

Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components

TERRAIN_TILE_SIZE is now only used in relevant places in the simulation.
This also makes it mostly possible to use CFixed in constexpr contexts.

Refs #5566

Differential Revision: https://code.wildfiregames.com/D3078

Details

Auditors

Langbart

Committed

wraitii

May 2 2021, 7:40 PM

Differential Revision

D3078: Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components

Parents

rP25359: Fix some warnings.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 17017
Build 39035: Trigger Windows Autobuild
Build 39034: Post-Commit Build	Jenkins
Build 39033: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP25360: Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components.May 2 2021, 7:40 PM

wraitii added an edge: D3078: Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components.

Harbormaster completed building B17017: rP25360: Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components.May 2 2021, 8:29 PM

Stan mentioned this in D3948: Fix no pch after recent changes.May 10 2021, 11:56 PM

Stan mentioned this in rP25423: Fix no-pch build. Potentially fixes Phab:rP25360, Phab:rP25377, Phab:rP25366….May 12 2021, 3:49 PM

A problem has been detected - #6374.

This commit now has outstanding concerns.Nov 5 2021, 10:36 PM

wraitii mentioned this in rP26663: Fix passibilty overlay in atlas.Mar 17 2022, 4:19 PM

D4338

This commit no longer requires audit.Mar 26 2022, 5:33 PM

Changes (18)

Path

Size

ps/

trunk/

source/

graphics/

TerritoryTexture.cpp

maths/

Fixed.h

simulation2/

components/

CCmpObstructionManager.cpp

CCmpPathfinder.cpp

CCmpPathfinder_Common.h

CCmpRangeManager.cpp

CCmpTerritoryManager.cpp

CCmpUnitMotion.h

CCmpUnitMotionManager.h

ICmpRangeManager.h

tests/

test_Pathfinder.h

test_TerritoryManager.h

helpers/

HierarchicalPathfinder.h

rP25360

View Options

ps/trunk/source/graphics/TerritoryTexture.cpp

View Options

ps/trunk/source/maths/Fixed.h

View Options

ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpPathfinder.cpp

View Options

ps/trunk/source/simulation2/components/CCmpPathfinder_Common.h

View Options

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpUnitMotion.h

View Options

ps/trunk/source/simulation2/components/CCmpUnitMotionManager.h

View Options

ps/trunk/source/simulation2/components/ICmpRangeManager.h

View Options

ps/trunk/source/simulation2/components/tests/test_Pathfinder.h

View Options

ps/trunk/source/simulation2/components/tests/test_TerritoryManager.h

View Options

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.h

View Options

ps/trunk/source/simulation2/helpers/LongPathfinder.h

View Options

ps/trunk/source/simulation2/helpers/Pathfinding.h

View Options

ps/trunk/source/simulation2/helpers/Position.h

View Options

ps/trunk/source/simulation2/helpers/VertexPathfinder.cpp

View Options

ps/trunk/source/simulation2/helpers/VertexPathfinder.h

Further reduce usage of TERRAIN_TILE_SIZE in non-terrain componentsrP25360Actions

Description

Details

Event Timeline

Changes (18)

rP25360

ps/trunk/source/graphics/TerritoryTexture.cpp

ps/trunk/source/maths/Fixed.h

ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp

ps/trunk/source/simulation2/components/CCmpPathfinder.cpp

ps/trunk/source/simulation2/components/CCmpPathfinder_Common.h

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp

ps/trunk/source/simulation2/components/CCmpUnitMotion.h

ps/trunk/source/simulation2/components/CCmpUnitMotionManager.h

ps/trunk/source/simulation2/components/ICmpRangeManager.h

ps/trunk/source/simulation2/components/tests/test_Pathfinder.h

ps/trunk/source/simulation2/components/tests/test_TerritoryManager.h

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.h

ps/trunk/source/simulation2/helpers/LongPathfinder.h

ps/trunk/source/simulation2/helpers/Pathfinding.h

ps/trunk/source/simulation2/helpers/Position.h

ps/trunk/source/simulation2/helpers/VertexPathfinder.cpp

ps/trunk/source/simulation2/helpers/VertexPathfinder.h

Further reduce usage of TERRAIN_TILE_SIZE in non-terrain components
rP25360
Actions