HomeWildfire Games
Diffusion 0 A.D. Public Repository rP27192

Remove user.cfg from javascript
AuditedrP27192
Actions

Description

Remove user.cfg from javascript

remove path from javascript
path is defined by the configuration scope

combine some calls
remove not needed calls

Differential revision: D4616
Accepted by: @Freagarach, @nani
Comments by: @phosit

Details

Auditors
phosit
Stan
Committed
SilierNov 2 2022, 8:21 AM
Differential Revision
D4616: Remove user.cfg from javascript
Parents
rP27191: Han Officer Helmet (New)
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21023
Build 50816: Trigger Windows Autobuild
Build 50815: Post-Commit BuildJenkins
Build 50814: Post-Commit Build (macOS)Jenkins

Event Timeline

Silier committed rP27192: Remove user.cfg from javascript.Nov 2 2022, 8:21 AM
Silier added an edge: D4616: Remove user.cfg from javascript.
Silier added subscribers: phosit, Freagarach, nani.
Harbormaster completed building B21023: rP27192: Remove user.cfg from javascript.Nov 2 2022, 8:49 AM
phosit raised a concern with this commit.Nov 3 2022, 3:02 PM
phosit added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/AutoFormation.js
41

ConfigDB_ is doubled.
Freagarach already mentioned it in the diff.

This commit now has outstanding concerns.Nov 3 2022, 3:02 PM
Silier mentioned this in rP27194: Save configuration once when possible.Nov 3 2022, 5:45 PM
Silier requested verification of this commit.Nov 3 2022, 5:47 PM
This commit now requires verification by auditors.Nov 3 2022, 5:47 PM
phosit accepted this commit.Nov 4 2022, 9:30 PM
All concerns with this commit have now been addressed.Nov 4 2022, 9:30 PM
Stan raised a concern with this commit.EditedDec 11 2022, 6:05 PM
Stan added a subscriber: Stan.
Engine.ConfigDB_WriteValueToFile is not a function
  setCurrent@gui/common/campaigns/CampaignRun.js:85:10
  createAndStartCampaign@gui/campaigns/new_modal/NewCampaignModal.js:28:5
  @gui/campaigns/new_modal/NewCampaignModal.js:13:65</p>

You forgot to update CampaignRun.js. Noted by a potential future contributor.

This commit now has outstanding concerns.Dec 11 2022, 6:05 PM
Silier mentioned this in D4846: Fix r27192.Dec 22 2022, 5:28 PM
Silier mentioned this in rP27307: Fix r27192.Dec 27 2022, 12:13 PM
Silier requested verification of this commit.Dec 27 2022, 12:14 PM
This commit now requires verification by auditors.Dec 27 2022, 12:14 PM
Stan accepted this commit.Dec 27 2022, 12:19 PM
All concerns with this commit have now been addressed.Dec 27 2022, 12:19 PM
wraitii mentioned this in D5040: Fix 'Options' asking for confirmation without changes during a game..Jun 8 2023, 9:25 AM
wraitii mentioned this in rP27730: Fix 'Options' asking for confirmation without changes during a game..Jun 23 2023, 9:19 AM

Changes (20)

PathSize
ps/
trunk/
binaries/
data/
mods/
mod/
gui/
modmod/
public/
gui/
common/
campaigns/
gamesetup/
Controllers/
Pages/
GameSetupPage/
Panels/
gamesetup_mp/
hotkeys/
lobby/
LobbyPage/
Buttons/
options/
prelobby/
common/
credentials/
session/
chat/
top_panel/
splashscreen/
source/
ps/
scripting/

rP27192

View Options

ps/trunk/binaries/data/mods/mod/gui/modmod/modmod.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/common/campaigns/CampaignRun.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Controllers/PlayerAssignmentsController.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/TipsPanel.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/hotkeys/HotkeyPicker.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/hotkeys/HotkeysPage.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/lobby/LobbyPage/Buttons/BuddyButton.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/options/options.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/prelobby/common/credentials/credentials.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/AutoFormation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/RangeOverlayManager.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatWindow.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/CounterManager.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/splashscreen/splashscreen.js

Loading...
View Options

ps/trunk/source/ps/ConfigDB.cpp

Loading...
View Options

ps/trunk/source/ps/ConfigDB.h

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.cpp

Loading...
Wildfire Games · Phabricator