Pull Diplomacy out of cmpPlayer.
Who says only players should be able to conduct diplomacy?
Also separation of concerns, more maintainable files.
Differential revision: https://code.wildfiregames.com/D4921
Comments by: @elexis, @Stan
Refs. #5894
Description
Description
Details
Details
- Auditors
wraitii - Committed
Freagarach Jun 19 2023, 8:33 AM - Differential Revision
- D4921: Pull Diplomacy out of cmpPlayer.
- Parents
- rP27721: [Windows] Automated build.
- Branches
- Unknown
- Tags
- Build Status
Buildable 22041 Build 53755: Post-Commit Build Jenkins Build 53754: Post-Commit Build (macOS) Jenkins
Event Timeline
Comment Actions
This appears to error, per gameboy and myself https://wildfiregames.com/forum/topic/107586-an-error-occurred/#comment-553741 (I bisected it to this commit)
Can reproduce by starting Jebel Barka like so:
binaries/system/pyrogenesis -autostart="random/jebel_barkal" -autostart-seed=-1 -autostart-players=2 -autostart-civ=1:athen -autostart-civ=2:brit -autostart-ai=1:petra -autostart-ai=2:petra -autostart-player=1
Comment Actions
@wraitii Your error is fixed with D5060 i think.
There are other errors when saving and loading a game: https://wildfiregames.com/forum/topic/108069-diplomacy-broken-since-rev-27722
| /ps/trunk/binaries/data/mods/public/simulation/components/Diplomacy.js | ||
|---|---|---|
| 21 | Changing for...in to for...of fixes it. | |
| /ps/trunk/binaries/data/mods/public/simulation/components/Diplomacy.js | ||
|---|---|---|
| 21 | Might not be a complete patch. | |