There was an issue with the water shader. It didn't cost the water height and always had set it to 15.0.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths)
- rP22004: Clean up and fix height of water vertex shader.
- Run the game and open maps with water on different heights.
- Check that the water looks ok and not really worse.
Because we have a horizontal plane, defined by xOz. But the Y-axis looks upward.
The normal has a different space (2D with additional params), so a_vertex.y isn't equal to normalCoords.y.
I didn't change the expression, you can compare it with the old one:
Why the original is so? Because a_waterInfo.r is in [0, 1] as I understand the code.
My opinion is that the name of the variables is explicit enough here. I don't care that much about it though so feel free to commit it with those if you prefer.