Page MenuHomeWildfire Games

Reset selection in findIdleUnits even if no units are idle
Needs RevisionPublic

Authored by cpc on Dec 10 2018, 9:27 PM.

Details

Reviewers
bb
elexis
Stan
smiley
Trac Tickets
#5360
Summary

Alt+period currently preserves the current selection if all units are busy, which can mislead a player into thinking that there were in fact some idle units. Resetting the selection gives a clear signal that all units are busy.

Test Plan

Start a new match, make sure that Alt+period still selects all units; then assign tasks to all units, select a busy unit, and ensure that Alt+period deselects it; finally make sure that Shift + Alt + Period still works (currently selected units are not deselected, even if they are busy).

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6504
Build 10758: arc lint + arc unit

Event Timeline

cpc created this revision.Dec 10 2018, 9:27 PM
Owners added a subscriber: Restricted Owners Package.Dec 10 2018, 9:27 PM
smiley added a comment.EditedDec 11 2018, 7:02 AM

To be honest, I find this behavior to be more unintuitive. Currently I won't lose my selection if I just wanted to check if there are any idle units (usually, if there are none I would do something with the current selection). But now, I would have to add the units to the selection after.
Maybe it's just me, but I think it would be best to remove that todo. Engine.PlayUISound(filename, looping); if interested.

In D1692#67009, @smiley wrote:

To be honest, I find this behavior to be more unintuitive. Currently I won't lose my selection if I just wanted to check if there are any idle units (usually, if there are none I would do something with the current selection). But now, I would have to add the units to the selection after.
Maybe it's just me, but I think it would be best to remove that todo. Engine.PlayUISound(filename, looping); if interested.

I have similar thoughts, but I posted them in the ticket: https://trac.wildfiregames.com/ticket/5360 :)

Stan requested changes to this revision.Dec 11 2018, 8:44 AM
Stan added a subscriber: Stan.

Then it's decided. To fix this issue it's better to play a sound :)

This revision now requires changes to proceed.Dec 11 2018, 8:44 AM
smiley resigned from this revision.Jan 15 2019, 9:00 AM