Page MenuHomeWildfire Games

Remove redundant checks in HandleObstructedMove performed already by PathResult
ClosedPublic

Authored by wraitii on Jun 15 2019, 9:42 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22448: Remove redundant checks in HandleObstructedMove performed already by PathResult
Summary

HandleObstructedMove contains logic to drop long waypoints, should they be occupied by units (because that can get the pathfinder stuck, since the long-range pathfinder can find a path, but not the vertex one.

However PathResult already drops waypoints this way, so this code can be removed for simplification.

Test Plan

Order a unit to move such that a long waypoint ends up in a group of unit, inaccessible. Notice that the waypoint gets dropped and the unit isn't stuck.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jun 15 2019, 9:42 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1733/display/redirect

wraitii updated this revision to Diff 8782.Mon, Jul 8, 8:28 PM

Rebased for jenkins.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1946/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jul 9, 9:59 PM
This revision was automatically updated to reflect the committed changes.