See #4549.
The diff is big, so you might prefer reviewing the git branch at https://github.com/na-Itms/0ad/tree/nvtt.
I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see.
Differential D2475 Authored by Itms on Dec 16 2019, 11:32 PM.
Details
Summary See #4549. The diff is big, so you might prefer reviewing the git branch at https://github.com/na-Itms/0ad/tree/nvtt. I'm uploading it here for Jenkins, though arcanist may have botched the job, we'll see. Test Plan Test on Linux (done by me, gcc 8), Windows (done by me), macOS. Windows Developers will need to build with --large-address-aware if they don't want to hit memory limits when rebuilding all their texture cache.
Diff Detail
Event TimelineComment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1292/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/776/display/redirect Comment Actions
Welp, it definitely did... The linux failure is arcanist not patching the build.sh correctly. The windows failure rather looks like the workspace not being properly updated. Comment Actions Okay so I tested this with and without cache. Comment Actions Haven't tried your branch yet cause cloning the repo would take me ages but I get this warning when building with the current NVTT on a RPI4 without --with-system-nvtt. CMake Warning (dev) at /usr/share/cmake-3.13/Modules/FindOpenGL.cmake:270 (message): Policy CMP0072 is not set: FindOpenGL prefers GLVND by default when available. Run "cmake --help-policy CMP0072" for policy details. Use the cmake_policy command to set the policy and suppress this warning. FindOpenGL found both a legacy GL library: OPENGL_gl_LIBRARY: /usr/lib/arm-linux-gnueabihf/libGL.so and GLVND libraries for OpenGL and GLX: OPENGL_opengl_LIBRARY: /usr/lib/arm-linux-gnueabihf/libOpenGL.so OPENGL_glx_LIBRARY: /usr/lib/arm-linux-gnueabihf/libGLX.so OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for compatibility with CMake 3.10 and below the legacy GL library will be used. Call Stack (most recent call first): src/CMakeLists.txt:20 (INCLUDE) This warning is for project developers. Use -Wno-dev to suppress it. Comment Actions If that could help you, there was perhaps some related diff in that file https://wildfiregames.com/forum/applications/core/interface/file/attachment.php?id=23155 This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2019, 12:22 PM This revision was landed with ongoing or failed builds. Closed by commit rP23305: Upgrade NVTT to version 2.1.1, fixes #4549. (authored by Itms). · Explain Why This revision was automatically updated to reflect the committed changes. Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Dec 29 2019, 12:22 PM
Revision Contents
Diff 10820 Wildfire Games · Phabricator |