Page MenuHomeWildfire Games

Building snapping loading screen tip
ClosedPublic

Authored by elexis on Jan 7 2020, 7:19 PM.

Details

Summary

Since many if not most players won't notice the new snapping feature from rP23330/D2079, here a loading screen tooltip that indicates the feature.

Test Plan

For the screenshot, I thought about using ptolemians since they get free houses and corrals, so it could demonstrate the use case for alignment better.
Also housewalls are common around fields around the CC.
If someone wants to do better you are free to do so.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Jan 7 2020, 7:19 PM
Nescio added a subscriber: Nescio.Jan 7 2020, 7:20 PM
Nescio added inline comments.
binaries/data/mods/public/gui/text/tips/snapping.txt
2 ↗(On Diff #10914)

Shouldn't you inform them what the hotkey is?

2 ↗(On Diff #10914)

Also, structures, not buildings, per https://trac.wildfiregames.com/wiki/EnglishStyleGuide

Vulcan added a comment.Jan 7 2020, 7:23 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1492/display/redirect

elexis edited the summary of this revision. (Show Details)Jan 7 2020, 7:25 PM
Vulcan added a comment.Jan 7 2020, 7:37 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/974/display/redirect

Vulcan added a comment.Jan 7 2020, 8:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/70/display/redirect

bb added a subscriber: bb.Jan 14 2020, 8:27 PM

D2546 would require to change this

binaries/data/mods/public/gui/loading/TipDisplay.js
20 ↗(On Diff #10914)

k

binaries/data/mods/public/gui/text/tips/snapping.txt
2 ↗(On Diff #10914)

informing which hotkey isn't really possible, since users can have different hotkeys set

In D2545#107432, @bb wrote:

D2546 would require to change this

What do you mean? Additional text that it's possible to disable the feature?

binaries/data/mods/public/gui/loading/TipDisplay.js
20 ↗(On Diff #10914)

I suppose for testing.

binaries/data/mods/public/gui/text/tips/snapping.txt
2 ↗(On Diff #10914)

Agree with "structure".

bb added a comment.May 2 2020, 9:08 PM
In D2545#107432, @bb wrote:

D2546 would require to change this

What do you mean? Additional text that it's possible to disable the feature?

Guess I thought about that, not sure anymore now

binaries/data/mods/public/gui/text/tips/snapping.txt
3 ↗(On Diff #10914)

Not an expert at all, but grammar appears off. Guess it should be: Aligning buildings allows to ... and obstructs ...

Freagarach added inline comments.
binaries/data/mods/public/gui/text/tips/snapping.txt
3 ↗(On Diff #10914)

I guess ones best bet to obstruct is to place structures very close to eachother but not touching, to trick the pathfinder.

Freagarach updated this revision to Diff 15040.Thu, Jan 7, 12:16 PM

Building -> Structure

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Thu, Jan 7, 12:17 PM
Stan added a subscriber: Stan.Thu, Jan 7, 12:18 PM

@Nescio thoughts on this?

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2709/display/redirect for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jan 15, 9:47 AM
This revision was automatically updated to reflect the committed changes.