Page MenuHomeWildfire Games

deprecate template_unit_cavalry_melee.xml and *_ranged.xml
Needs ReviewPublic

Authored by Nescio on Aug 16 2020, 10:04 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary
template_unit_cavalry_melee.xml
template_unit_cavalry_ranged.xml

do little more than add a health value and a visible class and are thus not particularly useful. This patch removes them. Advantages are:

  • meaningful values are defined in a single template, rather than arbitrarily scattered over two levels;
  • citizen cavalry templates are more parallel to champion and hero cavalry templates, which don't have *melee* or *ranged* either;
  • shorter template file names.

Similar patches have been committed in the past:

  • D1734/rP22061 removed template_entity_full.xml and template_entity_quasi.xml.
  • D1760/rP22204 removed template_unit_mechanical.xml.
Test Plan

Check for completeness and correctness. Effectively no values should be changed. Verify everything works as before.

Event Timeline

Nescio created this revision.Aug 16 2020, 10:04 PM
Owners added a subscriber: Restricted Owners Package.Aug 16 2020, 10:04 PM
Nescio requested review of this revision.Aug 16 2020, 10:09 PM
Nescio added a subscriber: bb.Wed, Aug 26, 5:33 PM

@bb, @Freagarach, other team members, any opinions on this?

Nescio updated this revision to Diff 13344.Sat, Aug 29, 12:06 PM
  • rebased