Page MenuHomeWildfire Games
Differential D3726

attempt to update D3023
AbandonedPublic
Actions

Authored by submariner on Mar 22 2021, 7:47 PM.

Details

Reviewers
vladislavbelov
Stan
Summary

This kinda does both of TODO in comments from GameSetup.cpp

  • gets texturequality from .cfg file -
  • adds anisotropic filtering to the 6th setting

however I cant seem to be able to see any graphical differences between any of them even if just hard changing that in GameSetup.cpp

Test Plan

just changing the texturequality setting and trying to look for differences between 0 and 6

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

submariner requested review of this revision.Mar 22 2021, 7:47 PM
submariner created this revision.
submariner edited the summary of this revision. (Show Details)Mar 22 2021, 7:59 PM
submariner updated this revision to Diff 16658.Mar 22 2021, 8:05 PM
submariner edited the summary of this revision. (Show Details)

updating with diff produced using 'svn diff' instead of previously 'diff this that'

submariner updated this revision to Diff 16660.Mar 22 2021, 8:23 PM

attempting to update with diff produced by

svn diff --diff-cmd=diff -x -U9999

as suggested by Langbart

Silier added a subscriber: Silier.EditedMar 22 2021, 8:24 PM

hi,
could you please reupload with context ?

svn diff --diff-cmd diff -x "-U 99999" > changes.patch

https://trac.wildfiregames.com/wiki/SubmittingPatches

thank you

-----Edit----
I was too slow xD

nwtour added a subscriber: nwtour.Mar 22 2021, 8:26 PM
nwtour added inline comments.
binaries/data/config/default.cfg
1

typo

source/lib/res/graphics/ogl_tex.cpp
58

indentation differs from adjacent lines

Freagarach added a reviewer: vladislavbelov.Mar 22 2021, 8:26 PM
Freagarach set the repository for this revision to rP 0 A.D. Public Repository.
nwtour added inline comments.Mar 22 2021, 8:32 PM
source/ps/GameSetup/GameSetup.cpp
1428

If this is a new argument it would be nice to add it to binaries/system/readme.txt

submariner added inline comments.Mar 22 2021, 8:39 PM
source/ps/GameSetup/GameSetup.cpp
1428

oh, I forgot about it. Was just attempting to make a new argument yesterday, but later I found out that it can be alerted on launch with

./pyrogenesis -conf=texturequality:6

probably better to remove as it's not necessary at least to me anymore

submariner updated this revision to Diff 16663.Mar 22 2021, 9:12 PM

removed leftover of my original attempt, so now its just basically D3023, rebased if that's a proper word for it

this can be adjusted with already implemented CLI functionality of pyrogenesis assuming this patch is applied

./pyrogenesis -conf=texturequality:6

but -conf seems to work with parameters that does not even written in any cfg file, like when some mod needs some specific key combo etc..

submariner updated this revision to Diff 16664.Mar 22 2021, 9:20 PM

identation

submariner added inline comments.Mar 22 2021, 9:22 PM
source/lib/res/graphics/ogl_tex.cpp
58


yep, its good that you pointed that out, my text editor was playing tricks on me, appears properly idented except that little gray arrow there.

submariner updated this revision to Diff 16665.Mar 22 2021, 9:32 PM

identation again

submariner marked 2 inline comments as done.Mar 22 2021, 9:36 PM
nwtour added inline comments.Mar 22 2021, 9:49 PM
source/lib/res/graphics/ogl_tex.cpp
58


yep, its good that you pointed that out, my text editor was playing tricks on me, appears properly idented except that little gray arrow there.

It is advisable to correct indents along the entire length of the patch ;-)

59

here

433

here

source/ps/GameSetup/GameSetup.cpp
168

here

992–995

Comments from debugging should be removed.

submariner updated this revision to Diff 16666.Mar 22 2021, 10:00 PM

more identation

Freagarach set the repository for this revision to rP 0 A.D. Public Repository.Mar 23 2021, 6:56 AM
Stan added a subscriber: Stan.EditedMar 23 2021, 7:56 AM

You should see a difference on buildings like the cart civic center where things might get blurry.

Note that Vladislav made me disable it in atlas since it breaks the terrain previews.

EDIT: I found a way to fix it but it wasn't nice code

Another way to make it more visible is to edit stuff like OGL_TEX_HALF_RES (custom constant) making it a quarter or an eights res.

What this patch does is skip mipmaps. A reason it's less visible on terrain is the texture are big. Hope it helps.

Stan requested changes to this revision.May 31 2021, 3:03 PM

Needs to be rebased.

This revision now requires changes to proceed.May 31 2021, 3:03 PM
Stan mentioned this in D3023: [WIP] Allow anisotropic filtering for textures.Dec 12 2021, 9:01 PM
vladislavbelov abandoned this revision.Feb 13 2022, 10:54 PM

Superceeded by rP26365. Related code was removed in rP26367.

Revision Contents
Changeset List

PathSize
binaries/
data/
config/
1 line
source/
lib/
res/
graphics/
3 lines
ps/
GameSetup/
12 lines

Diff 16666

View Options

binaries/data/config/default.cfg

Loading...
View Options

source/lib/res/graphics/ogl_tex.cpp

Loading...
View Options

source/ps/GameSetup/GameSetup.cpp

Loading...
Wildfire Games · Phabricator