Fix a typo in a file name
ClosedPublic
Actions

Authored by Itms on Jun 4 2017, 11:15 PM.

Details

Reviewers

Stan

Commits

rP20124: Fix the "Thermistocles" typo in the helmet prop file name. Refs r19733.

Summary

I committed a extraneous fix in rP19733 so we may as well fix the thing properly...

Test Plan

Make sure I'm not overseeing something in the baroque artistic part of the game ?

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Jun 4 2017, 11:15 PM

I'll look at it tomorrow :)

Executing section Default...
Executing section Source...
Executing section JS...
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/132/ for more details.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Checking XML files...

http://jw:8080/job/phabricator/1482/ for more details.

Harbormaster completed remote builds in B2171: Diff 2435.Jun 5 2017, 4:31 AM

You are missing

ps\trunk\binaries\data\mods\public\art\actors\props\units\shields\hele_round_thermistocles.xml

Found by running the following in cmd (grep equivalent on windows):

dir /a /s /b | findstr /R /C:"thermistocles"

This revision now requires changes to proceed.Jun 5 2017, 11:09 AM

In D604#24907, @Stan wrote:
You are missing
ps\trunk\binaries\data\mods\public\art\actors\props\units\shields\hele_round_thermistocles.xml
Found by running the following in cmd (grep equivalent on windows):
dir /a /s /b | findstr /R /C:"thermistocles"

Related to D589, where 'thermistocles' is renamed to 'themistocles'.

While at it, might also want to fix the other "patroling" occurance in unit_actions.js that wasn't fixed by that commit

In D604#24973, @elexis wrote:

While at it, might also want to fix the other "patroling" occurance in unit_actions.js that wasn't fixed by that commit

That is already part of D589.

Well in this case this looks good.

This revision is now accepted and ready to land.Jul 1 2017, 11:21 PM

(@Itms: checking scripts complains about it Missing file 'art/textures/skins/props/helmet/hele_themistocles.dds' referenced by: 'public/art/actors/props/units/heads/celt_viridomarus.xml' (and texture error in atlas for example).)

@Itms any updates on this ?

Closed by commit rP20124: Fix the "Thermistocles" typo in the helmet prop file name. Refs r19733. (authored by Itms). · Explain WhySep 6 2017, 10:56 PM

This revision was automatically updated to reflect the committed changes.