In D1252#90261, @Stan wrote:

@Mate-86 Sad to hear that but I hope you'll have fun with your new project. What is it called ?

In D1252#79375, @wraitii wrote:

@Mate-86 I would suggest working on a simple graphical icon next, so that this can actually be used in-game without looking super weird and confusing players.

There are a bunch of options, I would recommend have at least an icon in the top-row of the unit's portrait when it's selected.
Then you can think of adding:

• an icon on top of the unit when it's selected (like auras)
• actual graphical effects (I think the best thing here would be to spawn an actor of some kind?)

In D1252#79344, @Stan wrote:

Thank you for finishing this ! Do you plan to work on something else next ?

In D1252#78987, @wraitii wrote:

Think this looks good, should probably rename Status to StatusEffectReceiver or something similar (following the DamageReceiver nomenclature), but that can be done before committing.

Thanks for the patch @Mate-86 !

I renamed the my map file to an existing map so that I could play on it. :) Save game/load game works, the builings hit by the burning attack continued receiving damage after loading the game.
I did a multi player test via localhost and the damage dealt are in sync in both player session: https://imgur.com/a/PKXNvMt

There is a way to do it from the command line though off-hand I won't be able to tell you how exactly. It's documented in binaries/system/readme.txt I think.

I can look into this later.

Thanks for the comments @wraitii and @Stan ! I've addressed those expect the testing of saved game because I could not open the test map I've created. Is there any trick to make it visible in the scenario selector?

Notes regarding the new diff:

1. Did you mean calling cmpDamage.CauseDamage? Because in that case I have to construct the strengths object and need pass the attacker and attackerOwner as parameters to the Status.
2. Currently the first occurance of the effect is hard-coded to 0 sec. Not sure if it's OK for now.
3. Would it make sense to make the statusEffectsSchema in Attack.js more generic? Eg. using

As discussed moving the StatusEffects inside the Attack component and changing the posioning to burning. Open questions:

1. Should multiple status effects reset the timer?
2. Should the status effects be added to other attack types? (melee, splash, indirect ranged attack)
3. Should there be an animation played or an icon to be shown? I assume for a flaming animation on the target C++ change is needed too.

Feel free to comment!

@wraitii I like your proposal about the separate components. Please review my latest patch! It contains the basic components which can be enhanched further (testing in-game, more unit tests, burning effect, particle, sound, optimizations, etc.)

Addressed @Angen 's comments and wrote some unit tests. Please review again!

In D1252#76873, @Stan wrote:

@Mate-86 any news ? :)

Hi @Stan ! Currently I'm working on fixing the failed build. Apart from that I need your or someone else's help to check the current solution is good. It works for the range attack only but if you like it then I can extend it to melee and splash attack too. What do you think? :)

In D1252#68353, @Stan wrote:

Any updates @Mate-86 ?

In the meantime I wanted to upload all my changes since it turned out the C++ comments I cannot address right now. Let's have a look if you like it or not and feel free to switch back to my Dec 4 patch if it's better.

Tried to address all the code formatting issues.

Thinking about removing LaunchProjectile method because it's only used by the LaunchProjectileAtPosition.
Not sure whether it makes sense to introduce a new interface method in ICmpProjectileManager.cpp for LaunchProjectileAtPosition but with less parameters. If the actorName is not defined then the LaunchProjectile returns earlier without creating the projectile (not a valid scenario).
Unit tests will come most probably in a separate patch.

Projectile definition is moved into the Attack/Ranged part of the entity template. Open questions:

1. Does that make sense to cover this changes with unit tests (JS and C++ part)?
2. @wraitii proposed to do the projectile actor defaulting (fall back to visual actor, see CCmpProjectileManager.cpp L191) in JS instead of in C++. I thought this further and how about replacing the source parameter of LaunchProjectileAtPoint with sourcePosition and in this case there is no need for the source entity in CCmpProjectileManager at all? For this the function cmpSourceVisualActor->GetProjectileLaunchPoint(); need to be exposed to JS.

In D945#41634, @leper wrote:

for (type varname : iterable) creates a copy of the current element which is placed in varname. Use for (type& varname : iterable) to just keep a reference, and if you want to make it obvious that the loop does not modify the elements in iterable use for (const type& varname : iterable).

Ok, I've fixed this.

In D945#41471, @leper wrote:

@Itms Why does this not get built? That would at the very least point out one unused parameter.

I removed the unused parameters from the RenderModel function.

Hi Stan, out of the 3 cases you mentioned there are 2 supported now:

• "when in flight" => Projectile/Actor
• "when hitting" => Projectile/HitActor

I'm not sure about the your 3rd option but if you mean something like a muzzle flash, it can be added as well: https://upload.wikimedia.org/wikipedia/commons/thumb/2/2d/FNFLASH01.jpg/1200px-FNFLASH01.jpg
Enhanced arrow visibility is possible now, only the proper actor definition is needed. Eg. for smg like this: http://fireflyworlds.com/wp-content/uploads/sites/2/2015/05/11-1024x576.jpg

I created the new component cmpProjectile as proposed by @wraitii . Please have a look if you like it or not!
If this new component is approved then probably the templates could contain the projectile actor which could be removed from the unit actor files. (right now there is a fall back to the unit actor if the Projectile is not present in the template.)

In D945#39284, @wraitii wrote:

Basically instead of calling cmpSourceVisual->GetProjectileActor, you'd call cmpProjectile->GetProjectileActor().

The length of the projectile hit animation can be defined in the unit Template using Decay/DelayTime.

Thanks for all the feedback!
Addressed by the latest diff:

• using the projectile hit animation name from the actor file instead of hard-coding
• Explosion renamed to ProjectileHitAnimation
• code duplication removed from RenderSubmit by using a template function

In D945#37521, @wraitii wrote:

Given the orientation taken by the code (i.e. not using local entities), I feel like it might be worth creating an "Effects manager" that effectively handles all kind of "temporary" graphical effects like this — possibly including particles?. But I haven't thought too much about it.

In the meantime though, "Explosion" is a rather poor word since it really doesn't have to explode. Maybe "SpecialEffect" or something. Also your rendersubmit has two basically identical loops, maybe template it or have both inherit from a common struct?

How are flames created by flaming projectiles handled right now?

I agree. A new effect manager could be used for other purposes as well. Eg. https://trac.wildfiregames.com/ticket/1912 Continuous damage after hit detection could use some animations too. Explosion could be replaced by a more general term indeed.

Explosion animation works finally! There are lots of TODOs in the code which I have to address as part of this diff but feel free to do some early review.

In D921#36505, @fatherbushido wrote:

leper: ok!
@Mate-86: thx! I permit myself to not add the todo, instead we'll just do it. So next one?

In D921#36353, @fatherbushido wrote:

@Mate-86: I have always issue with your endline (I need to upload the raw diff and save it again with unix like line ending)

In D921#36217, @Pureon wrote:

Committed the ogg fix.

With the new ogg the warning is not thrown anymore. Thanks!

Sounds like this (the warnings on top are just for showing the position used for playing the sound):

Thanks for the sound Pureon! It fits well in the game. There is an issue with the 3rd file not sure if you have seen this before? "OpenAL: stereo sounds can't be positioned: audio/attack/impact/siegeprojectilehit_03.ogg"

I've pinged Pureon via Forum PM.

Do you know how to contact @Pureon for new sounds? I cannot tag him here in Differential. Right now there would be good to have an explosion sound for the onager missile hit.
Do we need separate sound for a projectile hitting the ground/target and causing the damage (explode)? The later can be delayed.

LOL nice test evidence video! :D

The updated diff should contain the delay feature related change. Changes related to the sound and animation will come in later diffs.

In D748#33256, @fatherbushido wrote:

(That sound thing is a bit annoying)
Don t hesitate to suggest other design.

diff reduced by using template inheritance

The latest diff contains:

• making Delay as a mandatory child of Ranged element
• adding sound to missileHit (temporarily hardcoded the building destruction but can be defined in the template later)

@Stan @fatherbushido Thanks for the comments! I've updated the ticket description, please have a look! I'm checking the sound change and uploading a new diff soon.

In D748#31188, @Stan wrote:

Did you update the xml templates accordingly after making the tag non optional ?

I reviewed the changed:

• all my questions were answered satisfactorily (I even learnt new things, eg. placing the assertion in the mock function)
• I've tested the changes locally by setting different kind of DeathDamage bonuses for the Fireship
• all the changes are logical and properly covered with unit tests

If we want to have suicide units like in AoE, it may worth to implement the bonus for DeathDamage also (eg. petard deals extra damage against buildings but not against units): http://ageofempires.wikia.com/wiki/Suicide_Units

In D748#30866, @fatherbushido wrote:

@Mate-86:

I think you should do the work only in the damage component (it's perhaps time to add splash for melee attack too).

That's fine but do you mean the graphical part can be done solely in Damage component or do you mean excluding the graphical part from this ticket?

In D748#29339, @leper wrote:

I'd probably make the delay (which currently can already be 0) non-optional, so you don't have to worry about it not being there.

• I tested the change locally by running the game. DeathDamage still works and it does not throw any errors.
• Removal of the bonusSchema and linear shape makes sense because they are not used in DeathDamage component.
• This patch is OK to submit.

DeathDamage logic extracted to separate component from Attack component.

I did the following changes as instructed:

• moved up the calling of DeathDamage in the Health component code (plus making a switch)
• sorted out the diplomacy handling of FriendlyFire (GetAllPlayers functions added)

I've updated the description. Please have a look and challenge it so that requirement related concerns can be identified prior to implementation.

Uploaded a new diff fixing most of the issues raised. These ones are still outstanding:
https://code.wildfiregames.com/D451#inline-8878
https://code.wildfiregames.com/D451#inline-8839