Revamp of the quotes in the game loading screen, research and patch by Phormio.
AuditedrP19529
Actions

Description

Revamp of the quotes in the game loading screen, research and patch by Phormio.
Remove the "Quote of the Day" titling which did not make a lot of sense.

Undocumented or misleading quotes removed, new quotes, more historical context, and literary source for all of them.

Reviewed By: Gallaecio, Itms

Differential Revision: https://code.wildfiregames.com/D296

Details

Auditors

vladislavbelov

Committed

Itms	May 8 2017, 12:05 AM

Reviewer

Gallaecio

Differential Revision

D296: Fix, remove and add loading screen quotes

Parents

rP19528: Add a type argument for CanAttack method of Attack component. Patch by bb.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1546
Build 2441: Post-Commit Build	Jenkins

Event Timeline

Itms committed rP19529: Revamp of the quotes in the game loading screen, research and patch by Phormio..May 8 2017, 12:05 AM

Harbormaster completed building B1546: rP19529: Revamp of the quotes in the game loading screen, research and patch by Phormio..May 8 2017, 1:37 AM

It needs a small fix, the commit contains unescaped tags: [Spartans], [Alexander].

ERROR: Invalid tag 'Spartans' at 29 in '"The Lacedaemonians [Spartans] fought a memorable battle; they made it quite clear that they were the experts, and that they were fighting against amateurs." - Herodotus ("The Histories", VII. 211).

This commit now has outstanding concerns.May 9 2017, 1:12 PM

In rP19529#20916, @vladislavbelov wrote:

It needs a small fix, the commit contains unescaped tags: [Spartans], [Alexander].

ERROR: Invalid tag 'Spartans' at 29 in '"The Lacedaemonians [Spartans] fought a memorable battle; they made it quite clear that they were the experts, and that they were fighting against amateurs." - Herodotus ("The Histories", VII. 211).

Sorry for that, I updated D296.

elexis mentioned this in rP19555: Fix missing escaping in rP19529. Reported by Vladislav, patch by Phormio..May 11 2017, 11:39 PM

In rP19529#20961, @Phormio wrote:

In rP19529#20916, @vladislavbelov wrote:

It needs a small fix, the commit contains unescaped tags: [Spartans], [Alexander].

ERROR: Invalid tag 'Spartans' at 29 in '"The Lacedaemonians [Spartans] fought a memorable battle; they made it quite clear that they were the experts, and that they were fighting against amateurs." - Herodotus ("The Histories", VII. 211).

Sorry for that, I updated D296.

It is a bug that one can update closed patches. D296 should be updated to the original patch again in case we want people to not assume that this patch changes only 2 characters.
Create a new patch if you have a new patch.

Fixed by rP19555.