HomeWildfire Games

Adds anti-aliasing option with FXAA algorithm.
AuditedrP23484

Description

Adds anti-aliasing option with FXAA algorithm.

Differential Revision: https://code.wildfiregames.com/D2537

Event Timeline

Imarok added a subscriber: Imarok.Feb 28 2020, 6:05 PM

Hmm, is it intended, that FXAA is not used on maps with PostEffect to default even when I enabled FXAA in the options?
I guess we will definitely get some reports because of that after the release...

Imarok raised a concern with this commit.Feb 28 2020, 6:06 PM
This commit now has outstanding concerns.Feb 28 2020, 6:06 PM
nani added a subscriber: nani.EditedFeb 28 2020, 6:36 PM

Hmm, is it intended, that FXAA is not used on maps with PostEffect to default even when I enabled FXAA in the options?
I guess we will definitely get some reports because of that after the release...

Is not intended. I already knew about this side effect but forgot to mention it :(. The problem lies with the scenario and skirmish maps that have the post-effects as opt-in not opt-out given you need to include them to xml map data description.

OptimusShepard raised a concern with this commit.Mar 27 2020, 8:21 PM
OptimusShepard added a subscriber: OptimusShepard.

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Stan added a subscriber: Stan.Mar 27 2020, 8:24 PM

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Same map? It doesn't work on all maps if postprocessing is disabled on the map settings...

In rP23484#41603, @Stan wrote:

FXAA doesn't work on my linux system. On dual boot Windows it's working.
Manjaro 64Bit, Radeon RX 570

Same map? It doesn't work on all maps if postprocessing is disabled on the map settings...

No, real error. If FXAA is enabled, the error occurs when the launcher is starting, else when FXAA gets enabled. See log

vladislavbelov requested verification of this commit.May 3 2020, 12:38 AM
This commit now requires verification by auditors.May 3 2020, 12:38 AM
Imarok accepted this commit.May 3 2020, 11:40 AM
All concerns with this commit have now been addressed.May 3 2020, 12:11 PM