HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25470

Change the visuals of the counters in the top panel.
rP25470
Actions

Description

Change the visuals of the counters in the top panel.

  • Abbreviate large numbers (fixes #6063).
  • Added popMax to the population counter.
  • Also show 0 gatherers, highlights and changes the font.

Patch by: @Langbart
Differential revision: https://code.wildfiregames.com/D3911
Reviewed by: @Angen, @Freagarach
Comments by: @asterix, @nwtour, @s0600204, @wraitii

Details

Committed
FreagarachMay 20 2021, 10:55 AM
Reviewer
Silier
Differential Revision
D3911: Improve the usefulness of the counters in the top panel
Parents
rP25469: Rework Mod into a class.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17343
Build 40067: Post-Commit BuildJenkins
Build 40066: Post-Commit Build (macOS)Jenkins

Event Timeline

Freagarach committed rP25470: Change the visuals of the counters in the top panel..May 20 2021, 10:55 AM
Freagarach added an edge: D3911: Improve the usefulness of the counters in the top panel.
Freagarach added subscribers: Langbart, asterix, nwtour and 3 others.
Harbormaster completed building B17343: rP25470: Change the visuals of the counters in the top panel..May 20 2021, 11:40 AM
Silier added inline comments.May 23 2021, 2:00 PM
/ps/trunk/binaries/data/mods/public/gui/session/top_panel/CounterPopulation.js
26

0 should be colored as well

/ps/trunk/binaries/data/mods/public/gui/session/top_panel/CounterResource.js
20

same

Langbart added a comment.May 23 2021, 4:48 PM

Do you think I should color it in "gold" as well, or use the current style color ("200 200 200") and color it there instead of being defined in the styles.xml file?

Silier added a comment.EditedMay 23 2021, 7:22 PM

CounterPopulation.prototype.DefaultTotalGatherersColor

Langbart added a comment.May 23 2021, 8:15 PM
In rP25470#52062, @Angen wrote:

CounterPopulation.prototype.DefaultTotalGatherersColor

The different color for the "zeros" was chosen on purpose to make it clearer when there are no gatherers working on that number.

Langbart mentioned this in D4032: Increase the spacing in the top panel and synchronize the color in the tooltip for gatherers..May 30 2021, 4:38 AM
Freagarach added a comment.Aug 5 2021, 6:01 PM

Also fixed #5456.

Changes (5)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
common/
session/
top_panel/

rP25470

View Options

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/styles.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/CounterPopulation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/CounterResource.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/Counters.xml

Loading...
Wildfire Games · Phabricator