A new random set-biome map.
Details
Test map for bugs and other deficiencies.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 515 Build 825: Vulcan Build Jenkins
Event Timeline
Thanks for the preview image! I'd disable fog for the preview image though, so that the colors come out better
Can copy & paste the JS file to www.jshint.com and check whether there are unused variables?
Also fed the screenshot to arcadius who cried about the forest and metal amount being biased towards some players, but that's kind of expected as it's a random map. (Doing a more equal balance can be done in a big overhaul, adding a new option in the gamesetup)
binaries/data/mods/public/maps/random/african_plains.js | ||
---|---|---|
3 | Do we actually use anything from rmlib2 in this file? Can't find anything, so the reference can be nuked | |
6 | In case you're interested, there are some more functions about water, sun and skybot settings in environment.js | |
53 | This odd looking variable is used only once, better nuke it and replace the reference to it with it's value | |
124 | Same, the comment can go too then | |
binaries/data/mods/public/maps/random/african_plains.json | ||
6 | wild game? not wildlife? |
Build is green
Updating workspaces. Build (release)... Build (debug)... Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/329/ for more details.
binaries/data/mods/public/maps/random/african_plains.js | ||
---|---|---|
91 | Oh, also we use ++i instead of i++ where possible |
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/352/ for more details.
- Created a new thumbnail as the fog was really ugly
- Moved the stone mine function that was copied from sahel to rmlib/
- The JSON file was messed up in the last update somehow by copying the description from arctic summer which entirely does not fit for this map. Used the previous description and applied the wild game -> wild animals correction.
- Reduced fog factor and thickness, gave fog a slight red tone, as the white fog is more suitable to dense forests
- Changed ix++ to ++ix
- Fixed whitespace in programming.json
- FeXoR has reviewed the map in http://trac.wildfiregames.com/ticket/4354#comment:4 3 months ago
- niektb has accepted the map judging from a screenshot in IRC on 2016-12-01
Build has FAILED
Link to build: http://jw:8080/job/phabricator/355/
See console output for more information: http://jw:8080/job/phabricator/355/console