See rP20095 for a FALLTHROUGH statement.

But your code also looks cleaner without the switch to begin with (deduplication).

Which compiler did you use - I don't recall anyone reporting compile warnings on this file.

I used x86_64-linux-gnu-gcc-7.

In rP20095, the description mentions that AtlasObjectXML still has compiler warnings and suggests that it should be fixed.

Could you attach your warnings?

The attached file contains the warnings that this patch removes:

The modified code was introduced in rP6764.
There we see that CStrW::ToUTF8 had very similar if actually not entirely identical code. Now that function uses utf8_from_wstring in lib/utf8.cpp`.
So perhaps that's something that can be done here as well.

Said identical code was replaced in rP7201.
There we see that even static const char trailingBytesForUTF8[256] = { is copy&pasted and one copy was replaced....

So it looks like this should be fixed by deletion.

The catch was that lib/utf8.h couldn't be included directly.
D1395 removes exactly that duplication.

@s0600204 so this is a "won't fix" and unfortunately must be abandoned? (The patch looked good at first sight otherwise)