Page MenuHomeWildfire Games

Enable workshops
Needs ReviewPublic

Authored by Nescio on Jan 24 2019, 4:22 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch:

  • enables the workshop for all factions
  • reorders workshop training queue to ram, boltshooters, stonethrowers, siege towers
  • removes all siege units and technologies from all fortresses
  • lists champions before heroes in the production queues of fortresses
  • updates tooltips of fortresses
Test Plan

Check for desirability.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6835
Build 11237: Vulcan BuildJenkins
Build 11236: arc lint + arc unit

Event Timeline

Nescio created this revision.Jan 24 2019, 4:22 PM
Vulcan added a subscriber: Vulcan.Jan 24 2019, 4:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/996/

Nescio updated this revision to Diff 7386.Jan 24 2019, 4:29 PM
Nescio edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/997/

@Feldfeld @borg- were working on a mod to enable these buildings and to add counters. https://wildfiregames.com/forum/index.php?/topic/25281-expansion-pack-mod-release/
I suspect counters could make gameplay much more diverse (less spamming of one unit), and these buildings would be a dependency of said counters patch. D1707 also along the road.
When a23 was developed, it was also planned to make workshops and ranges etc. accessible. At least to have the templates present (whether or not all buildings were buildable for every civ by the units.)
So perhaps you are interested to mutually check each others proposal and come up with a common or agreed one.

When the workshop templates were introduced, I understood they were not yet enabled, because A23 was “just around the corner”, but that the intention was to use them eventually in the next alpha. Now all freezes are lifted and development has restarted, I think it's a suitable time to enable the workshop.
And yes, I'm aware @borg-'s Expansion Pack, @wowgetoffyourcellphone's Delenda Est, my 0abc, and probably a few other mods are already using the workshop (and other structures); however, all these mods do much more than just that. I think the workshop can be enabled in A24 independently from implementing a counter system or some other overhaul.

Nescio added a comment.Tue, Apr 9, 8:27 PM

Two days ago I started a poll on the forums – https://wildfiregames.com/forum/index.php?/topic/25628-should-workshops-be-enabled/ – and there appears to be clear majority in favour (19–2).