Page MenuHomeWildfire Games

Enable workshops
ClosedPublic

Authored by Nescio on Jan 24 2019, 4:22 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22984: Enable workshops for all civilisations.
Summary

This patch:

  • enables the workshop for all factions
  • reorders workshop training queue to ram, boltshooters, stonethrowers, siege towers
  • removes all siege units and technologies from all fortresses
  • lists champions before heroes in the production queues of fortresses
  • updates tooltips of fortresses
Test Plan

Check for desirability.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 24 2019, 4:22 PM
Vulcan added a subscriber: Vulcan.Jan 24 2019, 4:24 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/996/

Nescio updated this revision to Diff 7386.Jan 24 2019, 4:29 PM
Nescio edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/997/

@Feldfeld @borg- were working on a mod to enable these buildings and to add counters. https://wildfiregames.com/forum/index.php?/topic/25281-expansion-pack-mod-release/
I suspect counters could make gameplay much more diverse (less spamming of one unit), and these buildings would be a dependency of said counters patch. D1707 also along the road.
When a23 was developed, it was also planned to make workshops and ranges etc. accessible. At least to have the templates present (whether or not all buildings were buildable for every civ by the units.)
So perhaps you are interested to mutually check each others proposal and come up with a common or agreed one.

When the workshop templates were introduced, I understood they were not yet enabled, because A23 was “just around the corner”, but that the intention was to use them eventually in the next alpha. Now all freezes are lifted and development has restarted, I think it's a suitable time to enable the workshop.
And yes, I'm aware @borg-'s Expansion Pack, @wowgetoffyourcellphone's Delenda Est, my 0abc, and probably a few other mods are already using the workshop (and other structures); however, all these mods do much more than just that. I think the workshop can be enabled in A24 independently from implementing a counter system or some other overhaul.

Nescio added a comment.Apr 9 2019, 8:27 PM

Two days ago I started a poll on the forums – https://wildfiregames.com/forum/index.php?/topic/25628-should-workshops-be-enabled/ – and there appears to be clear majority in favour (19–2).

Nescio updated this revision to Diff 7870.Apr 26 2019, 6:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1294/display/redirect

Nescio updated this revision to Diff 7871.Apr 26 2019, 6:32 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1295/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:36 PM
Nescio updated this revision to Diff 9552.Aug 31 2019, 6:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/16/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/525/display/redirect

wraitii added a subscriber: wraitii.

This seems to make consensus gameplay-wise, so I'll ensure it gets in for A24.

wraitii updated this revision to Diff 9934.Sep 23 2019, 9:53 AM

Move the workshop icon next to the fortress icons as those are both city phase buildings and I think this makes more sense.

wraitii accepted this revision.Sep 23 2019, 9:54 AM

Works, all civs have correct actors and templates, fortresses correctly updated. I've simply moved the icon next to the fortress for keeping city-phase buildings together.

This revision is now accepted and ready to land.Sep 23 2019, 9:54 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/297/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/812/display/redirect

This revision was automatically updated to reflect the committed changes.