Page MenuHomeWildfire Games

adjust trader footprints
Needs ReviewPublic

Authored by Nescio on Feb 17 2020, 9:32 PM.

Details

Reviewers
Angen
Summary

Currently most traders have inappropiate (e.g. circular) footprints; this patch corrects them. (See also D2496.)
Before:


After:

Notice that donkey traders are centred on the human, not the donkey (@Stan).

Fundamentally there are four types of traders:

  • camel: cart, pers, ptol
  • donkey: brit, gaul, iber, kush
  • horse-drawn cart: athen, mace, rome, sele, spart
  • ox cart: maur

Because none of them has a majority, footprints have to be defined in the individual specific templates, not in the generic shared parent.

Test Plan

Check for mistakes and omissions.

Event Timeline

Nescio created this revision.Feb 17 2020, 9:32 PM
Nescio added inline comments.
binaries/data/mods/public/simulation/templates/template_unit_support_trader.xml
41

Valid for ten of them, only the three camels are higher.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1786/display/redirect

Stan added a comment.Wed, Mar 18, 12:10 PM

Notice that donkey traders are centred on the human, not the donkey (@Stan).

Should it be centered on the donkey? Then the human would go out of the circle?

Is it an either/or situation? Or can you centre on the centre of the donkey + human compound? Or the donkey's head and front legs?

Stan added a comment.Thu, Mar 19, 10:46 AM

I can probably center on the compound.

Separately, could you create a donkey trader for Athens and Sparta? Southern Greece is rather mountaineous, horses were scarce, and donkeys (and mules!) were used extensively.
Macedon and Seleucids can keep the horse-and-cart trader.

Angen requested changes to this revision.Fri, Mar 27, 3:01 PM
Angen added a subscriber: Angen.

please split footprint changes from name changes
else I agree, footprints should not be smaller than entity

This revision now requires changes to proceed.Fri, Mar 27, 3:01 PM
Nescio updated this revision to Diff 11585.Fri, Mar 27, 3:15 PM
Nescio edited the summary of this revision. (Show Details)
Owners added a subscriber: Restricted Owners Package.Fri, Mar 27, 3:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1935/display/redirect

@Feldfeld anything against? If yes do we agree that camel traders need to have the same footprint, one or another?

I personally have nothing against this, I think a slight imbalance between traders will not change much there. Can ask @ValihrAnt just in case.