Page MenuHomeWildfire Games

improve animal footprints
Needs ReviewPublic

Authored by Nescio on May 3 2020, 12:37 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch revisits the footprints of all animal templates.

  • Because all animals have different actors, footprints should be defined in the specific files (gaia/fauna_*), not in the shared templates (template_unit_fauna_*).
  • Used only values in steps of 0.5; granular steps are not really meaningful, as discussed with @fatherbushido on the forums.
  • Inserted <StatusBars/HeightOffset> nodes in the specific templates (value is equal to <Footprint/Height> + 1).
  • The crocodile currently has a 1:2 footprint, which works for mammals, however for this reptile it means its head and tail are outside; therefore this patch lengthens it to a 1:4 ratio, like the shark.
  • The donkey no longer has gaia/fauna_horse.xml as its parent.

See also D2496, D2640, #3786.

Test Plan
  • Download this test map:


  • Launch Atlas, open the fauna map, and view the current animal footprints.
  • Apply this patch, repeat previous step.
  • Verify the new footprints indeed look better.
  • Check for mistakes, omissions, and possible improvements.

Event Timeline

Nescio created this revision.May 3 2020, 12:37 PM
Owners added a subscriber: Restricted Owners Package.May 3 2020, 12:37 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2070/display/redirect

Nescio edited the summary of this revision. (Show Details)May 3 2020, 12:54 PM
elexis edited the summary of this revision. (Show Details)Fri, May 8, 7:30 PM
Nescio added a comment.Fri, May 8, 7:59 PM

#3786

Apparently the boar did have an oblong footprint at some point in the past (rP18014), but that was removed about a year later (rP19095, which contains many unrelated changes). Also the peacock.

Nescio updated this revision to Diff 11903.Sun, May 17, 3:07 PM
Nescio retitled this revision from adjust boar and hippopotamus footprints to adjust a few animal footprints.
Nescio edited the summary of this revision. (Show Details)
Nescio added a subscriber: Palaxin.

peacock, crocodile

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2147/display/redirect

Nescio edited the summary of this revision. (Show Details)Sun, May 17, 5:09 PM

Great to see my work from #3786 continued :)

In rP19723 rabbit footprint had been changed to 2 x 1.2, which is not 2:1 ratio anymore, maybe you could address that as well.
There might have been more changes and added animals in the last 3 years, did you check them all?

Nescio updated this revision to Diff 11960.Thu, May 21, 7:39 PM
  • Adjust rabbit footprint, as requested by @Palaxin.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/771/display/redirect

There might have been more changes and added animals in the last 3 years, did you check them all?

What I did is go through the current version of all fauna templates; 0 A.D. does not have that many animals. I didn't go through the svn file history of every file; only in the case when something seemed wrong (e.g. boar, peacock).

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2187/display/redirect

Nescio updated this revision to Diff 11979.Fri, May 22, 7:43 PM
  • piglet

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2204/display/redirect

Nescio edited the summary of this revision. (Show Details)Fri, May 22, 7:46 PM
Nescio planned changes to this revision.Fri, May 29, 11:49 AM

All animal footprint should probably be rechecked individually in Atlas.

Nescio updated this revision to Diff 12071.Sun, May 31, 5:11 PM
Nescio retitled this revision from adjust a few animal footprints to improve animal footprints.
Nescio edited the test plan for this revision. (Show Details)
Nescio added a subscriber: fatherbushido.
  • Because all animals have different actors, footprints should be defined in the specific files (gaia/fauna_*), not in the shared templates (template_unit_fauna_*).
  • Inserted <StatusBars/HeightOffset> nodes in the specific templates (value is equal to <Footprint/Height> + 1).
  • Reviewed and adjusted the footprint dimensions of all animals.
  • Used only values in steps of 0.5; granular steps are not really meaningful, as discussed with @fatherbushido on the forums.
  • fauna_donkey no longer has fauna_horse as its parent.
  • fauna_walrus got a circular footprint.

To do: figure out appropiate footprint heights (and corresponding status bar height offsets).

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2273/display/redirect

Nescio edited the test plan for this revision. (Show Details)Sun, May 31, 5:16 PM
Nescio edited the test plan for this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/875/display/redirect

Nescio updated this revision to Diff 12096.Mon, Jun 1, 7:54 PM
Nescio edited the summary of this revision. (Show Details)
  • <Footprint/Height> and <StatusBar/HeightOffset>
Vulcan added a comment.Mon, Jun 1, 7:55 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2289/display/redirect