Page MenuHomeWildfire Games

tweak citizen cavalry and elephant footprints
Needs ReviewPublic

Authored by Nescio on Dec 21 2019, 5:56 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Practically all fauna have a 2:1 length to width footprint ratio. However, citizen cavalry has a 3:2 ratio and worker elephants a circular footprint. This patch changes their footprints to the more appropiate 2:1 ratio.
This is how their footprints look as a consequence:


A larger footprint also makes units more vulnerable to long range projectiles (e.g. arrows), so this patch makes citizen cavalry a smaller target. For comparison:

  • citizen infantry footprint: 7
  • cavalry footprint: 24→18
  • champion and hero cavalry footprint: 19.6 (circular because of selection marker)
  • worker elephant footprint: 50→32
  • elephant archer footprint: 38→32

Also tweaked footprint height to:

  • infantry: 4
  • cavalry: 6
  • kush and ptol camel: 8
  • maur elephant archer: 10
  • maur worker elephant: 8
Test Plan

Agree this is an improvement.

Event Timeline

Nescio created this revision.Dec 21 2019, 5:56 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/841/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1357/display/redirect

Nescio updated this revision to Diff 10754.Dec 23 2019, 1:07 PM
Nescio retitled this revision from tweak citizen cavalry and worker elephant footprints to tweak citizen cavalry and elephant footprints.
Nescio edited the summary of this revision. (Show Details)

included elephant archer footprint

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/870/display/redirect

Nescio updated this revision to Diff 10756.Dec 23 2019, 1:13 PM

unnecessary replace=""

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/871/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1386/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1387/display/redirect

elexis added a subscriber: elexis.Dec 23 2019, 3:41 PM

See #3786 for the last time someone reworked all footprints to make them fit esthetically (selection ring matching visual actor size).

A larger footprint also makes units more vulnerable to long range projectiles

Is that true? I expected it uses the obstruction size, but I didn't look at the related code for a long time.

If it is true, it changes balancing slightly, so author or reviewer may want to consider that.
I guess the only relevant change is Cavalry 4 -> 3 width change, which makes it slightly harder for ranged units and structures to hit it. I don't know by how much without testing (probably not a dealbreaker but you never know).

Is that true? I expected it uses the obstruction size, but I didn't look at the related code for a long time.

Unit templates don't have a static obstruction defined in their templates, so I assumed their effective target size is based upon their footprint.

If it is true, it changes balancing slightly, so author or reviewer may want to consider that.
I guess the only relevant change is Cavalry 4 -> 3 width change, which makes it slightly harder for ranged units and structures to hit it. I don't know by how much without testing (probably not a dealbreaker but you never know).

Only at long range, because of spread. If anything, this patch would make differences between maximum range and point-blank less pronounced. E.g. at maximum range 40 infantry archers might beat 40 horse archers (due to the smaller infantry footprint), whereas at point-blank 40 horse archers could massacre the 40 infantry archers (due to the higher cavalry health). Just an example I didn't test myself, though.

Nescio edited the summary of this revision. (Show Details)Dec 23 2019, 3:57 PM
Nescio removed a reviewer: borg-.Sat, Jan 18, 2:34 PM

Unit templates don't have a static obstruction defined in their templates, so I assumed their effective target size is based upon their footprint.

The related code (Attacking.js-helper; L137 onwards) shows that footprints are indeed used.

Nescio edited reviewers, added: Restricted Owners Package; removed: Restricted Owners Package.Sun, Jan 19, 11:27 AM
Nescio added a subscriber: ValihrAnt.