A lot has changed since D1377/rP22137 was committed, and some loading screen tips are now incorrect. This patch partially rewrites those of the barracks, forge, and fortress.
Furthermore, the “trade commercial treaty” technology's description has been replaced, to better explain the international bonus. The “unlock shared dropsites” and “unlock shared vision” technologies also receive new descriptions, to better justify their effects.
The latter is also renamed from “cartography” to “messenger pigeons”. Nowadays people are so used to maps that it's easy to forget how conceptually challenging they really are. Although maps gradually emerged during antiquity, they were never common, the usable maps that did exist were more something of Roman times (the Tabula Peutingeriana is probably the most famous) and looked quite different from ours. Cartography as we know it really took off in the early modern period.
Details
- Reviewers
wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Consider critically whether these could be further improved. Check for typos.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 15231 Build 33106: Vulcan Build Jenkins Build 33105: Vulcan Build (macOS) Jenkins Build 33104: Vulcan Build (Windows) Jenkins Build 33103: arc lint + arc unit
Event Timeline
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgui_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for
See https://jenkins.wildfiregames.com/job/macos-differential/2920/display/redirect for more details.
| binaries/data/mods/public/gui/text/tips/forge.txt | ||
|---|---|---|
| 3 | I'm not sure making it more accurate to the workings behind the scenes makes it more clear, might also confuse translators no? | |
I think we're losing a little flair with the 'messengers' techs. Cartography, even if it's unrealistic, made sense in context because our game's interface is a map. And I liked the description more, the new one is very utilitarian.
Angen pointed out in rP24605 pointed out the current descriptions of these two unlock technologies do not reflect they're essentially diplomatic, hence the need to rewrite them.
I think we're losing a little flair with the 'messengers' techs. Cartography, even if it's unrealistic, made sense in context because our game's interface is a map. And I liked the description more, the new one is very utilitarian.
Yes, I agree the name is a bit boring. How about “messenger pigeons" instead? We could mention the Olympics and the icon is already a biblical white dove with olive branch or something.
Cartography, even if it's unrealistic, made sense in context because our game's interface is a map.
The minimap is also there without researching this technology.
| binaries/data/mods/public/gui/text/tips/forge.txt | ||
|---|---|---|
| 3 | Armour has been renamed to resistance some time ago and everywhere else (I hope: to do: do a grep) resistance is referred to as resistance, so talking about armor here is not only inconsistent, but also potentially confusing. | |
| binaries/data/mods/public/gui/text/tips/forge.txt | ||
|---|---|---|
| 3 | Yeah but technically you would do armour researches to increase resistance, the armour being the actual thing improved while the resistance is the gameplay counterpart? I mean it could be a research about greaves to increase resistance | |
Would be a really cool mechanic xD
| binaries/data/mods/public/gui/text/tips/forge.txt | ||
|---|---|---|
| 3 | Please mind the difference between damage resistance, capture resistance and status effects resistance. So either damage resistance (as it stands now in vanilla) or just armour, as @Stan noted. | |
| binaries/data/mods/public/simulation/data/technologies/unlock_shared_dropsites.json | ||
| 3 | Why change this? Is there something wrong here? | |
Description of aura of the kush large pyramids needs to be changed from armor to resistance.
Build is green
builderr-debug-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking. ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framewor
See https://jenkins.wildfiregames.com/job/macos-differential/2960/display/redirect for more details.
I disagree with the change in the shared dropsites tech. The rest seems okay.
| binaries/data/mods/public/simulation/data/technologies/unlock_shared_los.json | ||
|---|---|---|
| 3 | Sounds reasonable. | |
I'm not a fan of several of these, to be honest.
If you don't update, I think I'll merge tomorrow the barracks & fortress tips since the change is needed, possibly Cartography, and leave the rest alone for now.
| binaries/data/mods/public/gui/text/tips/forge.txt | ||
|---|---|---|
| 3 | Think this is worse. | |
| binaries/data/mods/public/gui/text/tips/fortress.txt | ||
| 2–4 | maybe "defensive strongpoint" over "strong structure", which while accurate isn't that helpful. | |
| binaries/data/mods/public/simulation/data/technologies/trade_commercial_treaty.json | ||
| 3 | With an improved tooltip this just seems wordy. | |
| 11 | This isn't clear. I would prefer something like 10% trade bonus when trading with other players. I think trade structure is rather redundant since we have no non-trade structure for trading. | |
| binaries/data/mods/public/simulation/data/technologies/unlock_shared_dropsites.json | ||
| 3 | I think I actually prefer the old one. | |
| binaries/data/mods/public/simulation/data/technologies/unlock_shared_dropsites.json | ||
|---|---|---|
| 3 | I mostly like this one, but "exploit" isn't great, particularly if you look at the modern usage of the word with regards to colonialism and the fact that there are modern diasporas. Maybe strengthening the ties between both economies., which also relates to dropsites somewhat more. | |