Differential D2914 Authored by Nescio on Jul 27 2020, 3:21 PM.
Tags None Referenced Files
Subscribers
Details
Summary This patch is a follow-up to D2591/rP23876. It renames all *javelinist* templates to *javelineer* and corrects all occurrences in the simulation/ files. find binaries/data/mods/public/maps/ \( -name '*.js' -o -name '*.json' -o -name '*.xml' \) -print0 | xargs -0 sed -i 's,javelinist,javelineer,g' Test Plan Check for correctness and completeness.
Diff Detail
Event TimelineOwners added a subscriber: Restricted Owners Package.Jul 27 2020, 3:21 PM2020-07-27 15:21:35 (UTC+2) Nescio edited the summary of this revision. (Show Details)Jul 27 2020, 3:25 PM2020-07-27 15:25:54 (UTC+2) Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2791/display/redirect Harbormaster completed remote builds in B12635: Diff 12938.Jul 27 2020, 3:41 PM2020-07-27 15:41:37 (UTC+2) Freagarach edited reviewers, added: Freagarach; removed: Restricted Owners Package.Aug 6 2020, 7:02 AM2020-08-06 07:02:42 (UTC+2) This revision is now accepted and ready to land.Aug 7 2020, 3:05 PM2020-08-07 15:05:37 (UTC+2) Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2956/display/redirect Harbormaster completed remote builds in B12840: Diff 13155.Aug 10 2020, 7:54 AM2020-08-10 07:54:05 (UTC+2) Closed by commit rP23956: Javelinist -> Javelineer in templates. (authored by Freagarach). · Explain WhyAug 10 2020, 8:00 AM2020-08-10 08:00:27 (UTC+2) This revision was automatically updated to reflect the committed changes. Owners added a subscriber: Restricted Owners Package.Aug 10 2020, 8:00 AM2020-08-10 08:00:27 (UTC+2) Comment Actions
It would be more consistent, so I'd be in favour; it's up to the art team to decide, though.
What do you mean by that? Comment Actions I mean they are binaries and I would guess renaming them would perhaps duplicate them in the version history. I'm not sure how SVN (or any SCM for that matters) handles binaries and renaming thereof ^^ Comment Actions
That has never been an objection in the past.
I don't know either, but I guess if images are replaced, both versions are preserved in the version history, but if they're simply moved, then the files themselves aren't changed, only their location is, so there is no real need to duplicate them? Large DiffThis large diff affects 228 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Diff 12938 Wildfire Games · Phabricator |